YetiForceCompany/YetiForceCRM

View on GitHub
modules/com_vtiger_workflow/VTConditionalExpression.php

Summary

Maintainability
A
25 mins
Test Coverage
F
0%

Function evalGate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private function evalGate($tree)
    {
        if (\in_array($tree[0], ['and', 'or'])) {
            switch ($tree[0]) {
                case 'and':
Severity: Minor
Found in modules/com_vtiger_workflow/VTConditionalExpression.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '17', column '17').
Open

        $parser = new VTConditionalParser($expression);

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method evalGate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return $this->evalCondition($tree);
        }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Reference to undeclared property \VTConditionalExpression->env (Did you mean $_ENV)
Open

        $this->env = $data;

Reference to undeclared property \VTConditionalExpression->expTree
Open

        return $this->evalGate($this->expTree);

Reference to undeclared property \VTConditionalExpression->expTree
Open

        $this->expTree = $parser->parse();

Reference to undeclared property \VTConditionalExpression->env (Did you mean $_ENV)
Open

                return $this->env[$value];

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class VTConditionalExpression

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 13 and the first side effect is on line 10.
Open

<?php

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

            }

Spaces must be used to indent lines; tabs are not allowed
Open

                return $value;

Spaces must be used to indent lines; tabs are not allowed
Open

                break;

Spaces must be used to indent lines; tabs are not allowed
Open

                    return $this->evalGate($tree[1]) && $this->evalGate($tree[2]);

Spaces must be used to indent lines; tabs are not allowed
Open

            return (int) $this->getVal($tree[1]) == (int) $this->getVal($tree[2]);

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->expTree = $parser->parse();

Spaces must be used to indent lines; tabs are not allowed
Open

    private function evalGate($tree)

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->env = $data;

Spaces must be used to indent lines; tabs are not allowed
Open

        $parser = new VTConditionalParser($expression);

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

            default:

Spaces must be used to indent lines; tabs are not allowed
Open

            return $this->evalCondition($tree);

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

                case 'or':

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

        [$valueType, $value] = $node;

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

        if (\in_array($tree[0], ['and', 'or'])) {

Spaces must be used to indent lines; tabs are not allowed
Open

                case 'and':

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

                    return $this->evalGate($tree[1]) || $this->evalGate($tree[2]);

Spaces must be used to indent lines; tabs are not allowed
Open

            switch ($tree[0]) {

Spaces must be used to indent lines; tabs are not allowed
Open

            case 'sym':

Spaces must be used to indent lines; tabs are not allowed
Open

            case 'num':

Spaces must be used to indent lines; tabs are not allowed
Open

        if ('=' === $tree[0]) {

Spaces must be used to indent lines; tabs are not allowed
Open

        switch ($valueType) {

Spaces must be used to indent lines; tabs are not allowed
Open

        return $this->evalGate($this->expTree);

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

                return $this->env[$value];

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

                    break;

Spaces must be used to indent lines; tabs are not allowed
Open

        } else {

Spaces must be used to indent lines; tabs are not allowed
Open

    public function __construct($expression)

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

    public function evaluate($data)

Spaces must be used to indent lines; tabs are not allowed
Open

                default:

Spaces must be used to indent lines; tabs are not allowed
Open

    private function evalCondition($tree)

Spaces must be used to indent lines; tabs are not allowed
Open

    private function getVal($node)

There are no issues that match your filters.

Category
Status