modules/com_vtiger_workflow/VTConditionalExpression.php
Function evalGate
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
private function evalGate($tree)
{
if (\in_array($tree[0], ['and', 'or'])) {
switch ($tree[0]) {
case 'and':
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '17', column '17'). Open
Open
$parser = new VTConditionalParser($expression);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method evalGate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
return $this->evalCondition($tree);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Reference to undeclared property \VTConditionalExpression->env
(Did you mean $_ENV) Open
Open
$this->env = $data;
- Exclude checks
Reference to undeclared property \VTConditionalExpression->expTree
Open
Open
return $this->evalGate($this->expTree);
- Exclude checks
Reference to undeclared property \VTConditionalExpression->expTree
Open
Open
$this->expTree = $parser->parse();
- Exclude checks
Reference to undeclared property \VTConditionalExpression->env
(Did you mean $_ENV) Open
Open
return $this->env[$value];
- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class VTConditionalExpression
- Exclude checks
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 13 and the first side effect is on line 10. Open
Open
<?php
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $value;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->evalGate($tree[1]) && $this->evalGate($tree[2]);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return (int) $this->getVal($tree[1]) == (int) $this->getVal($tree[2]);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->expTree = $parser->parse();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private function evalGate($tree)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->env = $data;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$parser = new VTConditionalParser($expression);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
default:
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->evalCondition($tree);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'or':
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
[$valueType, $value] = $node;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (\in_array($tree[0], ['and', 'or'])) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'and':
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->evalGate($tree[1]) || $this->evalGate($tree[2]);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
switch ($tree[0]) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'sym':
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'num':
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ('=' === $tree[0]) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
switch ($valueType) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->evalGate($this->expTree);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->env[$value];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function __construct($expression)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function evaluate($data)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
default:
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private function evalCondition($tree)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private function getVal($node)
- Exclude checks