Function checkCondition has a Cognitive Complexity of 110 (exceeds 5 allowed). Consider refactoring.

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)
    {
        $condition = $cond['operation'];
        $fieldInstance = $recordModel->getModule()->getFieldByName($cond['fieldname']);
        if (empty($condition) || false === $fieldInstance) {

• Read up
  Read up

Method checkCondition has 377 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)
    {
        $condition = $cond['operation'];
        $fieldInstance = $recordModel->getModule()->getFieldByName($cond['fieldname']);
        if (empty($condition) || false === $fieldInstance) {

Function evaluate has a Cognitive Complexity of 72 (exceeds 5 allowed). Consider refactoring.

Open

    public function evaluate($condition, Vtiger_Record_Model $recordModel)
    {
        $expr = \App\Json::decode($condition);
        $finalResult = true;
        if (\is_array($expr)) {

• Read up
  Read up

File VTJsonCondition.php has 494 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/* +**********************************************************************************
 * The contents of this file are subject to the vtiger CRM Public License Version 1.0
 * ("License"); You may not use this file except in compliance with the License
 * The Original Code is:  vtiger CRM Open Source

Method evaluate has 89 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function evaluate($condition, Vtiger_Record_Model $recordModel)
    {
        $expr = \App\Json::decode($condition);
        $finalResult = true;
        if (\is_array($expr)) {

The class VTJsonCondition has an overall complexity of 192 which is very high. The configured complexity threshold is 50.

Open

class VTJsonCondition
{
    /**
     * Evaluate.
     *

• Exclude checks
  • Disable engine
  • Disable check

Avoid too many return statements within this method.

Open

                                return $result;

Avoid too many return statements within this method.

Open

                        return 'on' === $fieldValue || 1 === $fieldValue || '1' === $fieldValue;

Avoid too many return statements within this method.

Open

                return preg_match($value, $fieldValue);

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                return true;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                                return empty(array_diff($value, $fieldValue));

Avoid too many return statements within this method.

Open

                    return !\in_array($fieldValue, $value);

Avoid too many return statements within this method.

Open

                return $fieldValue != $hasChanged;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                return $recordModel->get($fieldInstance->getName()) !== $recordModel->get('created_user_id');

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                return true;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                return $fieldValue > $value;

Avoid too many return statements within this method.

Open

                return $fieldValue != $value;

Avoid too many return statements within this method.

Open

                    return $fieldValue != $value;

Avoid too many return statements within this method.

Open

                    return \in_array($fieldValue, $value);

Avoid too many return statements within this method.

Open

                return $fieldValue < $value;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                                return !empty(array_diff($value, $fieldValue));

Avoid too many return statements within this method.

Open

                return $this->startsWith($fieldValue, $value);

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                                return $result;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                return ($recordModel->isNew() || false !== $oldValue) && $recordModel->get($cond['fieldname']) == $value;

Avoid too many return statements within this method.

Open

                return $fieldValue == $value;

Avoid too many return statements within this method.

Open

                        return 'off' === $fieldValue || 0 === $fieldValue || '0' === $fieldValue || '' === $fieldValue;

Avoid too many return statements within this method.

Open

                return false === $recordModel->getPreviousValue($cond['fieldname']);

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                return (int) $value !== \App\User::getCurrentUserId() ? false : true;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                    return 'on' === $fieldValue || 1 === $fieldValue || '1' === $fieldValue;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                return (int) $value === \App\User::getCurrentUserId() ? false : true;

Avoid too many return statements within this method.

Open

                return $fieldValue > $value;

Avoid too many return statements within this method.

Open

                return $fieldValue <= $value;

Avoid too many return statements within this method.

Open

                return $fieldValue >= $value;

Avoid too many return statements within this method.

Open

                    return 'off' === $fieldValue || 0 === $fieldValue || '0' === $fieldValue || '' === $fieldValue;

Avoid too many return statements within this method.

Open

                    return $fieldValue == $value;

Avoid too many return statements within this method.

Open

                return false === strpos($fieldValue, $value);

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                return true;

Avoid too many return statements within this method.

Open

                return $fieldValue < $value;

Avoid too many return statements within this method.

Open

                return $this->endsWith($fieldValue, $value);

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                    return false;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                return false !== strpos($fieldValue, $value);

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                    return true;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                return false;

Avoid too many return statements within this method.

Open

                return false;

The method checkCondition() has 398 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)
    {
        $condition = $cond['operation'];
        $fieldInstance = $recordModel->getModule()->getFieldByName($cond['fieldname']);
        if (empty($condition) || false === $fieldInstance) {

• Exclude checks
  • Disable engine
  • Disable check

The method checkCondition() has an NPath complexity of 453000. The configured NPath complexity threshold is 200.

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)
    {
        $condition = $cond['operation'];
        $fieldInstance = $recordModel->getModule()->getFieldByName($cond['fieldname']);
        if (empty($condition) || false === $fieldInstance) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method evaluate() has an NPath complexity of 7525. The configured NPath complexity threshold is 200.

Open

    public function evaluate($condition, Vtiger_Record_Model $recordModel)
    {
        $expr = \App\Json::decode($condition);
        $finalResult = true;
        if (\is_array($expr)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method checkCondition() has a Cyclomatic Complexity of 159. The configured cyclomatic complexity threshold is 10.

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)
    {
        $condition = $cond['operation'];
        $fieldInstance = $recordModel->getModule()->getFieldByName($cond['fieldname']);
        if (empty($condition) || false === $fieldInstance) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The method evaluate() has a Cyclomatic Complexity of 29. The configured cyclomatic complexity threshold is 10.

Open

    public function evaluate($condition, Vtiger_Record_Model $recordModel)
    {
        $expr = \App\Json::decode($condition);
        $finalResult = true;
        if (\is_array($expr)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

This function "checkCondition" has 397 lines, which is greater than the 150 lines authorized. Split it into smaller functions.

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Reduce the number of switch cases from 42 to at most 30.

Open

        switch ($condition) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Refactor this function to reduce its Cognitive Complexity from 81 to the 15 allowed.

Open

    public function evaluate($condition, Vtiger_Record_Model $recordModel)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Reduce the number of returns of this function 89, down to the maximum allowed 3.

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function myFunction(){ // Noncompliant as there are 4 return statements
  if (condition1) {
    return true;
  } else {
    if (condition2) {
      return false;
    } else {
      return true;
    }
  }
  return false;
}

Refactor this function to reduce its Cognitive Complexity from 187 to the 15 allowed.

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class VTJsonCondition has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13.

Open

class VTJsonCondition
{
    /**
     * Evaluate.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Missing class import via use statement (line '176', column '18').

Open

            $parser = new VTExpressionParser(new VTExpressionSpaceFilter(new VTExpressionTokenizer($value)));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '176', column '69').

Open

            $parser = new VTExpressionParser(new VTExpressionSpaceFilter(new VTExpressionTokenizer($value)));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '176', column '41').

Open

            $parser = new VTExpressionParser(new VTExpressionSpaceFilter(new VTExpressionTokenizer($value)));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '178', column '25').

Open

            $exprEvaluater = new VTFieldExpressionEvaluater($expression);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '541', column '15').

Open

                throw new \App\Exceptions\AppException('Found an unexpected condition: ' . $condition);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid assigning values to variables in if clauses and the like (line '531', column '7').

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)
    {
        $condition = $cond['operation'];
        $fieldInstance = $recordModel->getModule()->getFieldByName($cond['fieldname']);
        if (empty($condition) || false === $fieldInstance) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

The method checkCondition uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $fieldValue = $recordModel->get($fieldName);
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Json' in method 'evaluate'.

Open

        $expr = \App\Json::decode($condition);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method checkCondition uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $value = $recordModel->get($value);
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'Vtiger_Watchdog_Model' in method 'checkCondition'.

Open

                $watchdog = Vtiger_Watchdog_Model::getInstanceById($recordModel->getId(), $recordModel->getModuleName());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\User' in method 'checkCondition'.

Open

                return (int) $value !== \App\User::getCurrentUserId() ? false : true;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method evaluate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                        } else { // Case for the first condition
                            $groupResult = $result;
                        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid assigning values to variables in if clauses and the like (line '523', column '7').

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)
    {
        $condition = $cond['operation'];
        $fieldInstance = $recordModel->getModule()->getFieldByName($cond['fieldname']);
        if (empty($condition) || false === $fieldInstance) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Avoid using static access to class '\Settings_TreesManager_Record_Model' in method 'checkCondition'.

Open

                                $value = \Settings_TreesManager_Record_Model::getChildren(implode('##', $value), $fieldInstance->getColumnName(), \Vtiger_Module_Model::getInstance($recordModel->getModule()->getName()));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method checkCondition uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $fieldValue = $recordModel->get($cond['fieldname']);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\Settings_TreesManager_Record_Model' in method 'checkCondition'.

Open

                                $value = \Settings_TreesManager_Record_Model::getChildren(implode('##', $value), $fieldInstance->getColumnName(), \Vtiger_Module_Model::getInstance($recordModel->getModule()->getName()));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Vtiger_Watchdog_Model' in method 'checkCondition'.

Open

                $watchdog = Vtiger_Watchdog_Model::getInstanceById($recordModel->getId(), $recordModel->getModuleName());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Record' in method 'evaluate'.

Open

                            if (\App\Record::isExists($referenceFieldId)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method evaluate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                    } else { // Case for the first condition
                        $finalResult = $result;
                    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\User' in method 'checkCondition'.

Open

                return (int) $value === \App\User::getCurrentUserId() ? false : true;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\RecordStatus' in method 'checkCondition'.

Open

                    ($fieldName = App\RecordStatus::getFieldName($recordModel->getModule()->getName()))

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\RecordStatus' in method 'checkCondition'.

Open

                && \in_array($recordModel->get($fieldName), App\RecordStatus::getStates($recordModel->getModule()->getName(), \App\RecordStatus::RECORD_STATE_CLOSED))

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Fields\Owner' in method 'evaluate'.

Open

                        } elseif ('Users' === \App\Fields\Owner::getType($referenceFieldId) && \App\User::getUserModel($referenceFieldId)->isActive()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Fields\Date' in method 'checkCondition'.

Open

                        $value = \App\Fields\Date::formatToDb($value, true);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Vtiger_Record_Model' in method 'evaluate'.

Open

                                $referenceRecordModel = Vtiger_Record_Model::getInstanceById($referenceFieldId);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method checkCondition uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                        } else {
                            $value = [];
                        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method evaluate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                } else {
                    $referenceField = $matches[1];
                    $referenceModule = $matches[2];
                    $fieldname = $matches[3];
                    $result = false;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'App\RecordStatus' in method 'checkCondition'.

Open

                    ($fieldName = App\RecordStatus::getFieldName($recordModel->getModule()->getName()))

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method checkCondition uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $value = $exprEvaluater->evaluate($recordModel);
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'Vtiger_Record_Model' in method 'evaluate'.

Open

                            $referenceRecordModel = Vtiger_Record_Model::getInstanceById($referenceFieldId, $referenceModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Module_Model' in method 'checkCondition'.

Open

                                $value = \Settings_TreesManager_Record_Model::getChildren(implode('##', $value), $fieldInstance->getColumnName(), \Vtiger_Module_Model::getInstance($recordModel->getModule()->getName()));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Module_Model' in method 'checkCondition'.

Open

                                $value = \Settings_TreesManager_Record_Model::getChildren(implode('##', $value), $fieldInstance->getColumnName(), \Vtiger_Module_Model::getInstance($recordModel->getModule()->getName()));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\RecordStatus' in method 'checkCondition'.

Open

                && \in_array($recordModel->get($fieldName), App\RecordStatus::getStates($recordModel->getModule()->getName(), \App\RecordStatus::RECORD_STATE_OPEN))

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Define a constant instead of duplicating this literal "is not" 5 times.

Open

                    if (\in_array($condition, ['contains', 'contains hierarchy', 'does not contain', 'does not contain hierarchy', 'is', 'is not'])) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal " hours" 4 times.

Open

                $olderDateTime = date('Y-m-d H:i:s', strtotime('-' . $value . ' hours'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "contains" 5 times.

Open

                    if (\in_array($condition, ['contains', 'contains hierarchy', 'does not contain', 'does not contain hierarchy', 'is', 'is not'])) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "result" 6 times.

Open

                    $expressionResults[$conditionGroup][$i]['result'] = $this->checkCondition($recordModel, $cond);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "Y-m-d H:i:s" 8 times.

Open

                    $value = date('Y-m-d H:i:s');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "does not contain" 5 times.

Open

                    if (\in_array($condition, ['contains', 'contains hierarchy', 'does not contain', 'does not contain hierarchy', 'is', 'is not'])) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal " days" 6 times.

Open

                $olderDate = date('Y-m-d', strtotime('-' . $value . ' days'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "logicaloperator" 5 times.

Open

                $expressionResults[$conditionGroup][$i + 1]['logicaloperator'] = (!empty($cond['joincondition'])) ? $cond['joincondition'] : 'and';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "datetime" 4 times.

Open

        if ('datetime' === $dataType || 'date' === $dataType) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "Y-m-d" 11 times.

Open

                $value = date('Y-m-d');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "fieldname" 10 times.

Open

                preg_match('/(\w+) : \((\w+)\) (\w+)/', $cond['fieldname'], $matches);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Argument 1 (moduleName) is false but \App\RecordStatus::getFieldName() takes string defined at /code/app/RecordStatus.php:406

Open

                    ($fieldName = App\RecordStatus::getFieldName($recordModel->getModule()->getName()))

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (moduleName) is false but \App\RecordStatus::getFieldName() takes string defined at /code/app/RecordStatus.php:406

Open

                    ($fieldName = App\RecordStatus::getFieldName($recordModel->getModule()->getName()))

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (mixed) is false but \Vtiger_Module_Model::getInstance() takes int|string defined at /code/modules/Vtiger/models/Module.php:197

Open

                                $value = \Settings_TreesManager_Record_Model::getChildren(implode('##', $value), $fieldInstance->getColumnName(), \Vtiger_Module_Model::getInstance($recordModel->getModule()->getName()));

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (encodedValue) is array but \App\Json::decode() takes string defined at /code/app/Json.php:37

Open

        $expr = \App\Json::decode($condition);

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (mixed) is false but \Vtiger_Module_Model::getInstance() takes int|string defined at /code/modules/Vtiger/models/Module.php:197

Open

                                $value = \Settings_TreesManager_Record_Model::getChildren(implode('##', $value), $fieldInstance->getColumnName(), \Vtiger_Module_Model::getInstance($recordModel->getModule()->getName()));

• Exclude checks
  • Disable engine
  • Disable check

Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

                return (int) $value === \App\User::getCurrentUserId() ? false : true;

• Exclude checks
  • Disable engine
  • Disable check

Returning type bool but evaluate() is declared to return string

Open

        return $finalResult;

• Exclude checks
  • Disable engine
  • Disable check

Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

                return (int) $value !== \App\User::getCurrentUserId() ? false : true;

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (moduleName) is false but \App\RecordStatus::getStates() takes string defined at /code/app/RecordStatus.php:113

Open

                && \in_array($recordModel->get($fieldName), App\RecordStatus::getStates($recordModel->getModule()->getName(), \App\RecordStatus::RECORD_STATE_CLOSED))

• Exclude checks
  • Disable engine
  • Disable check

Call to method getType from undeclared class \App\Fields\Owner

Open

                        } elseif ('Users' === \App\Fields\Owner::getType($referenceFieldId) && \App\User::getUserModel($referenceFieldId)->isActive()) {

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (moduleName) is false but \App\RecordStatus::getStates() takes string defined at /code/app/RecordStatus.php:113

Open

                && \in_array($recordModel->get($fieldName), App\RecordStatus::getStates($recordModel->getModule()->getName(), \App\RecordStatus::RECORD_STATE_OPEN))

• Exclude checks
  • Disable engine
  • Disable check

Call to method getUserModel from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

                        } elseif ('Users' === \App\Fields\Owner::getType($referenceFieldId) && \App\User::getUserModel($referenceFieldId)->isActive()) {

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (array_arg) is string but \sort() takes array

Open

                                    sort($value);

• Exclude checks
  • Disable engine
  • Disable check

Remove the code after this "return".

Open

                    return $value === $fieldValue;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function fun($a) {
  $i = 10;
  return $i + $a;
  $i++;             // this is never executed
}

function foo($a) {
  if ($a == 5) {
    goto error;
  } else {
    // do the job
  }
  return;

  error:
    printf("don't use 5"); // this is reachable but unreadable

}

function fun($a) {
  $i = 10;
  return $i + $a;
}

function foo($a) {
  if ($a == 5) {
    handleError();
  } else {
    // do the job
  }
  return;
}

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            case 'less than hours later':
                if (empty($rawFieldValue) || empty($value)) {
                    return false;
                }
                $currentTime = date('Y-m-d H:i:s');

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            case 'less than hours before':
                if (empty($rawFieldValue) || empty($value)) {
                    return false;
                }
                $currentTime = date('Y-m-d H:i:s');

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            case 'in less than':
                if (empty($fieldValue) || empty($value)) {
                    return false;
                }
                $today = date('Y-m-d');

• Read up
  Read up

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class VTJsonCondition

• Exclude checks
  • Disable engine
  • Disable check

Avoid variables with short names like $sl. Configured minimum length is 3.

Open

        $sl = \strlen($str);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $sl. Configured minimum length is 3.

Open

        $sl = \strlen($str);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $i. Configured minimum length is 3.

Open

            $i = 0;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Terminating statement must be indented to the same level as the CASE body

Open

                    break;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    return $value === $fieldValue;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    break;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    break;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    break;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    break;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    break;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    break;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    break;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    break;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    return $fieldValue != $value;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

                    return $fieldValue == $value;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            if (\App\Record::isExists($referenceFieldId)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return string

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $i = 0;

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 152 characters

Open

                        } elseif ('Users' === \App\Fields\Owner::getType($referenceFieldId) && \App\User::getUserModel($referenceFieldId)->isActive()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                $result = $this->checkCondition($referenceRecordModel, $cond, $recordModel);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function evaluate($condition, Vtiger_Record_Model $recordModel)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                $referenceRecordModel = Vtiger_Record_Model::getInstanceById($referenceFieldId);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param array               $condition

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            foreach ($expr as $cond) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $referenceField = $matches[1];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $conditionGroup = $cond['groupid'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $referenceModule = $matches[2];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Evaluate.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                preg_match('/(\w+) : \((\w+)\) (\w+)/', $cond['fieldname'], $matches);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    if (!empty($referenceFieldId)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $groupResults = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        } elseif ('Users' === \App\Fields\Owner::getType($referenceFieldId) && \App\User::getUserModel($referenceFieldId)->isActive()) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 126 characters

Open

                            $referenceRecordModel = Vtiger_Record_Model::getInstanceById($referenceFieldId, $referenceModule);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (\is_array($expr)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if (0 == \count($matches)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $expressionResults = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if (empty($conditionGroup)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $fieldname = $matches[3];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        $cond['fieldname'] = $fieldname;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $expr = \App\Json::decode($condition);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $expressionResults[$conditionGroup][$i]['result'] = $this->checkCondition($recordModel, $cond);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $result = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param Vtiger_Record_Model $recordModel

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        if ('Users' !== $referenceModule) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            $referenceRecordModel = Vtiger_Record_Model::getInstanceById($referenceFieldId, $referenceModule);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            $result = $this->checkCondition($referenceRecordModel, $cond, $recordModel);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $finalResult = true;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $conditionGroup = 0;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $referenceFieldId = $recordModel->get($referenceField);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                    break;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $logicalOperator = $groupResult['logicaloperator'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $sl = \strlen($str);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($sl >= $ssl) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 124 characters

Open

    public function checkCondition(Vtiger_Record_Model $recordModel, $cond, Vtiger_Record_Model $referredRecordModel = null)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (null !== $referredRecordModel) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $fieldValue = $recordModel->get($fieldInstance->getName());

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 147 characters

Open

                $expressionResults[$conditionGroup][$i + 1]['logicaloperator'] = (!empty($cond['joincondition'])) ? $cond['joincondition'] : 'and';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        $logicalOperator = $exprResult['logicaloperator'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            case 'and':

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        $finalResult = $result;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return bool

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance = $recordModel->getModule()->getFieldByName($cond['fieldname']);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('fieldname' === $expressionType) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $parser = new VTExpressionParser(new VTExpressionSpaceFilter(new VTExpressionTokenizer($value)));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    if (\count($recordData) > 1) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                foreach ($groupExprResultSet as &$exprResult) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                    $groupResult = ($groupResult && $result);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if (isset($result)) { // Condition to skip last condition

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function startsWith($str, $subStr)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $ssl = \strlen($subStr);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $expressionType = $cond['valuetype'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $expression = $parser->expression();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                    $groupResult = ($groupResult || $result);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        switch ($logicalOperator) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $dataType = $fieldInstance->getFieldDataType();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                case 'date':

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $result = null;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        if (isset($logicalOperator)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $sl = \strlen($str);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return 0 == substr_compare($str, $subStr, $sl - $ssl, $ssl);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Check condition.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        $fieldValue = trim("$recordData[0] $recordData[1]");

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $groupResults[$conditionGroup]['logicaloperator'] = (!empty($cond['groupjoin'])) ? $cond['groupjoin'] : 'and';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                case 'and':

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                case 'or':

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            foreach ($groupResults as $groupId => &$groupResult) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $result = $groupResult['result'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                $finalResult = ($finalResult && $result);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $expressionResults[$conditionGroup][$i + 1]['logicaloperator'] = (!empty($cond['joincondition'])) ? $cond['joincondition'] : 'and';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                break;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            case 'or':

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $ssl = \strlen($subStr);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                break;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($sl >= $ssl) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function endsWith($str, $subStr)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param Vtiger_Record_Model|null $referredRecordModel

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $value = $recordModel->get($value);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @throws Exception

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        switch ($dataType) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $value = trim(html_entity_decode($cond['value'] ?? ''));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    break;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $groupResult = true;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    if (isset($exprResult['result'])) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        $result = $exprResult['result'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    if (isset($result)) { // Condition to skip last condition

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                    break;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                                default:

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param Vtiger_Record_Model      $recordModel

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param array                    $cond

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $condition = $cond['operation'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('datetime' === $dataType || 'date' === $dataType) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $value = $exprEvaluater->evaluate($referredRecordModel);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    if (isset($exprResult['logicaloperator'])) {