Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/com_vtiger_workflow/VTWorkflowApplication.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Avoid using static access to class '\App\Request' in method '__construct'.
Open

        $this->returnUrl = \App\Request::_getServer('REQUEST_URI');
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\App\Request' in method 'currentUrl'.
Open

        return \App\Request::_getServer('REQUEST_URI');
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Reference to undeclared property \VTWorkflowApplication->name
Open

        $this->name = 'com_vtiger_workflow';
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->returnUrl (Did you mean \VTWorkflowApplication->returnUrl() or $returnUrl)
Open

        $this->returnUrl = $returnUrl;
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->request (Did you mean $_REQUEST)
Open

        $this->request;
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->name
Open

        return "index.php?module={$this->name}&action=deletetask$idPart&return_url=" . urlencode($this->returnUrl());
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->returnUrl (Did you mean \VTWorkflowApplication->returnUrl())
Open

        $this->returnUrl = \App\Request::_getServer('REQUEST_URI');
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Unused property
Open

        $this->request;
Severity: Info
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->label
Open

        $this->label = 'Workflow';
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->returnUrl (Did you mean \VTWorkflowApplication->returnUrl())
Open

        return $this->returnUrl;
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->name
Open

        return "index.php?module={$this->name}&action=editworkflow$idPart&return_url=" . urlencode($this->returnUrl());
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->name
Open

        return "index.php?module={$this->name}&action=workflowlist";
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->name
Open

        return "index.php?module={$this->name}&action=edittask$idPart&return_url=" . urlencode($this->returnUrl());
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->name
Open

        return "index.php?module={$this->name}&action=errormessage&message=" . urlencode($message);
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->action (Did you mean $action)
Open

        $this->action = $action;
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Reference to undeclared property \VTWorkflowApplication->name
Open

        return "index.php?module={$this->name}&action=deleteworkflow$idPart&return_url=" . urlencode($this->returnUrl());
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phan

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class VTWorkflowApplication
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function deleteTaskUrl($id)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function editWorkflowUrl($id = null)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function editTaskUrl($id = null)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function deleteWorkflowUrl($id)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Spaces must be used to indent lines; tabs are not allowed
Open

    public function listViewUrl()
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $idPart = "&workflow_id=$id";
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return "index.php?module={$this->name}&action=errormessage&message=" . urlencode($message);
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function __construct($action)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (null !== $id) {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Line exceeds 120 characters; contains 121 characters
Open

        return "index.php?module={$this->name}&action=deleteworkflow$idPart&return_url=" . urlencode($this->returnUrl());
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return $this->returnUrl;
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->returnUrl = $returnUrl;
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return "index.php?module={$this->name}&action=deletetask$idPart&return_url=" . urlencode($this->returnUrl());
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->name = 'com_vtiger_workflow';
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function deleteTaskUrl($id)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->action = $action;
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function editWorkflowUrl($id = null)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->request;
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function deleteWorkflowUrl($id)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function errorPageUrl($message)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->returnUrl = \App\Request::_getServer('REQUEST_URI');
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function editTaskUrl($id = null)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (null !== $id) {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return "index.php?module={$this->name}&action=edittask$idPart&return_url=" . urlencode($this->returnUrl());
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return \App\Request::_getServer('REQUEST_URI');
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $idPart = "&task_id=$id";
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $idPart = "&workflow_id=$id";
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return "index.php?module={$this->name}&action=deleteworkflow$idPart&return_url=" . urlencode($this->returnUrl());
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function currentUrl()
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function returnUrl()
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return "index.php?module={$this->name}&action=editworkflow$idPart&return_url=" . urlencode($this->returnUrl());
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function setReturnUrl($returnUrl)
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->label = 'Workflow';
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return "index.php?module={$this->name}&action=workflowlist";
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $idPart = "&task_id=$id";
Severity: Minor
Found in modules/com_vtiger_workflow/VTWorkflowApplication.php by phpcodesniffer

There are no issues that match your filters.

Category
Status