Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
tests/Settings/GlobalPermissions.php

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Missing class import via use statement (line '42', column '15').
Open

        $row = (new \App\Db\Query())->from('vtiger_profile2globalpermissions')->where(['profileid' => $profileID, 'globalactionid' => $globalactionid])->all();
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '26', column '15').
Open

        $row = (new \App\Db\Query())->from('vtiger_profile2globalpermissions')->where(['profileid' => $profileID, 'globalactionid' => $globalactionid])->all();
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\Settings_GlobalPermission_Record_Model' in method 'testChangeGlobalPermission'.
Open

        \Settings_GlobalPermission_Record_Model::save($profileID, $globalactionid, $checked);
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Settings_GlobalPermission_Record_Model' in method 'testChangeBackGlobalPermission'.
Open

        \Settings_GlobalPermission_Record_Model::save($profileID, $globalactionid, $checked);
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \App\Db\Query::from
Open

        $row = (new \App\Db\Query())->from('vtiger_profile2globalpermissions')->where(['profileid' => $profileID, 'globalactionid' => $globalactionid])->all();
Severity: Critical
Found in tests/Settings/GlobalPermissions.php by phan

Call to undeclared method \Tests\Settings\GlobalPermissions::assertSame
Open

        $this->assertSame($row[0]['globalactionpermission'], $checked);
Severity: Critical
Found in tests/Settings/GlobalPermissions.php by phan

Call to undeclared method \Tests\Settings\GlobalPermissions::assertSame
Open

        $this->assertSame($row[0]['globalactionpermission'], $checked);
Severity: Critical
Found in tests/Settings/GlobalPermissions.php by phan

Call to undeclared method \Tests\Settings\GlobalPermissions::assertCount
Open

        $this->assertCount(1, $row);
Severity: Critical
Found in tests/Settings/GlobalPermissions.php by phan

Call to undeclared method \Tests\Settings\GlobalPermissions::assertCount
Open

        $this->assertCount(1, $row);
Severity: Critical
Found in tests/Settings/GlobalPermissions.php by phan

Call to undeclared method \App\Db\Query::from
Open

        $row = (new \App\Db\Query())->from('vtiger_profile2globalpermissions')->where(['profileid' => $profileID, 'globalactionid' => $globalactionid])->all();
Severity: Critical
Found in tests/Settings/GlobalPermissions.php by phan

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testChangeGlobalPermission()
    {
        $profileID = 1;
        $checked = 0;
        $globalactionid = 1;
Severity: Major
Found in tests/Settings/GlobalPermissions.php and 1 other location - About 1 hr to fix
tests/Settings/GlobalPermissions.php on lines 35..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testChangeBackGlobalPermission()
    {
        $profileID = 1;
        $checked = 1;
        $globalactionid = 1;
Severity: Major
Found in tests/Settings/GlobalPermissions.php and 1 other location - About 1 hr to fix
tests/Settings/GlobalPermissions.php on lines 19..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Testing permission changes back.
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $globalactionid = 1;
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->assertCount(1, $row);
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $profileID = 1;
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $checked = 1;
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $row = (new \App\Db\Query())->from('vtiger_profile2globalpermissions')->where(['profileid' => $profileID, 'globalactionid' => $globalactionid])->all();
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Testing permission changes.
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $row = (new \App\Db\Query())->from('vtiger_profile2globalpermissions')->where(['profileid' => $profileID, 'globalactionid' => $globalactionid])->all();
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->assertCount(1, $row);
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $checked = 0;
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        \Settings_GlobalPermission_Record_Model::save($profileID, $globalactionid, $checked);
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Line exceeds 120 characters; contains 159 characters
Open

        $row = (new \App\Db\Query())->from('vtiger_profile2globalpermissions')->where(['profileid' => $profileID, 'globalactionid' => $globalactionid])->all();
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function testChangeGlobalPermission()
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $globalactionid = 1;
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        \Settings_GlobalPermission_Record_Model::save($profileID, $globalactionid, $checked);
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Line exceeds 120 characters; contains 159 characters
Open

        $row = (new \App\Db\Query())->from('vtiger_profile2globalpermissions')->where(['profileid' => $profileID, 'globalactionid' => $globalactionid])->all();
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function testChangeBackGlobalPermission()
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $profileID = 1;
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->assertSame($row[0]['globalactionpermission'], $checked);
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $this->assertSame($row[0]['globalactionpermission'], $checked);
Severity: Minor
Found in tests/Settings/GlobalPermissions.php by phpcodesniffer

There are no issues that match your filters.

Category
Status