The class ModuleManager has 12 public methods. Consider refactoring ModuleManager to keep number of public methods under 10.

Open

class ModuleManager extends \Tests\Base
{
    /**
     * Zip file name.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

File ModuleManager.php has 300 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/**
 * ModuleManager test class.
 *
 * @package   Tests

Method testCreateNewField has 74 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function testCreateNewField($type, $param, $suffix = '')
    {
        $key = $type . $suffix;
        $param['fieldType'] = $type;
        $param['fieldLabel'] = $type . 'FL' . $suffix;

Function testCreateNewField has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

    public function testCreateNewField($type, $param, $suffix = '')
    {
        $key = $type . $suffix;
        $param['fieldType'] = $type;
        $param['fieldLabel'] = $type . 'FL' . $suffix;

• Read up
  Read up

Method testDeleteNewField has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function testDeleteNewField($type, $param, $suffix = '')
    {
        $key = $type . $suffix;
        $fieldInstance = \Settings_LayoutEditor_Field_Model::getInstance(self::$fieldsId[$key]);
        $uitype = $fieldInstance->getUIType();

Function testDeleteNewField has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    public function testDeleteNewField($type, $param, $suffix = '')
    {
        $key = $type . $suffix;
        $fieldInstance = \Settings_LayoutEditor_Field_Model::getInstance(self::$fieldsId[$key]);
        $uitype = $fieldInstance->getUIType();

• Read up
  Read up

The method testCreateNewField() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.

Open

    public function testCreateNewField($type, $param, $suffix = '')
    {
        $key = $type . $suffix;
        $param['fieldType'] = $type;
        $param['fieldLabel'] = $type . 'FL' . $suffix;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The class ModuleManager has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13.

Open

class ModuleManager extends \Tests\Base
{
    /**
     * Zip file name.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Missing class import via use statement (line '325', column '29').

Open

                $this->assertFalse((new \App\Db\Query())->from('s_#__multireference')->where(['source_module' => 'TestModule', 'dest_module' => 'Contacts'])->exists(), 'The record from "s_#__multireference" was not removed.');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '352', column '24').

Open

        $packageExport = new \vtlib\PackageExport();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '98', column '21').

Open

        $rowModule = (new \App\Db\Query())->from('vtiger_tab')->where(['name' => 'TestModule'])->one();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '177', column '27').

Open

        $this->assertCount((new \App\Db\Query())->from('vtiger_profile2field')->where(['fieldid' => self::$fieldsId[$key]])->count(), $profilesId, "The field \"$type\" did not add correctly to the profiles");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '128', column '24').

Open

        $blockInstance = new \Settings_LayoutEditor_Block_Model();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '187', column '29').

Open

                $this->assertCount((new \App\Db\Query())->from('vtiger_fieldmodulerel')->where(['fieldid' => self::$fieldsId[$key]])->count(), $param['referenceModule'], 'Problem with table "vtiger_fieldmodulerel" in database');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '183', column '29').

Open

                $this->assertCount((new \App\Db\Query())->from('vtiger_profile2field')->where(['fieldid' => $rowExtra['fieldid']])->count(), $profilesId, "The \"extra\" field \"$type\" did not add correctly to the profiles");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '216', column '11').

Open

                    (new \App\Db\Query())->from('vtiger_role')->count() * \count($param['pickListValues']),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '205', column '12').

Open

                        (new \App\Db\Query())->select($param['fieldName'])->from(self::$tablesName[$key])->column()

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '319', column '11').

Open

                    (new \App\Db\Query())->from('vtiger_picklist')->where(['name' => $columnName])->exists(),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '217', column '11').

Open

                    (new \App\Db\Query())->from('vtiger_role2picklist')->where(['picklistid' => $rowPicklist['picklistid']])->count(),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '322', column '31').

Open

                $this->assertSame(0, (new \App\Db\Query())->from('vtiger_role2picklist')->where(['picklistid' => self::$pickList[$key]])->count(), 'All rows in the table "vtiger_role2picklist" have not been deleted');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '392', column '9').

Open

            (new \App\Db\Query())->from('vtiger_trees_templates')->where(['templateid' => self::$treeId])->exists(),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '71', column '18').

Open

        $package = new \vtlib\LanguageExport();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '307', column '29').

Open

                $this->assertFalse((new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsExtraId[$key]])->exists(), 'The record "extra" was not removed from the database ID: ' . self::$fieldsExtraId[$key]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '310', column '28').

Open

                $this->assertSame((new \App\Db\Query())->from('vtiger_fieldmodulerel')->where(['fieldid' => self::$fieldsId[$key]])->count(), 0, 'Problem with table "vtiger_fieldmodulerel" in database');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '302', column '27').

Open

        $this->assertFalse((new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsId[$key]])->exists(), 'The record was not removed from the database ID: ' . self::$fieldsId[$key]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '169', column '15').

Open

        $row = (new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsId[$key], 'tabid' => $moduleModel->getId()])->one();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '209', column '25').

Open

                $rowPicklist = (new \App\Db\Query())->from('vtiger_picklist')->where(['name' => $param['fieldName']])->one();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '420', column '31').

Open

                $this->assertSame(1, (new \App\Db\Query())->select(['presence'])->from('vtiger_tab')->where(['tabid' => $module->getId()])->scalar());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '133', column '15').

Open

        $row = (new \App\Db\Query())->from('vtiger_blocks')->where(['blockid' => self::$blockId])->one();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '181', column '22').

Open

                $rowExtra = (new \App\Db\Query())->from('vtiger_field')->where(['fieldname' => $param['fieldName'] . '_extra'])->one();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '192', column '69').

Open

                $this->assertCount(0, array_diff($param['pickListValues'], (new \App\Db\Query())->select($param['fieldName'])->from(self::$tablesName[$key])->column()), 'Bad values in the table "' . self::$tablesName[$key] . '"');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '222', column '28').

Open

                $this->assertTrue((new \App\Db\Query())->from('s_#__multireference')->where(['source_module' => 'TestModule', 'dest_module' => 'Contacts'])->exists(), 'No record in the table "s_yf_multireference" for type ' . $type);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '429', column '29').

Open

        $moduleManagerModel = new \Settings_ModuleManager_Module_Model();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '388', column '9').

Open

            (new \App\Db\Query())->from('vtiger_tab')->where(['name' => 'TestModule'])->exists(),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '415', column '29').

Open

        $moduleManagerModel = new \Settings_ModuleManager_Module_Model();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '434', column '31').

Open

                $this->assertSame(0, (new \App\Db\Query())->select(['presence'])->from('vtiger_tab')->where(['tabid' => $module->getId()])->scalar());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class '\Settings_LayoutEditor_Field_Model' in method 'testDeleteNewField'.

Open

        $fieldInstance = \Settings_LayoutEditor_Field_Model::getInstance(self::$fieldsId[$key]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Language' in method 'getLangPathToFile'.

Open

        $allLang = \App\Language::getAll();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\vtlib\Profile' in method 'testCreateNewField'.

Open

        $profilesId = \vtlib\Profile::getAllIds();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Module_Model' in method 'testCreateNewBlock'.

Open

        $moduleModel = \Vtiger_Module_Model::getInstance('TestModule');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Block_Model' in method 'testDeleteNewBlock'.

Open

        $blockInstance = \Vtiger_Block_Model::getInstance(self::$blockId);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Settings_ModuleManager_Module_Model' in method 'testCreateModule'.

Open

        $module = \Settings_ModuleManager_Module_Model::createModule([
            'module_name' => 'TestModule',
            'entityfieldname' => 'testmodule',
            'module_label' => 'TestModule',
            'entitytype' => \Vtiger_Module_Model::ADVANCED_TYPE,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Module' in method 'testCreateModule'.

Open

        $this->assertSame('TestModule', \App\Module::getModuleName($module->getId()), 'The name of the new module is missing: ' . $module->getId());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\vtlib\Module' in method 'testExportModule'.

Open

        $moduleModel = \vtlib\Module::getInstance('TestModule');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\vtlib\Module' in method 'getMRVField'.

Open

        $moduleInstance = \vtlib\Module::getInstance('Contacts');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\vtlib\Module' in method 'getMRVField'.

Open

        $source_Module = \vtlib\Module::getInstance('TestModule');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Block_Model' in method 'testDeleteNewBlock'.

Open

        $this->assertFalse(\Vtiger_Block_Model::checkFieldsExists(self::$blockId), 'Fields exists');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Settings_ModuleManager_Module_Model' in method 'testOffAllModule'.

Open

        $allModules = \Settings_ModuleManager_Module_Model::getAll();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Settings_ModuleManager_Module_Model' in method 'testOnAllModule'.

Open

        $allModules = \Settings_ModuleManager_Module_Model::getAll();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Settings_ModuleManager_Library_Model' in method 'testDownloadLibraryModule'.

Open

        $libraries = \Settings_ModuleManager_Library_Model::getAll();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Settings_ModuleManager_Library_Model' in method 'testDownloadLibraryModule'.

Open

            $this->assertTrue(\Settings_ModuleManager_Library_Model::download($key), "The library \"{$key}\" could not be downloaded");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Config' in method 'testDownloadLibraryModule'.

Open

            $mode = \App\Config::developer('MISSING_LIBRARY_DEV_MODE') ? 'developer' : \App\Version::get($library['name']);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\vtlib\Module' in method 'testDeleteModule'.

Open

        $moduleInstance = \vtlib\Module::getInstance('TestModule');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Zip' in method 'testExportModule'.

Open

        $zip = \App\Zip::openFile(self::$zipFileName, ['checkFiles' => false]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Version' in method 'testDownloadLibraryModule'.

Open

            $mode = \App\Config::developer('MISSING_LIBRARY_DEV_MODE') ? 'developer' : \App\Version::get($library['name']);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Define a constant instead of duplicating this literal "fieldName" 9 times.

Open

        $param['fieldName'] = strtolower($type . 'FL' . $suffix);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "Table "" 4 times.

Open

                $this->assertNotNull(\App\Db::getInstance()->getTableSchema(self::$tablesName[$key]), 'Table "' . self::$tablesName[$key] . '" does not exist');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "fieldTypeList" 21 times.

Open

            ['Text', ['fieldTypeList' => 0, 'fieldLength' => 12]],

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "/PL.zip" 4 times.

Open

        $package->exportLanguage('pl-PL', ROOT_DIRECTORY . '/PL.zip', 'PL.zip');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "presence" 4 times.

Open

            if (1 !== (int) $module->get('presence')) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "vtiger_tab" 4 times.

Open

        $rowModule = (new \App\Db\Query())->from('vtiger_tab')->where(['name' => 'TestModule'])->one();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "TestModule" 17 times.

Open

            'module_name' => 'TestModule',

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "pickListValues" 7 times.

Open

                $this->assertCount(0, array_diff($param['pickListValues'], (new \App\Db\Query())->select($param['fieldName'])->from(self::$tablesName[$key])->column()), 'Bad values in the table "' . self::$tablesName[$key] . '"');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "tabid" 3 times.

Open

        $row = (new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsId[$key], 'tabid' => $moduleModel->getId()])->one();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "picklistid" 3 times.

Open

                    (new \App\Db\Query())->from('vtiger_role2picklist')->where(['picklistid' => $rowPicklist['picklistid']])->count(),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "fieldid" 9 times.

Open

        $row = (new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsId[$key], 'tabid' => $moduleModel->getId()])->one();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "vtiger_field" 4 times.

Open

        $row = (new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsId[$key], 'tabid' => $moduleModel->getId()])->one();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "TestModule.json" 3 times.

Open

        $langFileToCheck = $this->getLangPathToFile('TestModule.json');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "uitype" 4 times.

Open

        $this->assertSame($row['uitype'], $details['uitype']);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "Contacts" 5 times.

Open

                $this->assertTrue((new \App\Db\Query())->from('s_#__multireference')->where(['source_module' => 'TestModule', 'dest_module' => 'Contacts'])->exists(), 'No record in the table "s_yf_multireference" for type ' . $type);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "fieldLength" 5 times.

Open

            ['Text', ['fieldTypeList' => 0, 'fieldLength' => 12]],

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Avoid unused parameters such as '$param'.

Open

    public function testDeleteNewField($type, $param, $suffix = '')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused local variables such as '$lang'.

Open

        foreach ($allLang as $key => $lang) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Call to undeclared method \App\Db\Query::from

Open

        $this->assertCount((new \App\Db\Query())->from('vtiger_profile2field')->where(['fieldid' => self::$fieldsId[$key]])->count(), $profilesId, "The field \"$type\" did not add correctly to the profiles");

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

        $this->assertSame($row['blocklabel'], 'label block');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        $row = (new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsId[$key], 'tabid' => $moduleModel->getId()])->one();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $rowExtra = (new \App\Db\Query())->from('vtiger_field')->where(['fieldname' => $param['fieldName'] . '_extra'])->one();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        $row = (new \App\Db\Query())->from('vtiger_blocks')->where(['blockid' => self::$blockId])->one();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

        $this->assertSame($row['iscustom'], 1);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertCount

Open

                $this->assertCount((new \App\Db\Query())->from('vtiger_profile2field')->where(['fieldid' => $rowExtra['fieldid']])->count(), $profilesId, "The \"extra\" field \"$type\" did not add correctly to the profiles");

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

        $this->assertSame(2, $rowModule['premium']);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertTrue

Open

        $this->assertTrue(file_exists(ROOT_DIRECTORY . '/PL.zip') && filesize(ROOT_DIRECTORY . '/PL.zip') > 0);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFileExists

Open

        $this->assertFileExists(ROOT_DIRECTORY . '/modules/TestModule/TestModule.php');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        $rowModule = (new \App\Db\Query())->from('vtiger_tab')->where(['name' => 'TestModule'])->one();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertNotFalse

Open

        $this->assertNotFalse($rowModule);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

        $this->assertSame($row['fieldname'], $param['fieldName']);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertNotFalse

Open

                $this->assertNotFalse($rowExtra, 'No "extra" record for uitype: ' . $row['uitype']);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFileExists

Open

            $this->assertFileExists($pathToFile);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

        $this->assertSame($row['typeofdata'], $details['typeofdata']);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

        $this->assertSame($row['uitype'], $details['uitype']);

• Exclude checks
  • Disable engine
  • Disable check

@throws type of getLangPathToFile has undeclared type \Tests\Settings\Exception (Did you mean class \Exception)

Open

    private function getLangPathToFile($fileName)

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $this->assertCount((new \App\Db\Query())->from('vtiger_profile2field')->where(['fieldid' => $rowExtra['fieldid']])->count(), $profilesId, "The \"extra\" field \"$type\" did not add correctly to the profiles");

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertNotFalse

Open

        $this->assertNotFalse($row, 'No record id: ' . self::$fieldsId[$key]);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

        $this->assertSame(\Vtiger_Module_Model::ADVANCED_TYPE, $rowModule['type']);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertCount

Open

        $this->assertCount((new \App\Db\Query())->from('vtiger_profile2field')->where(['fieldid' => self::$fieldsId[$key]])->count(), $profilesId, "The field \"$type\" did not add correctly to the profiles");

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $this->assertCount((new \App\Db\Query())->from('vtiger_fieldmodulerel')->where(['fieldid' => self::$fieldsId[$key]])->count(), $param['referenceModule'], 'Problem with table "vtiger_fieldmodulerel" in database');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertIsInt

Open

        $this->assertIsInt($module->getId());

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

        $this->assertSame('TestModule', $rowModule['tablabel']);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

        $this->assertSame('TestModule', \App\Module::getModuleName($module->getId()), 'The name of the new module is missing: ' . $module->getId());

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertNotFalse

Open

        $this->assertNotFalse($row, 'No record id: ' . self::$blockId);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

        $this->assertSame($row['fieldlabel'], $param['fieldLabel']);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFalse

Open

                $this->assertFalse((new \App\Db\Query())->from('s_#__multireference')->where(['source_module' => 'TestModule', 'dest_module' => 'Contacts'])->exists(), 'The record from "s_#__multireference" was not removed.');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertCount

Open

                $this->assertCount(0, array_diff($param['pickListValues'], (new \App\Db\Query())->select($param['fieldName'])->from(self::$tablesName[$key])->column()), 'Bad values in the table "' . self::$tablesName[$key] . '"');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $this->assertTrue((new \App\Db\Query())->from('s_#__multireference')->where(['source_module' => 'TestModule', 'dest_module' => 'Contacts'])->exists(), 'No record in the table "s_yf_multireference" for type ' . $type);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFileDoesNotExist

Open

            $this->assertFileDoesNotExist(ROOT_DIRECTORY . \DIRECTORY_SEPARATOR . $pathToFile);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertDoesNotMatchRegularExpression

Open

            $this->assertDoesNotMatchRegularExpression('/404/', $header['Status'] ?? '', $library['url'] . "/archive/$mode.zip | " . print_r($header, true));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $this->assertSame((new \App\Db\Query())->from('vtiger_fieldmodulerel')->where(['fieldid' => self::$fieldsId[$key]])->count(), 0, 'Problem with table "vtiger_fieldmodulerel" in database');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $this->assertSame(0, (new \App\Db\Query())->from('vtiger_role2picklist')->where(['picklistid' => self::$pickList[$key]])->count(), 'All rows in the table "vtiger_role2picklist" have not been deleted');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertCount

Open

                $this->assertCount((new \App\Db\Query())->from('vtiger_fieldmodulerel')->where(['fieldid' => self::$fieldsId[$key]])->count(), $param['referenceModule'], 'Problem with table "vtiger_fieldmodulerel" in database');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        $this->assertFalse((new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsId[$key]])->exists(), 'The record was not removed from the database ID: ' . self::$fieldsId[$key]);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFalse

Open

                $this->assertFalse(

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFalse

Open

        $this->assertFalse(\Vtiger_Block_Model::checkFieldsExists(self::$blockId), 'Fields exists');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFileDoesNotExist

Open

        $this->assertFileDoesNotExist(ROOT_DIRECTORY . '/modules/TestModule/TestModule.php');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::getTableSchema

Open

                    \App\Db::getInstance()->getTableSchema(self::$tablesName[$key]),

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertTrue

Open

        $this->assertTrue($fieldInstance->isCustomField(), 'Field is not customized');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::getSchema

Open

        $schema = \App\Db::getInstance()->getSchema();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertContains

Open

        $this->assertContains('modules' . \DIRECTORY_SEPARATOR . 'TestModule' . \DIRECTORY_SEPARATOR . 'TestModule.php', $zipFiles);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

            (new \App\Db\Query())->from('vtiger_trees_templates')->where(['templateid' => self::$treeId])->exists(),

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFileExists

Open

        $this->assertFileExists(self::$zipFileName);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertContains

Open

            $this->assertContains($pathToFile, $zipFiles);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertNotNull

Open

                $this->assertNotNull(\App\Db::getInstance()->getTableSchema(self::$tablesName[$key]), 'Table "' . self::$tablesName[$key] . '" does not exist');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::getTableSchema

Open

                $this->assertNotNull(\App\Db::getInstance()->getTableSchema(self::$tablesName[$key]), 'Table "' . self::$tablesName[$key] . '" does not exist');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $this->assertFalse((new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsExtraId[$key]])->exists(), 'The record "extra" was not removed from the database ID: ' . self::$fieldsExtraId[$key]);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

                $this->assertCount(0, array_diff($param['pickListValues'], (new \App\Db\Query())->select($param['fieldName'])->from(self::$tablesName[$key])->column()), 'Bad values in the table "' . self::$tablesName[$key] . '"');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                    (new \App\Db\Query())->from('vtiger_role2picklist')->where(['picklistid' => $rowPicklist['picklistid']])->count(),

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFileExists

Open

            $this->assertFileExists($library['dir'] . 'version.php');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertNotNull

Open

                $this->assertNotNull(

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $rowPicklist = (new \App\Db\Query())->from('vtiger_picklist')->where(['name' => $param['fieldName']])->one();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                    (new \App\Db\Query())->from('vtiger_role')->count() * \count($param['pickListValues']),

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertNull

Open

                $this->assertNull($schema->getTableSchema(self::$tablesName[$key]), 'Table "' . self::$tablesName[$key] . '" exist');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertNull

Open

                $this->assertNull($schema->getTableSchema(self::$tablesName[$key]), 'Table "' . self::$tablesName[$key] . '" exist');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                    (new \App\Db\Query())->from('vtiger_picklist')->where(['name' => $columnName])->exists(),

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $this->assertFalse((new \App\Db\Query())->from('s_#__multireference')->where(['source_module' => 'TestModule', 'dest_module' => 'Contacts'])->exists(), 'The record from "s_#__multireference" was not removed.');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

            (new \App\Db\Query())->from('vtiger_tab')->where(['name' => 'TestModule'])->exists(),

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFalse

Open

        $this->assertFalse(

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertNotFalse

Open

                $this->assertNotFalse(

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

                $this->assertSame(

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertTrue

Open

                $this->assertTrue((new \App\Db\Query())->from('s_#__multireference')->where(['source_module' => 'TestModule', 'dest_module' => 'Contacts'])->exists(), 'No record in the table "s_yf_multireference" for type ' . $type);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFalse

Open

        $this->assertFalse((new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsId[$key]])->exists(), 'The record was not removed from the database ID: ' . self::$fieldsId[$key]);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

                $this->assertSame(0, (new \App\Db\Query())->from('vtiger_role2picklist')->where(['picklistid' => self::$pickList[$key]])->count(), 'All rows in the table "vtiger_role2picklist" have not been deleted');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertContains

Open

        $this->assertContains('manifest.xml', $zipFiles);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

                $this->assertSame(0, (new \App\Db\Query())->select(['presence'])->from('vtiger_tab')->where(['tabid' => $module->getId()])->scalar());

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

                        (new \App\Db\Query())->select($param['fieldName'])->from(self::$tablesName[$key])->column()

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertTrue

Open

        $this->assertTrue($blockInstance->isCustomized(), 'Block is not customized');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFalse

Open

        $this->assertFalse($moduleModel->isExportable(), 'Module exportable!');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertTrue

Open

        $this->assertTrue($moduleModel->isExportable(), 'Module not exportable!');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

                $this->assertSame(1, (new \App\Db\Query())->select(['presence'])->from('vtiger_tab')->where(['tabid' => $module->getId()])->scalar());

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

                $this->assertSame(0, (new \App\Db\Query())->select(['presence'])->from('vtiger_tab')->where(['tabid' => $module->getId()])->scalar());

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFalse

Open

                $this->assertFalse((new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsExtraId[$key]])->exists(), 'The record "extra" was not removed from the database ID: ' . self::$fieldsExtraId[$key]);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertCount

Open

                $this->assertCount(

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

                $this->assertSame((new \App\Db\Query())->from('vtiger_fieldmodulerel')->where(['fieldid' => self::$fieldsId[$key]])->count(), 0, 'Problem with table "vtiger_fieldmodulerel" in database');

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (fileName) is string but \App\Zip::openFile() takes bool|false defined at /code/app/Zip.php:51

Open

        $zip = \App\Zip::openFile(self::$zipFileName, ['checkFiles' => false]);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::getSchema

Open

        \App\Db::getInstance()->getSchema()->refresh();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertFalse

Open

        $this->assertFalse(

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertTrue

Open

            $this->assertTrue(\Settings_ModuleManager_Library_Model::download($key), "The library \"{$key}\" could not be downloaded");

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \Tests\Settings\ModuleManager::assertSame

Open

                $this->assertSame(1, (new \App\Db\Query())->select(['presence'])->from('vtiger_tab')->where(['tabid' => $module->getId()])->scalar());

• Exclude checks
  • Disable engine
  • Disable check

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function testOnAllModule()
    {
        $allModules = \Settings_ModuleManager_Module_Model::getAll();
        $moduleManagerModel = new \Settings_ModuleManager_Module_Model();
        foreach ($allModules as $module) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function testOffAllModule()
    {
        $allModules = \Settings_ModuleManager_Module_Model::getAll();
        $moduleManagerModel = new \Settings_ModuleManager_Module_Model();
        foreach ($allModules as $module) {

• Read up
  Read up

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Array of fields id.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    private static $treeId;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        unlink(ROOT_DIRECTORY . '/PL.zip');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Zip file name.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Block id.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    private static $blockId;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var array()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    private static $pickList;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->assertTrue(file_exists(ROOT_DIRECTORY . '/PL.zip') && filesize(ROOT_DIRECTORY . '/PL.zip') > 0);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Tables name for uitype: 16, 15.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'entityfieldname' => 'testmodule',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    private static $zipFileName;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var array()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    private static $fieldsExtraId;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Testing the module creation.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function testCreateModule()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var string

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var array()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    private static $tablesName;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'module_name' => 'TestModule',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Id for picklist.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Id for field extra.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $module = \Settings_ModuleManager_Module_Model::createModule([

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    private static $fieldsId;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Id for tree.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Testing language exports.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $package->exportLanguage('pl-PL', ROOT_DIRECTORY . '/PL.zip', 'PL.zip');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $package = new \vtlib\LanguageExport();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->assertNotFalse($rowModule);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->assertSame(2, $rowModule['premium']);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @throws Exception

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($allLang as $key => $lang) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return $langFileToCheck;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $param['MRVField'] = $this->getMRVField();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $this->assertCount((new \App\Db\Query())->from('vtiger_fieldmodulerel')->where(['fieldid' => self::$fieldsId[$key]])->count(), $param['referenceModule'], 'Problem with table "vtiger_fieldmodulerel" in database');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $this->assertNotFalse(

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var array()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function testLanguageExport()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $blockInstance = new \Settings_LayoutEditor_Block_Model();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 138 characters

Open

        $moduleModel = \Settings_LayoutEditor_Module_Model::getInstance('Settings:LayoutEditor')->setSourceModule($param['sourceModule']);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->assertCount((new \App\Db\Query())->from('vtiger_profile2field')->where(['fieldid' => self::$fieldsId[$key]])->count(), $profilesId, "The field \"$type\" did not add correctly to the profiles");

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $this->assertNotFalse($rowExtra, 'No "extra" record for uitype: ' . $row['uitype']);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'entityfieldlabel' => 'TestModule',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->assertFileExists(ROOT_DIRECTORY . '/modules/TestModule/TestModule.php');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($langFileToCheck as $pathToFile) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleModel = \Vtiger_Module_Model::getInstance('TestModule');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $blockInstance->set('label', 'label block');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed  $suffix

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $key = $type . $suffix;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->assertSame($row['typeofdata'], $details['typeofdata']);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        (new \App\Db\Query())->select($param['fieldName'])->from(self::$tablesName[$key])->column()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('Tree' === $type || 'CategoryMultipicklist' === $type) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                );

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    (new \App\Db\Query())->from('vtiger_role')->count() * \count($param['pickListValues']),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            case 305: //MultiReferenceValue

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            default:

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                break;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        self::$blockId = $blockInstance->save($moduleModel);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $param['blockid'] = self::$blockId;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    \App\Db::getInstance()->getTableSchema(self::$tablesName[$key]),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                );

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $allLang = \App\Language::getAll();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $langFileToCheck[] = 'languages' . \DIRECTORY_SEPARATOR . $key . \DIRECTORY_SEPARATOR . $fileName;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Testing the creation of a new field for the module.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function testCreateNewField($type, $param, $suffix = '')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $param['sourceModule'] = 'TestModule';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $param['tree'] = self::$treeId;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } elseif ('MultiReferenceValue' === $type) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $details = $moduleModel->getTypeDetailsForAddField($type, $param);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $row = (new \App\Db\Query())->from('vtiger_field')->where(['fieldid' => self::$fieldsId[$key], 'tabid' => $moduleModel->getId()])->one();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        switch ($row['uitype']) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                break;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            case 15: //Picklist

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $rowPicklist,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->assertIsInt($module->getId());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    private function getLangPathToFile($fileName)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'module_label' => 'TestModule',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $rowModule = (new \App\Db\Query())->from('vtiger_tab')->where(['name' => 'TestModule'])->one();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Testing the creation of a new block for the module.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        self::$fieldsId[$key] = $fieldModel->getId();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            //Add a tree if it does not exist

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            case 10: //Related1M

• Exclude checks
  • Disable engine
  • Disable check