File PackageUpdate.php has 400 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/* +**********************************************************************************
 * The contents of this file are subject to the vtiger CRM Public License Version 1.0
 * ("License"); You may not use this file except in compliance with the License
 * The Original Code is:  vtiger CRM Open Source

Function update has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.

Open

    public function update($moduleInstance, $zipfile, $overwrite = true)
    {
        $module = $this->getModuleNameFromZip($zipfile);
        if (null !== $module) {
            $zip = \App\Zip::openFile($zipfile, ['checkFiles' => false]);

• Read up
  Read up

The class PackageUpdate has an overall complexity of 114 which is very high. The configured complexity threshold is 50.

Open

class PackageUpdate extends PackageImport
{
    public $_migrationinfo = false;
    public $listFields = [];
    public $listBlocks = [];

• Exclude checks
  • Disable engine
  • Disable check

The class PackageUpdate has 21 public methods. Consider refactoring PackageUpdate to keep number of public methods under 10.

Open

class PackageUpdate extends PackageImport
{
    public $_migrationinfo = false;
    public $listFields = [];
    public $listBlocks = [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Method updateField has 61 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function updateField($blocknode, $blockInstance, $moduleInstance, $fieldnode, $fieldInstance)
    {
        // strval used because in $fieldnode there is a SimpleXMLElement object
        $fieldInstance->name = (string) ($fieldnode->fieldname);
        $fieldInstance->label = (string) ($fieldnode->fieldlabel);

Function handleMigration has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.

Open

    public function handleMigration($modulenode, $moduleInstance)
    {
        $this->parseMigration($modulenode);
        $cur_version = $moduleInstance->version;
        foreach ($this->_migrations as $migversion => $migrationnode) {

• Read up
  Read up

Function updateField has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.

Open

    public function updateField($blocknode, $blockInstance, $moduleInstance, $fieldnode, $fieldInstance)
    {
        // strval used because in $fieldnode there is a SimpleXMLElement object
        $fieldInstance->name = (string) ($fieldnode->fieldname);
        $fieldInstance->label = (string) ($fieldnode->fieldlabel);

• Read up
  Read up

PackageUpdate has 21 functions (exceeds 20 allowed). Consider refactoring.

Open

class PackageUpdate extends PackageImport
{
    public $_migrationinfo = false;
    public $listFields = [];
    public $listBlocks = [];

Function updateBlocks has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

    public function updateBlocks($modulenode, $moduleInstance)
    {
        if (empty($modulenode->blocks) || empty($modulenode->blocks->block)) {
            return;
        }

• Read up
  Read up

Function updateCronTasks has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.

Open

    public function updateCronTasks($modulenode)
    {
        if (empty($modulenode->crons) || empty($modulenode->crons->cron)) {
            return;
        }

• Read up
  Read up

Method update has 36 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function update($moduleInstance, $zipfile, $overwrite = true)
    {
        $module = $this->getModuleNameFromZip($zipfile);
        if (null !== $module) {
            $zip = \App\Zip::openFile($zipfile, ['checkFiles' => false]);

Method updateBlocks has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function updateBlocks($modulenode, $moduleInstance)
    {
        if (empty($modulenode->blocks) || empty($modulenode->blocks->block)) {
            return;
        }

Function parseMigration has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

    public function parseMigration($modulenode)
    {
        if (empty($this->_migrations)) {
            $this->_migrations = [];
            if (!empty($modulenode->migrations)

• Read up
  Read up

Function updateRelatedlist has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    public function updateRelatedlist($modulenode, $moduleInstance, $relatedlistnode)
    {
        $relModuleInstance = Module::getInstance((string) $relatedlistnode->relatedmodule);
        $label = $relatedlistnode->label;
        $actions = false;

• Read up
  Read up

Function updateInRelatedlist has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    public function updateInRelatedlist($modulenode, $moduleInstance, $inRelatedListNode)
    {
        $inRelModuleInstance = Module::getInstance((string) $inRelatedListNode->inrelatedmodule);
        $label = $inRelatedListNode->label;
        $actions = false;

• Read up
  Read up

Method updateField has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function updateField($blocknode, $blockInstance, $moduleInstance, $fieldnode, $fieldInstance)

Function updateRelatedLists has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    public function updateRelatedLists($modulenode, $moduleInstance)
    {
        $moduleInstance->unsetAllRelatedList();
        if (!empty($modulenode->relatedlists) && !empty($modulenode->relatedlists->relatedlist)) {
            foreach ($modulenode->relatedlists->relatedlist as $relatedlistnode) {

• Read up
  Read up

Function initUpdate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    public function initUpdate($moduleInstance, $zipfile, $overwrite)
    {
        $module = $this->getModuleNameFromZip($zipfile);
        if (!$moduleInstance || $moduleInstance->name != $module) {
            \App\Log::trace('Module name mismatch!', __METHOD__);

• Read up
  Read up

Function updateFields has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    public function updateFields($blocknode, $blockInstance, $moduleInstance)
    {
        if (empty($blocknode->fields) || empty($blocknode->fields->field)) {
            return;
        }

• Read up
  Read up

Function updateCustomViews has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    public function updateCustomViews($modulenode, $moduleInstance)
    {
        if (empty($modulenode->customviews) || empty($modulenode->customviews->customview)) {
            return;
        }

• Read up
  Read up

The method updateField() has an NPath complexity of 2048. The configured NPath complexity threshold is 200.

Open

    public function updateField($blocknode, $blockInstance, $moduleInstance, $fieldnode, $fieldInstance)
    {
        // strval used because in $fieldnode there is a SimpleXMLElement object
        $fieldInstance->name = (string) ($fieldnode->fieldname);
        $fieldInstance->label = (string) ($fieldnode->fieldlabel);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method updateField() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.

Open

    public function updateField($blocknode, $blockInstance, $moduleInstance, $fieldnode, $fieldInstance)
    {
        // strval used because in $fieldnode there is a SimpleXMLElement object
        $fieldInstance->name = (string) ($fieldnode->fieldname);
        $fieldInstance->label = (string) ($fieldnode->fieldlabel);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The method update() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.

Open

    public function update($moduleInstance, $zipfile, $overwrite = true)
    {
        $module = $this->getModuleNameFromZip($zipfile);
        if (null !== $module) {
            $zip = \App\Zip::openFile($zipfile, ['checkFiles' => false]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The method updateBlocks() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.

Open

    public function updateBlocks($modulenode, $moduleInstance)
    {
        if (empty($modulenode->blocks) || empty($modulenode->blocks->block)) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Class "PackageUpdate" has 21 methods, which is greater than 20 authorized. Split it into smaller classes.

Open

class PackageUpdate extends PackageImport

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Refactor this function to reduce its Cognitive Complexity from 29 to the 15 allowed.

Open

    public function update($moduleInstance, $zipfile, $overwrite = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.

Open

    public function handleMigration($modulenode, $moduleInstance)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed.

Open

    public function updateField($blocknode, $blockInstance, $moduleInstance, $fieldnode, $fieldInstance)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class PackageUpdate has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.

Open

class PackageUpdate extends PackageImport
{
    public $_migrationinfo = false;
    public $listFields = [];
    public $listBlocks = [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The method update has a boolean flag argument $overwrite, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function update($moduleInstance, $zipfile, $overwrite = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid using static access to class 'vtlib\Module' in method 'updateModule'.

Open

        Module::fireEvent($moduleInstance->name, Module::EVENT_MODULE_PREUPDATE);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Viewer' in method 'initUpdate'.

Open

                $zip->unzipFile("$module.png", 'layouts/' . \Vtiger_Viewer::getDefaultLayoutName() . "/skins/images/$module.png");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                if (!$moduleInstance || $moduleInstance->name != $module) {
                    \App\Log::error('Module name mismatch!', __METHOD__);

                    return false;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Log' in method 'handleMigration'.

Open

                \App\Log::trace("Migrating to $migversion ... DONE", __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Module' in method 'updateModule'.

Open

        Module::fireEvent($moduleInstance->name, Module::EVENT_MODULE_POSTUPDATE);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Zip' in method 'initUpdate'.

Open

            $zip = \App\Zip::openFile($zipfile, ['checkFiles' => false]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Zip' in method 'update'.

Open

            $zip = \App\Zip::openFile($zipfile, ['checkFiles' => false]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Log' in method 'update'.

Open

                    \App\Log::error('Module name mismatch!', __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method updateField uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $fieldInstance->columntype = null;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method handleMigration uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                        } else {
                            // Supress any SQL query failures
                            \App\Log::trace("SQL: $tablesql ... ", __METHOD__);
                            \App\Db::getInstance()->createCommand($tablesql)->execute();
                            \App\Log::trace('DONE', __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'vtlib\Block' in method 'updateBlocks'.

Open

        $listBlockBeforeUpdate = Block::getAllForModule($moduleInstance);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Module' in method 'updateRelatedlist'.

Open

        $relModuleInstance = Module::getInstance((string) $relatedlistnode->relatedmodule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Log' in method 'initUpdate'.

Open

            \App\Log::trace('Module name mismatch!', __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Log' in method 'handleMigration'.

Open

                            \App\Log::trace("SQL: $tablesql ... ", __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Utils' in method 'handleMigration'.

Open

                        if (Utils::isDestructiveSql($tablesql)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Field' in method 'updateBlocks'.

Open

            $listFieldBeforeUpdate = Field::getAllForModule($moduleInstance);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method updateCronTasks uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $cronTask->status = Cron::$STATUS_ENABLED;
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method updateBlock uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $blockInstance->display_status = null;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Log' in method 'handleMigration'.

Open

                            \App\Log::trace("SQL: $tablesql ... SKIPPED", __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Cron' in method 'updateCronTasks'.

Open

            Cron::register("$importCronTask->name", "$importCronTask->handler", "$importCronTask->frequency", "$modulenode->name", "$importCronTask->status", "$importCronTask->sequence", "$importCronTask->description");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Module' in method 'update'.

Open

                            $moduleInstance = Module::getInstance($moduleInfo['name']);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method updateBlocks uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $this->updateBlock($modulenode, $moduleInstance, $blocknode, $blockInstance);
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Log' in method 'handleMigration'.

Open

                            \App\Log::trace('DONE', __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Block' in method 'updateBlocks'.

Open

            $blockInstance = Block::getInstance((string) $blocknode->blocklabel, $moduleInstance->id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method updateCustomViews uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $this->updateCustomView($modulenode, $moduleInstance, $customviewnode, $filterInstance);
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'vtlib\Filter' in method 'updateCustomViews'.

Open

            $filterInstance = Filter::getInstance($customviewnode->viewname, $moduleInstance->id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method updateField uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $moduleInstance->entityfieldname = $fieldInstance->name;
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\EventHandler' in method 'updateEvents'.

Open

            \App\EventHandler::registerHandler($eventNode->eventName, $eventNode->className, $eventNode->includeModules, $eventNode->excludeModules, $eventNode->priority, $eventNode->isActive, $moduleId);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Cron' in method 'updateCronTasks'.

Open

        $cronTasks = Cron::listAllInstancesByModule($modulenode->name);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Cron' in method 'updateCronTasks'.

Open

                $importCronTask->sequence = Cron::nextSequence();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Link' in method 'updateCustomLinks'.

Open

        Link::deleteAll($moduleInstance->id);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Cron' in method 'updateCronTasks'.

Open

                    Cron::deregister($importCronTask->name);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Log' in method 'handleMigration'.

Open

                \App\Log::trace("Migrating to $migversion ... STARTED", __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Module' in method 'updateInRelatedlist'.

Open

        $inRelModuleInstance = Module::getInstance((string) $inRelatedListNode->inrelatedmodule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method updateFields uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $this->updateField($blocknode, $blockInstance, $moduleInstance, $fieldnode, $fieldInstance);
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Module' in method 'updateEvents'.

Open

        $moduleId = \App\Module::getModuleId($moduleInstance->name);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'vtlib\Field' in method 'updateFields'.

Open

            $fieldInstance = Field::getInstance((string) $fieldnode->fieldname, $moduleInstance);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid unused parameters such as '$overwrite'.

Open

    public function initUpdate($moduleInstance, $zipfile, $overwrite)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$moduleInstance'.

Open

    public function updateSharingAccess($modulenode, $moduleInstance)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$modulenode'.

Open

    public function updateInRelatedlist($modulenode, $moduleInstance, $inRelatedListNode)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$actionnode'.

Open

    public function updateAction($modulenode, $moduleInstance, $actionnode)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$moduleInstance'.

Open

    public function updateAction($modulenode, $moduleInstance, $actionnode)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$moduleInstance'.

Open

    public function updateBlock($modulenode, $moduleInstance, $blocknode, $blockInstance)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$modulenode'.

Open

    public function updateBlock($modulenode, $moduleInstance, $blocknode, $blockInstance)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$modulenode'.

Open

    public function updateAction($modulenode, $moduleInstance, $actionnode)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$blocknode'.

Open

    public function updateField($blocknode, $blockInstance, $moduleInstance, $fieldnode, $fieldInstance)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$modulenode'.

Open

    public function updateRelatedlist($modulenode, $moduleInstance, $relatedlistnode)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Saw possibly unextractable annotation for a fragment of comment '* @param Module Instance of the module to update': after Module, did not see an element name (will guess based on comment order)

Open

     * @param Module Instance of the module to update

• Exclude checks
  • Disable engine
  • Disable check

Class \vtlib\Field was passed to foreach, but it does not extend Traversable. This may be intentional, because some of that class's declared properties are accessible from this context. (This check excludes dynamic properties)

Open

            foreach ($listFieldBeforeUpdate as $fieldInstance) {

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \vtlib\PackageUpdate::getHandlerClass

Open

                if ($cronTask->getName() == $importCronTask->name && $importCronTask->handler == $cronTask->getHandlerClass()) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \vtlib\PackageUpdate->_migrations

Open

        foreach ($this->_migrations as $migversion => $migrationnode) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method trace from undeclared class \App\Log

Open

                            \App\Log::trace('DONE', __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (frequency) is string but \vtlib\Cron::register() takes int defined at /code/vtlib/Vtiger/Cron.php:398

Open

            Cron::register("$importCronTask->name", "$importCronTask->handler", "$importCronTask->frequency", "$modulenode->name", "$importCronTask->status", "$importCronTask->sequence", "$importCronTask->description");

• Exclude checks
  • Disable engine
  • Disable check

Class \vtlib\Block was passed to foreach, but it does not extend Traversable. This may be intentional, because some of that class's declared properties are accessible from this context. (This check excludes dynamic properties)

Open

        foreach ($listBlockBeforeUpdate as $blockInstance) {

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

                            \App\Db::getInstance()->createCommand($tablesql)->execute();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

        \App\Db::getInstance()->createCommand()->delete('vtiger_eventhandlers', ['owner_id' => $moduleId])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Call to method trace from undeclared class \App\Log

Open

            \App\Log::trace('Module name mismatch!', __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Call to method trace from undeclared class \App\Log

Open

                            \App\Log::trace("SQL: $tablesql ... ", __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \vtlib\PackageUpdate->status

Open

                $cronTask->status = Cron::$STATUS_DISABLED;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \vtlib\PackageUpdate->_migrations

Open

                    $this->_migrations["$migrationversion"] = $migrationnode;

• Exclude checks
  • Disable engine
  • Disable check

Call to method trace from undeclared class \App\Log

Open

                            \App\Log::trace("SQL: $tablesql ... SKIPPED", __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \vtlib\PackageUpdate->_migrations

Open

            if (\count($this->_migrations) > 1) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \vtlib\PackageUpdate->_migrations

Open

            $this->_migrations = [];

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \vtlib\PackageUpdate::getName

Open

                if ($cronTask->getName() == $importCronTask->name && $importCronTask->handler == $cronTask->getHandlerClass()) {

• Exclude checks
  • Disable engine
  • Disable check

Argument 5 (status) is string but \vtlib\Cron::register() takes int defined at /code/vtlib/Vtiger/Cron.php:398

Open

            Cron::register("$importCronTask->name", "$importCronTask->handler", "$importCronTask->frequency", "$modulenode->name", "$importCronTask->status", "$importCronTask->sequence", "$importCronTask->description");

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param string Zip file name': after string, did not see an element name (will guess based on comment order)

Open

     * @param string Zip file name

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param bool True for overwriting existing module': after bool, did not see an element name (will guess based on comment order)

Open

     * @param bool True for overwriting existing module

• Exclude checks
  • Disable engine
  • Disable check

Call to method trace from undeclared class \App\Log

Open

                \App\Log::trace("Migrating to $migversion ... STARTED", __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Call with 4 arg(s) to \vtlib\Module::unsetRelatedList() which only takes 3 arg(s) defined at /code/vtlib/Vtiger/Module.php:136

Open

            $inRelModuleInstance->unsetRelatedList($moduleInstance, "$label", "$inRelatedListNode->function", $inRelatedListNode->field_name);

• Exclude checks
  • Disable engine
  • Disable check

Call to method error from undeclared class \App\Log

Open

                    \App\Log::error('Module name mismatch!', __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \vtlib\PackageUpdate->_migrations

Open

        if (empty($this->_migrations)) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method trace from undeclared class \App\Log

Open

                \App\Log::trace("Migrating to $migversion ... DONE", __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Argument 6 (sequence) is string but \vtlib\Cron::register() takes int defined at /code/vtlib/Vtiger/Cron.php:398

Open

            Cron::register("$importCronTask->name", "$importCronTask->handler", "$importCronTask->frequency", "$modulenode->name", "$importCronTask->status", "$importCronTask->sequence", "$importCronTask->description");

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \vtlib\PackageUpdate->_migrations

Open

                uksort($this->_migrations, 'version_compare');

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \vtlib\PackageUpdate->status

Open

                $cronTask->status = Cron::$STATUS_ENABLED;

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long variable names like $listBlockBeforeUpdate. Keep variable name length under 20.

Open

        $listBlockBeforeUpdate = Block::getAllForModule($moduleInstance);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $listFieldBeforeUpdate. Keep variable name length under 20.

Open

            $listFieldBeforeUpdate = Field::getAllForModule($moduleInstance);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

The property $_migrationinfo is not named in camelCase.

Open

class PackageUpdate extends PackageImport
{
    public $_migrationinfo = false;
    public $listFields = [];
    public $listBlocks = [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

Property name "$_migrationinfo" should not be prefixed with an underscore to indicate visibility

Open

    public $_migrationinfo = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Initialize Update.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (empty($this->_modulexml)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $zipfile

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'updates' => 'cache/updates',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $listBlocks = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $overwrite

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (null !== $module) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    foreach ($moduleInfos as $moduleInfo) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        if ($moduleInfo['install_sequence'] == $sequence) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Update Module.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Parse migration information from manifest.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function parseMigration($modulenode)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                && !empty($modulenode->migrations->migration)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $this->listBlocks[] = (string) ($blocknode->blocklabel);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $this->updateFields($blocknode, $blockInstance, $moduleInstance);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (isset($blocknode->sequence, $blocknode->display_status)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (empty($blocknode->fields) || empty($blocknode->fields->field)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $this->updateField($blocknode, $blockInstance, $moduleInstance, $fieldnode, $fieldInstance);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $blockInstance

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->typeofdata = (string) ($fieldnode->typeofdata);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $picklistvalues = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $moduleInstance

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function update($moduleInstance, $zipfile, $overwrite = true)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $zip = \App\Zip::openFile($zipfile, ['checkFiles' => false]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->updateActions($this->_modulexml, $moduleInstance);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($listBlockBeforeUpdate as $blockInstance) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $modulenode

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $blockInstance->visible = (string) ($blocknode->visible);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Update Fields of the module.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $blockInstance

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->defaultvalue = (string) ($fieldnode->defaultvalue);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->quickcreate = (string) ($fieldnode->quickcreate);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($fieldnode->fieldparams)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $moduleInstance->entityidfield = (string) ($fieldnode->entityidentifier->entityidfield);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $listFields = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $zip = \App\Zip::openFile($zipfile, ['checkFiles' => false]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ($zip->statName("$module.png")) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Update Module from zip file.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            // If data is not yet available

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $this->__parseManifestFile($zip);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 125 characters

Open

                            $this->update($moduleInstance, $this->getTemporaryFilePath($moduleInfo['filepath']), $overwrite);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $cur_version = $moduleInstance->version;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $this->updateBlock($modulenode, $moduleInstance, $blocknode, $blockInstance);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $blockInstance->increateview = (string) ($blocknode->create_view);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $fieldInstance->fieldparams = (string) ($fieldnode->fieldparams);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($fieldnode->relatedmodules) && !empty($fieldnode->relatedmodules->relatedmodule)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            \App\Log::trace('Module name mismatch!', __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $zip->unzipFile("$module.png", 'layouts/' . \Vtiger_Viewer::getDefaultLayoutName() . "/skins/images/$module.png");

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 130 characters

Open

                $zip->unzipFile("$module.png", 'layouts/' . \Vtiger_Viewer::getDefaultLayoutName() . "/skins/images/$module.png");

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->updateEvents($this->_modulexml, $moduleInstance);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $this->_migrations = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Handle migration of the module.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($this->_migrations as $migversion => $migrationnode) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            \App\Log::trace("SQL: $tablesql ... ", __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $blockInstance = $this->importBlock($modulenode, $moduleInstance, $blocknode);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($this->listFields) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function updateBlock($modulenode, $moduleInstance, $blocknode, $blockInstance)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $blockInstance->islist = (string) ($blocknode->islist);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->maximumlength = (string) ($fieldnode->maximumlength);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($fieldnode->helpinfo)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $moduleInstance->entityfieldname = (string) ($fieldnode->entityidentifier->fieldname);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        // Check related modules associated with this field

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $module = $this->getModuleNameFromZip($zipfile);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $this->__parseManifestFile($zip);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                foreach ($installSequenceArray as $sequence) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $migrationattrs = $migrationnode->attributes();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            // Sort the migration details based on version

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            \App\Log::trace("SQL: $tablesql ... SKIPPED", __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Update Tables of the module.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if (!(\in_array($fieldInstance->name, $this->listFields))) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $moduleInstance

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->uitype = (string) ($fieldnode->uitype);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->info_type = (string) ($fieldnode->info_type);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (isset($fieldnode->columntype)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($fieldnode->summaryfield)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (isset($fieldnode->entityidentifier->fieldname) && !empty($fieldnode->entityidentifier->fieldname)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            foreach ($fieldnode->picklistvalues->picklistvalue as $picklistvaluenode) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $module = $this->getModuleNameFromZip($zipfile);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->handleMigration($this->_modulexml, $moduleInstance);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->updateRelatedLists($this->_modulexml, $moduleInstance);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->updateCronTasks($this->_modulexml);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $modulenode

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            // Supress any SQL query failures

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->importTables($modulenode);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        // Deleting removed blocks

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (!(\in_array($blockInstance->label, $this->listBlocks))) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->name = (string) ($fieldnode->fieldname);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->generatedtype = (string) ($fieldnode->generatedtype);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!empty($fieldnode->entityidentifier)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (null !== $module) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $zip->unzip([

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            $moduleInstance = Module::getInstance($moduleInfo['name']);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $tablabel = $this->_modulexml->label;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        Module::fireEvent($moduleInstance->name, Module::EVENT_MODULE_PREUPDATE);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (!empty($modulenode->migrations)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (\count($this->_migrations) > 1) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $blocknode

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $fieldInstance->columntype = (string) ($fieldnode->columntype);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (true === $moduleBundle) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        $moduleInfo = (array) $moduleInfo;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            $this->update($moduleInstance, $this->getTemporaryFilePath($moduleInfo['filepath']), $overwrite);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                foreach ($modulenode->migrations->migration as $migrationnode) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (version_compare($cur_version, $migversion, '<')) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if (!empty($migrationnode->tables) && !empty($migrationnode->tables->table)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                            \App\Log::trace('DONE', __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $moduleInstance

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $blockInstance->display_status = null;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return $blockInstance;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->table = (string) ($fieldnode->tablename);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->column = (string) ($fieldnode->columnname);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param mixed $zipfile

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fieldInstance->displaytype = (string) ($fieldnode->displaytype);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    foreach ($buildModuleArray as $moduleInfo) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $this->initUpdate($moduleInstance, $zipfile, $overwrite);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $this->updateModule($moduleInstance);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $moduleInstance->setEntityIdentifier($fieldInstance);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $tabversion = $this->_modulexml->version;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                \App\Log::trace("Migrating to $migversion ... DONE", __METHOD__);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**