lib/Style/Normalizer/BackgroundImage.php
Avoid unused parameters such as '$ruleName'. Open
Open
public function normalize($ruleValue, string $ruleName = ''): array
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Define a constant instead of duplicating this literal "transparent" 3 times. Open
Open
if (null === $this->normalized && 'transparent' !== $ruleValue) {
- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() { prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times execute('action1'); release('action1'); }
Compliant Solution
ACTION_1 = 'action1'; function run() { prepare(ACTION_1); execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->normalized = ['background-image' => $ruleValue];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->normalized = ['background-image' => 'transparent'];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (null === $this->normalized && 'transparent' !== $ruleValue) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->normalized;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ('transparent' === $ruleValue) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function normalize($ruleValue, string $ruleName = ''): array
- Exclude checks