lib/Style/Normalizer/BorderStyle.php
The method normalize uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$style = 'none';
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$ruleName'. Open
Open
public function normalize($ruleValue, string $ruleName = ''): array- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'border-top-style' => $style,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'border-bottom-style' => $style,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$style = $ruleValue;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$style = 'none';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'border-right-style' => $style,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'border-left-style' => $style,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (null === $this->normalized) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (\in_array($ruleValue, ['none', 'solid', 'dashed', 'dotted'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->normalized = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->normalized;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function normalize($ruleValue, string $ruleName = ''): array- Exclude checks