Sign upLogin

YouTransfer/YouTransfer

View on GitHub
Star
lib/routes.js

Summary

Maintainability
C
1 day
Test Coverage

File routes.js has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

// ------------------------------------------------------------------------------------------ Dependencies

require('date-utils');
Severity: Minor
Found in lib/routes.js - About 2 hrs to fix

    Function upload has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Router.prototype.upload = function() {
    return function(req, res, next) {

        req.errors.register(new Error('An error occurred while uploading your file(s).'));
        var payload = req.files.payload || req.files['dz-payload'];
    Severity: Minor
    Found in lib/routes.js - About 1 hr to fix

      Function download has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Router.prototype.download = function() {
    return function(req, res, next) {

        req.errors.register([
            {
      Severity: Minor
      Found in lib/routes.js - About 1 hr to fix

        Function settingsGetTemplateByName has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Router.prototype.settingsGetTemplateByName = function() {
    return function(req, res, next) {

        req.errors.register([
            new Error('An error occurred while trying to retrieve the template'),
        Severity: Minor
        Found in lib/routes.js - About 1 hr to fix

          Function upload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          Router.prototype.upload = function() {
    return function(req, res, next) {

        req.errors.register(new Error('An error occurred while uploading your file(s).'));
        var payload = req.files.payload || req.files['dz-payload'];
          Severity: Minor
          Found in lib/routes.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function download has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          Router.prototype.download = function() {
    return function(req, res, next) {

        req.errors.register([
            {
          Severity: Minor
          Found in lib/routes.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  youtransfer.settings.unlock(req.params.unlockCode, function(err) {
            req.errors.parse(err);
            if(req.errors.exist()) {
                res.process('unlock.html', null, next);
            } else {
          Severity: Major
          Found in lib/routes.js and 1 other location - About 1 hr to fix
          lib/routes.js on lines 138..146

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  youtransfer.settings.finalise(req.params.settings.state.unlockCode, function(err) {
            req.errors.parse(err);
            if(req.errors.exist()) {
                res.process('settings.finalise.html', null, next);
            } else {
          Severity: Major
          Found in lib/routes.js and 1 other location - About 1 hr to fix
          lib/routes.js on lines 160..168

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  req.errors.register([
            new Error('An error occurred while trying to save the template'),
            {
                code: 'ENOENT',
                message: 'An invalid template has been selected. Please try again.',
          Severity: Minor
          Found in lib/routes.js and 1 other location - About 45 mins to fix
          lib/routes.js on lines 176..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  req.errors.register([
            new Error('An error occurred while trying to retrieve the template'),
            {
                code: 'ENOENT',
                message: 'An invalid template has been selected. Please try again.',
          Severity: Minor
          Found in lib/routes.js and 1 other location - About 45 mins to fix
          lib/routes.js on lines 209..220

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status