Sign upLogin

YouTransfer/YouTransfer

View on GitHub
Star
lib/s3storage.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function archive has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

S3Storage.prototype.archive = function(token, res, next) {
    try {
        if(token) {
            var s3obj = this.s3obj;
            s3obj.getObject({
Severity: Minor
Found in lib/s3storage.js - About 1 hr to fix

    Function purge has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    S3Storage.prototype.purge = function(next) {
    try {
        var s3obj = this.s3obj;
        var filesToDelete = [];
        s3obj.listObjects(function(err, data) {
    Severity: Minor
    Found in lib/s3storage.js - About 1 hr to fix

      Function download has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      S3Storage.prototype.download = function(token, res, next) {
    try {
        if(token) {
            var s3obj = this.s3obj;
            s3obj.getObject({
      Severity: Minor
      Found in lib/s3storage.js - About 1 hr to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                            if(context.expires) {
                        var expires = new Date(context.expires);
                        if(Date.compare(expires, new Date()) < 0) {
                            throw new Error('The requested file is no longer available.');
                        }
        Severity: Major
        Found in lib/s3storage.js and 3 other locations - About 1 hr to fix
        lib/localstorage.js on lines 110..115
        lib/localstorage.js on lines 187..192
        lib/s3storage.js on lines 107..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                            if(bundle.expires) {
                        var expires = new Date(bundle.expires);
                        if(Date.compare(expires, new Date()) < 0) {
                            throw new Error('The requested bundle is no longer available.');
                        }
        Severity: Major
        Found in lib/s3storage.js and 3 other locations - About 1 hr to fix
        lib/localstorage.js on lines 110..115
        lib/localstorage.js on lines 187..192
        lib/s3storage.js on lines 157..162

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                                var completed = _.after(bundle.files.length, function() {
                            archive.pipe(res);
                            archive.finalize();
                        });
        Severity: Minor
        Found in lib/s3storage.js and 1 other location - About 45 mins to fix
        lib/localstorage.js on lines 124..127

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status