Sign upLogin

YouTransfer/YouTransfer

View on GitHub
Star
lib/youtransfer.js

Summary

Maintainability
F
4 days
Test Coverage

Function exports has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = (function() {

    var self = {};
    self.settings = require('./settings');
    self.log = require('./logger')('youtransfer');
Severity: Minor
Found in lib/youtransfer.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 257 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (function() {

    var self = {};
    self.settings = require('./settings');
    self.log = require('./logger')('youtransfer');
Severity: Major
Found in lib/youtransfer.js - About 1 day to fix

    File youtransfer.js has 275 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

// ------------------------------------------------------------------------------------------ Dependencies

require('date-utils');
    Severity: Minor
    Found in lib/youtransfer.js - About 2 hrs to fix

      Function send has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          self.send = function(req, res, next) {
        self.settings.get(function(err, settings) {
            if(!err) {
                var fields = _.clone(req.params);
                fields.baseUrl = settings.general.baseUrl;
      Severity: Minor
      Found in lib/youtransfer.js - About 1 hr to fix

        Function get has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                get: function(next) {
            self.settings.get(function(err, settings) {
                var transporter = nodemailer.createTransport();
                if(settings.email.transporter === 'smtp') {
                    if(smtpWellkown(settings.email.service)) {
        Severity: Minor
        Found in lib/youtransfer.js - About 1 hr to fix

          Function initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              self.initialize = function() {
        self.settings.get(function(err, settings) {
            if(!err) {
                if(settings.general.schedulerEnabled) {
                    self.log.info('Scheduled cleanup of expired files');
          Severity: Minor
          Found in lib/youtransfer.js - About 1 hr to fix

            Function upload has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                self.upload = function(file, bundle, next) {
        self.settings.get(function(err, settings) {
            var basedir = settings.storage.localstoragepath;
            var retention = {};
            retention[settings.storage.retentionUnit] = parseInt(settings.storage.retention);
            Severity: Minor
            Found in lib/youtransfer.js - About 1 hr to fix

              Avoid deeply nested control flow statements.
              Open

                                                      if(settings.email.sendCopy) {
                                            email.cc = settings.email.sender;
                                        }
              Severity: Major
              Found in lib/youtransfer.js - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    self.archive = function(token, res, next) {
        self.storageFactory.get(function(err, factory) {
            factory.archive(token, res, next);
        });    
    };
                Severity: Minor
                Found in lib/youtransfer.js and 1 other location - About 55 mins to fix
                lib/youtransfer.js on lines 194..198

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    self.download = function(token, res, next) {
        self.storageFactory.get(function(err, factory) {
            factory.download(token, res, next);
        });
    };
                Severity: Minor
                Found in lib/youtransfer.js and 1 other location - About 55 mins to fix
                lib/youtransfer.js on lines 200..204

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status