Sign upLogin

YuntechNet/AtomicP2P

View on GitHub
Star
atomic_p2p/mixin/handleable.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function select_handler has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def select_handler(self, pkt_type: str) -> Union[None, "Handler"]:
        """select a handler with given packet handler type.
        If current class's pkt_handlers is not match, will iterate each va-
        riable which inherits HandleableMixin class. Also it will prevent 
        circular interact in case a instance that passing parent instance.
Severity: Minor
Found in atomic_p2p/mixin/handleable.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status