ZestFinance/knife-instance

View on GitHub
lib/knife-instance/zestknife.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class ZestKnife has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

class ZestKnife < Chef::Knife
  attr_accessor :base_domain
  attr_accessor :internal_domain

  def msg_pair(label, value, color=:cyan)
Severity: Minor
Found in lib/knife-instance/zestknife.rb - About 3 hrs to fix

    Method zone has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def zone
        unless @zone
          self.class.in_all_aws_regions do |zest_aws|
            @zone ||= zest_aws.dns.zones.detect { |z| z.domain.downcase == domain }
          end
    Severity: Minor
    Found in lib/knife-instance/zestknife.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status