Zizzamia/perfume.js

View on GitHub
__tests__/vitalsScore.spec.ts

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should return the correct values for tbt', () => {
      expect(getVitalsScore('tbt', 100)).toEqual('good');
      expect(getVitalsScore('tbt', 200)).toEqual('good');
      expect(getVitalsScore('tbt', 201)).toEqual('needsImprovement');
      expect(getVitalsScore('tbt', 700)).toEqual('poor');
Severity: Major
Found in __tests__/vitalsScore.spec.ts and 1 other location - About 2 hrs to fix
__tests__/vitalsScore.spec.ts on lines 80..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should return the correct values for ntbt', () => {
      expect(getVitalsScore('ntbt', 100)).toEqual('good');
      expect(getVitalsScore('ntbt', 200)).toEqual('good');
      expect(getVitalsScore('ntbt', 201)).toEqual('needsImprovement');
      expect(getVitalsScore('ntbt', 700)).toEqual('poor');
Severity: Major
Found in __tests__/vitalsScore.spec.ts and 1 other location - About 2 hrs to fix
__tests__/vitalsScore.spec.ts on lines 73..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should return the correct values for cls', () => {
      expect(getVitalsScore('cls', 0.05)).toEqual('good');
      expect(getVitalsScore('cls', 0.2)).toEqual('needsImprovement');
      expect(getVitalsScore('cls', 0.3)).toEqual('poor');
    });
Severity: Major
Found in __tests__/vitalsScore.spec.ts and 7 other locations - About 1 hr to fix
__tests__/vitalsScore.spec.ts on lines 25..29
__tests__/vitalsScore.spec.ts on lines 31..35
__tests__/vitalsScore.spec.ts on lines 37..41
__tests__/vitalsScore.spec.ts on lines 43..47
__tests__/vitalsScore.spec.ts on lines 49..53
__tests__/vitalsScore.spec.ts on lines 55..59
__tests__/vitalsScore.spec.ts on lines 67..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should return the correct values for fid', () => {
      expect(getVitalsScore('fid', 80)).toEqual('good');
      expect(getVitalsScore('fid', 150)).toEqual('needsImprovement');
      expect(getVitalsScore('fid', 400)).toEqual('poor');
    });
Severity: Major
Found in __tests__/vitalsScore.spec.ts and 7 other locations - About 1 hr to fix
__tests__/vitalsScore.spec.ts on lines 25..29
__tests__/vitalsScore.spec.ts on lines 31..35
__tests__/vitalsScore.spec.ts on lines 37..41
__tests__/vitalsScore.spec.ts on lines 43..47
__tests__/vitalsScore.spec.ts on lines 49..53
__tests__/vitalsScore.spec.ts on lines 61..65
__tests__/vitalsScore.spec.ts on lines 67..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should return the correct values for rt', () => {
      expect(getVitalsScore('rt', 80)).toEqual('good');
      expect(getVitalsScore('rt', 120)).toEqual('needsImprovement');
      expect(getVitalsScore('rt', 220)).toEqual('poor');
    });
Severity: Major
Found in __tests__/vitalsScore.spec.ts and 7 other locations - About 1 hr to fix
__tests__/vitalsScore.spec.ts on lines 25..29
__tests__/vitalsScore.spec.ts on lines 37..41
__tests__/vitalsScore.spec.ts on lines 43..47
__tests__/vitalsScore.spec.ts on lines 49..53
__tests__/vitalsScore.spec.ts on lines 55..59
__tests__/vitalsScore.spec.ts on lines 61..65
__tests__/vitalsScore.spec.ts on lines 67..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should return the correct values for lcpFinal', () => {
      expect(getVitalsScore('lcpFinal', 200)).toEqual('good');
      expect(getVitalsScore('lcpFinal', 3200)).toEqual('needsImprovement');
      expect(getVitalsScore('lcpFinal', 5200)).toEqual('poor');
    });
Severity: Major
Found in __tests__/vitalsScore.spec.ts and 7 other locations - About 1 hr to fix
__tests__/vitalsScore.spec.ts on lines 25..29
__tests__/vitalsScore.spec.ts on lines 31..35
__tests__/vitalsScore.spec.ts on lines 37..41
__tests__/vitalsScore.spec.ts on lines 43..47
__tests__/vitalsScore.spec.ts on lines 55..59
__tests__/vitalsScore.spec.ts on lines 61..65
__tests__/vitalsScore.spec.ts on lines 67..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should return the correct values for lcp', () => {
      expect(getVitalsScore('lcp', 200)).toEqual('good');
      expect(getVitalsScore('lcp', 3200)).toEqual('needsImprovement');
      expect(getVitalsScore('lcp', 5200)).toEqual('poor');
    });
Severity: Major
Found in __tests__/vitalsScore.spec.ts and 7 other locations - About 1 hr to fix
__tests__/vitalsScore.spec.ts on lines 25..29
__tests__/vitalsScore.spec.ts on lines 31..35
__tests__/vitalsScore.spec.ts on lines 37..41
__tests__/vitalsScore.spec.ts on lines 49..53
__tests__/vitalsScore.spec.ts on lines 55..59
__tests__/vitalsScore.spec.ts on lines 61..65
__tests__/vitalsScore.spec.ts on lines 67..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should return the correct values for ttfb', () => {
      expect(getVitalsScore('ttfb', 100)).toEqual('good');
      expect(getVitalsScore('ttfb', 300)).toEqual('needsImprovement');
      expect(getVitalsScore('ttfb', 600)).toEqual('poor');
    });
Severity: Major
Found in __tests__/vitalsScore.spec.ts and 7 other locations - About 1 hr to fix
__tests__/vitalsScore.spec.ts on lines 31..35
__tests__/vitalsScore.spec.ts on lines 37..41
__tests__/vitalsScore.spec.ts on lines 43..47
__tests__/vitalsScore.spec.ts on lines 49..53
__tests__/vitalsScore.spec.ts on lines 55..59
__tests__/vitalsScore.spec.ts on lines 61..65
__tests__/vitalsScore.spec.ts on lines 67..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should return the correct values for fcp', () => {
      expect(getVitalsScore('fcp', 200)).toEqual('good');
      expect(getVitalsScore('fcp', 2200)).toEqual('needsImprovement');
      expect(getVitalsScore('fcp', 4200)).toEqual('poor');
    });
Severity: Major
Found in __tests__/vitalsScore.spec.ts and 7 other locations - About 1 hr to fix
__tests__/vitalsScore.spec.ts on lines 25..29
__tests__/vitalsScore.spec.ts on lines 31..35
__tests__/vitalsScore.spec.ts on lines 43..47
__tests__/vitalsScore.spec.ts on lines 49..53
__tests__/vitalsScore.spec.ts on lines 55..59
__tests__/vitalsScore.spec.ts on lines 61..65
__tests__/vitalsScore.spec.ts on lines 67..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should return the correct values for clsFinal', () => {
      expect(getVitalsScore('clsFinal', 0.05)).toEqual('good');
      expect(getVitalsScore('clsFinal', 0.2)).toEqual('needsImprovement');
      expect(getVitalsScore('clsFinal', 0.3)).toEqual('poor');
    });
Severity: Major
Found in __tests__/vitalsScore.spec.ts and 7 other locations - About 1 hr to fix
__tests__/vitalsScore.spec.ts on lines 25..29
__tests__/vitalsScore.spec.ts on lines 31..35
__tests__/vitalsScore.spec.ts on lines 37..41
__tests__/vitalsScore.spec.ts on lines 43..47
__tests__/vitalsScore.spec.ts on lines 49..53
__tests__/vitalsScore.spec.ts on lines 55..59
__tests__/vitalsScore.spec.ts on lines 61..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status