Sign upLogin

Zooip/gorg_service

View on GitHub
Star

Showing 11 of 11 total issues

Method validate has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def validate
      self.validation_errors= Hash.new([].freeze)

      self.validation_errors[:content_type]+=["is not supported by Gadz.org SOA"] unless ['application/json'].include? self.content_type
      self.validation_errors[:content_encoding]+=["is not supported by Gadz.org SOA"] unless ['deflate','gzip'].include? self.content_encoding
Severity: Minor
Found in lib/gorg_service/message.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Message has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Message

    DEFAULT_SOA_VERSION="1.0"

    class DataValidationError < StandardError
Severity: Minor
Found in lib/gorg_service/message.rb - About 2 hrs to fix

    File formatters.rb has 268 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class GorgService::Message
    class Formatter

      def initialize(message)
        @message=message
    Severity: Minor
    Found in lib/gorg_service/message/formatters.rb - About 2 hrs to fix

      Method parse has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def self.parse(delivery_info, properties, body)
        begin

          type=properties[:type]
          unless type
      Severity: Minor
      Found in lib/gorg_service/message/formatters.rb - About 1 hr to fix

        Method parse has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def self.parse(delivery_info, properties, body)
        begin
          json_body=JSON.parse(body)
          JSON::Validator.validate!(JSON_SCHEMA_V1, json_body)
        Severity: Minor
        Found in lib/gorg_service/message/formatters.rb - About 1 hr to fix

          Method convert_keys_to_sym has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.convert_keys_to_sym input_hash
        s2s =
            lambda do |h|
              Hash === h ?
                  Hash[
          Severity: Minor
          Found in lib/gorg_service/message/formatters.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method convert_keys_to_sym has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def convert_keys_to_sym input_hash
          s2s = 
          lambda do |h| 
            Hash === h ? 
              Hash[
          Severity: Minor
          Found in lib/gorg_service/message/error_log.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def validate
      self.validation_errors[:level]+=["is null"] unless self.level
      self.validation_errors[:level]+=["is not in [0,1,2,3,4]"] unless (0..4).to_a.include?(self.level)
      self.validation_errors[:error_type]+=["is not in (softfail hardfail)"] unless self.error_type && (%w(softfail hardfail).include? self.error_type)
      super
          Severity: Minor
          Found in lib/gorg_service/log_message.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.parse(delivery_info, properties, body)
        begin

          type=properties[:type]
          unless type
          Severity: Minor
          Found in lib/gorg_service/message/formatters.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  s2s =
            lambda do |h|
              Hash === h ?
                  Hash[
                      h.map do |k, v|
          Severity: Minor
          Found in lib/gorg_service/message/formatters.rb and 1 other location - About 15 mins to fix
          lib/gorg_service/message/error_log.rb on lines 60..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                    s2s = 
          lambda do |h| 
            Hash === h ? 
              Hash[
                h.map do |k, v|
          Severity: Minor
          Found in lib/gorg_service/message/error_log.rb and 1 other location - About 15 mins to fix
          lib/gorg_service/message/formatters.rb on lines 28..36

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language