abbadon1334/sun-position-spa-php

View on GitHub
src/SunPosition.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method calcSunRiseTransitSet has 120 lines of code (exceeds 100 allowed). Consider refactoring.
Open

    public function calcSunRiseTransitSet()
    {
        $observer = clone $this->Observer;
        $observer->ObserverTime->Hour = 0;
        $observer->ObserverTime->Minute = 0;
Severity: Major
Found in src/SunPosition.php - About 1 hr to fix

    Method calculate has 105 lines of code (exceeds 100 allowed). Consider refactoring.
    Open

        public function calculate()
        {
            $this->PrimeHourAngle = -1 * (self::SUN_RADIUS + $this->PrimeHourAtmosfericRefraction);
            /**
             * 3.2. Calculate the Earth heliocentric longitude, latitude, and radius vector (L, B, and R):
    Severity: Major
    Found in src/SunPosition.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function _calculateΔPsiI($X)
          {
              $ΔPsiI = array_fill(0, count(self::COEFF_PSI_EPSILON), 0);
      
              foreach (self::COEFF_PSI_EPSILON as $idx => $values) {
      Severity: Major
      Found in src/SunPosition.php and 1 other location - About 1 hr to fix
      src/SunPosition.php on lines 900..911

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function _calculateΔEpsilonI($X)
          {
              $ΔEpsI = array_fill(0, count(self::COEFF_PSI_EPSILON), 0);
      
              foreach (self::COEFF_PSI_EPSILON as $idx => $values) {
      Severity: Major
      Found in src/SunPosition.php and 1 other location - About 1 hr to fix
      src/SunPosition.php on lines 887..898

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status