Sign upLogin

abeelen/nikamap

View on GitHub
Star
nikamap/utils.py

Summary

Maintainability
C
7 hrs
Test Coverage

File utils.py has 392 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

from __future__ import absolute_import, division, print_function

import os
import numpy as np
import warnings
Severity: Minor
Found in nikamap/utils.py - About 5 hrs to fix

    Cyclomatic complexity is too high in function meta_to_header. (7)
    Open

    def meta_to_header(meta):
    """Transform a meta object into a fits Header

    Parameters
    ----------
    Severity: Minor
    Found in nikamap/utils.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in function fake_data. (6)
    Open

    def fake_data(
    shape=(512, 512),
    beam_fwhm=12.5 * u.arcsec,
    pixsize=2 * u.arcsec,
    nefd=50e-3 * Jy_beam * u.s**0.5,
    Severity: Minor
    Found in nikamap/utils.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in function xy_to_world. (6)
    Open

    def xy_to_world(sources, wcs, x_key, y_key):
    # Transform pixel coordinates column to world coordinates
    lonlat = wcs.pixel_to_world_values(sources[x_key], sources[y_key])
    for key, item, unit in zip(wcs.world_axis_physical_types, lonlat, wcs.world_axis_units):
        sources[key] = item * u.Unit(unit)
    Severity: Minor
    Found in nikamap/utils.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function fake_data has 12 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def fake_data(
    Severity: Major
    Found in nikamap/utils.py - About 1 hr to fix

      Function pos_gridded has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def pos_gridded(
      Severity: Major
      Found in nikamap/utils.py - About 50 mins to fix

        Function pos_list has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def pos_list(shape=None, within=(0, 1), mask=None, nsources=1, peak_flux=1 * u.mJy, x_mean=None, y_mean=None):
        Severity: Major
        Found in nikamap/utils.py - About 50 mins to fix

          Function pos_uniform has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def pos_uniform(shape=None, within=(0, 1), mask=None, nsources=1, peak_flux=1 * u.mJy, dist_threshold=0, max_loop=10):
          Severity: Major
          Found in nikamap/utils.py - About 50 mins to fix

            Function evaluate has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def evaluate(self, x, y, flux, x_0, y_0, sigma):
            Severity: Minor
            Found in nikamap/utils.py - About 45 mins to fix

              Function fake_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              def fake_data(
    shape=(512, 512),
    beam_fwhm=12.5 * u.arcsec,
    pixsize=2 * u.arcsec,
    nefd=50e-3 * Jy_beam * u.s**0.5,
              Severity: Minor
              Found in nikamap/utils.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function xy_to_world has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              def xy_to_world(sources, wcs, x_key, y_key):
    # Transform pixel coordinates column to world coordinates
    lonlat = wcs.pixel_to_world_values(sources[x_key], sources[y_key])
    for key, item, unit in zip(wcs.world_axis_physical_types, lonlat, wcs.world_axis_units):
        sources[key] = item * u.Unit(unit)
              Severity: Minor
              Found in nikamap/utils.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __init__(self, sigma=sigma.default, x_0=x_0.default, y_0=y_0.default, flux=flux.default, **kwargs):
              Severity: Minor
              Found in nikamap/utils.py - About 35 mins to fix

                Function meta_to_header has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def meta_to_header(meta):
    """Transform a meta object into a fits Header

    Parameters
    ----------
                Severity: Minor
                Found in nikamap/utils.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function pos_too_close has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def pos_too_close(pos, dist_threshold=0):
    """Remove sources which are too close

    Parameters
    ----------
                Severity: Minor
                Found in nikamap/utils.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status