Sign upLogin

abhi1693/yii2-installer

View on GitHub
Star

Showing 9 of 9 total issues

Method getResults has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public static function getResults()
        {
            /**
             * ['title']
             * ['state']    = OK, WARNING, ERROR
Severity: Major
Found in helpers/SystemCheck.php - About 4 hrs to fix

    Function actionMailer has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function actionMailer()
    {
        $config = Configuration::get();
        $param = Configuration::getParam();
    Severity: Minor
    Found in controllers/SetupController.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function actionDatabase has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        public function actionDatabase()
    {
        $success = FALSE;
        $errorMsg = '';
    Severity: Minor
    Found in controllers/SetupController.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getResults has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

            public static function getResults()
        {
            /**
             * ['title']
             * ['state']    = OK, WARNING, ERROR
    Severity: Minor
    Found in helpers/SystemCheck.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method actionDatabase has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionDatabase()
    {
        $success = FALSE;
        $errorMsg = '';
    Severity: Minor
    Found in controllers/SetupController.php - About 2 hrs to fix

      Method actionMailer has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function actionMailer()
    {
        $config = Configuration::get();
        $param = Configuration::getParam();
      Severity: Minor
      Found in controllers/SetupController.php - About 1 hr to fix

        Method setupInitialData has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function setupInitialData()
    {
        // Get Params File
        $param = Configuration::getParam();
        Severity: Minor
        Found in controllers/ConfigController.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static function setParam($config = [])
    {
        $paramFile = Yii::$app->params[Enum::PARAMS_FILE];

        $content = "<" . "?php return ";
          Severity: Major
          Found in helpers/Configuration.php and 1 other location - About 1 hr to fix
          helpers/Configuration.php on lines 63..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static function set($config = [])
    {
        $configFile = Yii::$app->params[Enum::CONFIG_FILE];

        $content = "<" . "?php return ";
          Severity: Major
          Found in helpers/Configuration.php and 1 other location - About 1 hr to fix
          helpers/Configuration.php on lines 98..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language