Sign upLogin

abienvenu/Kyela

View on GitHub
Star

Showing 21 of 21 total issues

Poll has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class Poll extends Entity
{
    /**
     * @var integer
     *
Severity: Minor
Found in Entity/Poll.php - About 2 hrs to fix

    Method loadVolley has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function loadVolley(ObjectManager $manager)
    {
        $names = ['Jean', 'Marilou', 'Mehdi', 'Élodie', 'Cécile', 'Vincent', 'Patricia', 'Cyril', 'Lucie'];
        $events = [
            ['name' => 'Entraînement', 'date' => new \DateTime('+10 year'), 'time' => new \DateTime('20:30')],
    Severity: Major
    Found in DataFixtures/ORM/LoadExamplePolls.php - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function orderAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $repository = $em->getRepository("KyelaBundle:Choice");
        $order = $request->request->get('choice');
      Severity: Major
      Found in Controller/ChoiceController.php and 1 other location - About 2 hrs to fix
      Controller/ParticipantController.php on lines 81..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 125.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function orderAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $repository = $em->getRepository("KyelaBundle:Participant");
        $order = $request->request->get('participant');
      Severity: Major
      Found in Controller/ParticipantController.php and 1 other location - About 2 hrs to fix
      Controller/ChoiceController.php on lines 97..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 125.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method resetPoll has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function resetPoll(ObjectManager $manager, $url, $title, $headLines, $bottomLines, $names, $events, $choices, $participations)
    {
        $entity = $manager->getRepository('KyelaBundle:Poll')->findOneByUrl($url);
        if ($entity) {
            $manager->remove($entity);
      Severity: Major
      Found in DataFixtures/ORM/LoadExamplePolls.php - About 2 hrs to fix

        Method loadConcert has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function loadConcert(ObjectManager $manager)
    {
        $names = ['Aretha', 'Jimmy', 'Miles', 'John', 'Paul'];
        $events = [
            ['name' => 'Répétition', 'place' => 'Studio', 'date' => new \DateTime('+10 year'), 'time' => new \DateTime('15:00')],
        Severity: Minor
        Found in DataFixtures/ORM/LoadExamplePolls.php - About 1 hr to fix

          Method loadHolidays has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function loadHolidays(ObjectManager $manager)
    {
        $names = ['Jean', 'Lisa', 'Étienne', 'Martine', 'Lilou'];
        $events = [
            ['name' => 'Vacances de février'],
          Severity: Minor
          Found in DataFixtures/ORM/LoadExamplePolls.php - About 1 hr to fix

            Function doNewAction has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function doNewAction($formType, Entity $entity, Request $request, $successMessage = null, $extra = [])
    {
        $form = $this->doCreateCreateForm($formType, $entity, $request->get('_route'), $extra);
        if ($request->isMethod('POST'))
        {
            Severity: Minor
            Found in Controller/CRUDController.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method unlockAction has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function unlockAction(Request $request)
    {
        $poll = (new Poll)->setTitle("dummy")->setUrl("dummy");
        $form = $this->createForm(LockPollType::class, $poll, [
            'method' => 'PUT',
            Severity: Minor
            Found in Controller/PollController.php - About 1 hr to fix

              Method lockAction has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function lockAction(Request $request)
    {
        $form = $this->createForm(LockPollType::class, $this->poll, [
            'method' => 'PUT',
        ]);
              Severity: Minor
              Found in Controller/PollController.php - About 1 hr to fix

                Method doNewAction has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function doNewAction($formType, Entity $entity, Request $request, $successMessage = null, $extra = [])
    {
        $form = $this->doCreateCreateForm($formType, $entity, $request->get('_route'), $extra);
        if ($request->isMethod('POST'))
        {
                Severity: Minor
                Found in Controller/CRUDController.php - About 1 hr to fix

                  Method resetPoll has 9 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      protected function resetPoll(ObjectManager $manager, $url, $title, $headLines, $bottomLines, $names, $events, $choices, $participations)
                  Severity: Major
                  Found in DataFixtures/ORM/LoadExamplePolls.php - About 1 hr to fix

                    Method loadPicnic has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function loadPicnic(ObjectManager $manager)
    {
        $names = ['Élise', 'Jules', 'Marie', 'Romain', 'Margaux'];
        $events = [
            ['name' => 'Date 1', 'place' => 'Central Park', 'date' => new \DateTime('+10 year'), 'time' => new \DateTime('12:00')],
                    Severity: Minor
                    Found in DataFixtures/ORM/LoadExamplePolls.php - About 1 hr to fix

                      Method doEditAction has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function doEditAction($formType, $id, Request $request, $extra = [])
    {
        $em = $this->getDoctrine()->getManager();

        /** @var Entity $entity */
                      Severity: Minor
                      Found in Controller/CRUDController.php - About 1 hr to fix

                        Function unlockAction has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function unlockAction(Request $request)
    {
        $poll = (new Poll)->setTitle("dummy")->setUrl("dummy");
        $form = $this->createForm(LockPollType::class, $poll, [
            'method' => 'PUT',
                        Severity: Minor
                        Found in Controller/PollController.php - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                $form->add('actions', FormActionsType::class, [
            'buttons' => [
                'save' => ['type' => SubmitType::class, 'options' => ['label' => 'save']],
                'cancel' => ['type' => SubmitType::class, 'options' => ['label' => 'cancel', 'attr' => ['type' => 'default', 'novalidate' => true]]],
            ]
                        Severity: Major
                        Found in Controller/CRUDController.php and 2 other locations - About 40 mins to fix
                        Controller/PollController.php on lines 189..194
                        Controller/PollController.php on lines 233..238

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 94.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                $form->add('actions', FormActionsType::class, [
            'buttons' => [
                'save' => ['type' => SubmitType::class, 'options' => ['label' => 'save']],
                'cancel' => ['type' => SubmitType::class, 'options' => ['label' => 'cancel', 'attr' => ['type' => 'default', 'novalidate' => true]]],
            ]
                        Severity: Major
                        Found in Controller/PollController.php and 2 other locations - About 40 mins to fix
                        Controller/CRUDController.php on lines 228..233
                        Controller/PollController.php on lines 233..238

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 94.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                $form->add('actions', FormActionsType::class, [
            'buttons' => [
                'save' => ['type' => SubmitType::class, 'options' => ['label' => 'save']],
                'cancel' => ['type' => SubmitType::class, 'options' => ['label' => 'cancel', 'attr' => ['type' => 'default', 'novalidate' => true]]],
            ]
                        Severity: Major
                        Found in Controller/PollController.php and 2 other locations - About 40 mins to fix
                        Controller/CRUDController.php on lines 228..233
                        Controller/PollController.php on lines 189..194

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 94.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method doNewAction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            protected function doNewAction($formType, Entity $entity, Request $request, $successMessage = null, $extra = [])
                        Severity: Minor
                        Found in Controller/CRUDController.php - About 35 mins to fix

                          Function lockAction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function lockAction(Request $request)
    {
        $form = $this->createForm(LockPollType::class, $this->poll, [
            'method' => 'PUT',
        ]);
                          Severity: Minor
                          Found in Controller/PollController.php - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language