ablanco/jquery.pwstrength.bootstrap

View on GitHub

Showing 8 of 8 total issues

Function updatePopover has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    ui.updatePopover = function(options, $el, verdictText, remove) {
        var popover = $el.data('bs.popover'),
            html = '',
            hide = true,
            bootstrap5 = false,
Severity: Major
Found in src/ui.popover.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        validation.wordLetterNumberCharCombo = function(options, word, score) {
            var letterNumberCharComboRE = new RegExp(
                '([a-zA-Z0-9].*' +
                    options.rules.specialCharClass +
                    ')|(' +
    Severity: Major
    Found in src/rules.js and 1 other location - About 2 hrs to fix
    src/rules.js on lines 180..190

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        validation.wordTwoSpecialChar = function(options, word, score) {
            var twoSpecialCharRE = new RegExp(
                '(.*' +
                    options.rules.specialCharClass +
                    '.*' +
    Severity: Major
    Found in src/rules.js and 1 other location - About 2 hrs to fix
    src/rules.js on lines 200..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function getUIElements has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        ui.getUIElements = function(options, $el) {
            var $container, result;
    
            if (options.instances.viewports) {
                return options.instances.viewports;
    Severity: Minor
    Found in src/ui.js - About 1 hr to fix

      Function updateUI has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          ui.updateUI = function(options, $el, score) {
              var cssClass, verdictText, verdictCssClass;
      
              cssClass = ui.getVerdictAndCssClass(options, score);
              verdictText = score === 0 ? '' : cssClass[0];
      Severity: Minor
      Found in src/ui.js - About 1 hr to fix

        Function wordSequences has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            validation.wordSequences = function(options, word, score) {
                var found = false,
                    j;
        
                if (word.length > 2) {
        Severity: Minor
        Found in src/rules.js - About 1 hr to fix

          Function updateProgressBar has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              ui.updateProgressBar = function(options, $el, cssClass, percentage) {
                  var $progressbar = ui.getUIElements(options, $el).$progressbar,
                      $bar = $progressbar.find('.progress-bar'),
                      cssPrefix = 'progress-';
          
          
          Severity: Minor
          Found in src/ui.progressbar.js - About 1 hr to fix

            Function showProgressBar has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    options,
                    $el,
                    score,
                    cssClass,
                    verdictCssClass,
            Severity: Minor
            Found in src/ui.progressbar.js - About 45 mins to fix
              Severity
              Category
              Status
              Source
              Language