Sign upLogin

ablaser/airtemplate

View on GitHub
Star
src/Builder.php

Summary

Maintainability
A
1 hr
Test Coverage

Function load has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function load($templates)
    {
        $this->complexity = 0;
        $this->templates = $this->loader->load($templates);
        $this->createFieldOptions();
Severity: Minor
Found in src/Builder.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return ['php:', $option];
Severity: Major
Found in src/Builder.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return false;
    Severity: Major
    Found in src/Builder.php - About 30 mins to fix

      Missing class import via use statement (line '127', column '24').
      Open

                  return new \AirTemplate\Engine($this->templates, $this->fieldOptions);
      Severity: Minor
      Found in src/Builder.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '129', column '20').
      Open

              return new \AirTemplate\BaseEngine($this->templates, $this->fieldOptions);
      Severity: Minor
      Found in src/Builder.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid assigning values to variables in if clauses and the like (line '251', column '23').
      Open

          protected function getCallback($option)
    {
        if (is_array($option)) {
            return $this->getEngineCallback($option);
        }
      Severity: Minor
      Found in src/Builder.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Avoid unused local variables such as '$name'.
      Open

                  foreach ($this->templates as $name => $template) {
      Severity: Minor
      Found in src/Builder.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      There are no issues that match your filters.

      Category
      Status