abrain/einsatzverwaltung

View on GitHub
src/Export/Tool.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Method renderToolPage has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function renderToolPage()
    {
        echo '<div class="wrap">';
        echo '<h1>' . 'Einsatzberichte exportieren' . '</h1>';
        echo '<p>Dieses Werkzeug exportiert Einsatzberichte in verschiedenen Formaten.</p>'; ?>
Severity: Minor
Found in src/Export/Tool.php - About 1 hr to fix

    Function renderDateOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function renderDateOptions()
        {
            global $wpdb, $wp_locale;
    
            $months = $wpdb->get_results($wpdb->prepare("
    Severity: Minor
    Found in src/Export/Tool.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method startExport() contains an exit expression.
    Wontfix

                    die();
    Severity: Minor
    Found in src/Export/Tool.php by phpmd

    ExitExpression

    Since: 0.2

    An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

    Example

    class Foo {
        public function bar($param)  {
            if ($param === 42) {
                exit(23);
            }
        }
    }

    Source https://phpmd.org/rules/design.html#exitexpression

    There are no issues that match your filters.

    Category
    Status