Sign upLogin

abrain/einsatzverwaltung

View on GitHub
Star
src/Settings/Pages/General.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Function maybeCategorySpecialChanged has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function maybeCategorySpecialChanged($newValue, $oldValue): string
    {
        // Nur Änderungen sind interessant
        if ($newValue == $oldValue) {
            return $newValue;
Severity: Minor
Found in src/Settings/Pages/General.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function maybeCategoryChanged has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function maybeCategoryChanged($newValue, $oldValue): string
    {
        // Nur Änderungen sind interessant
        if ($newValue == $oldValue) {
            return $newValue;
Severity: Minor
Found in src/Settings/Pages/General.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid excessively long variable names like $onlySpecialInCategory. Keep variable name length under 20.
Open

            $onlySpecialInCategory = self::$options->isOnlySpecialInLoop();
Severity: Minor
Found in src/Settings/Pages/General.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

There are no issues that match your filters.

Category
Status