Sign upLogin

abzcoding/hget

View on GitHub
Star

Showing 9 of 15 total issues

Method HTTPDownloader.Do has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
Open

func (d *HTTPDownloader) Do(doneChan chan bool, fileChan chan string, errorChan chan error, interruptChan chan bool, stateSaveChan chan Part) {
    var ws sync.WaitGroup
    var bars []*pb.ProgressBar
    var barpool *pb.Pool
    var err error
Severity: Minor
Found in http.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method HTTPDownloader.Do has 101 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (d *HTTPDownloader) Do(doneChan chan bool, fileChan chan string, errorChan chan error, interruptChan chan bool, stateSaveChan chan Part) {
    var ws sync.WaitGroup
    var bars []*pb.ProgressBar
    var barpool *pb.Pool
    var err error
Severity: Major
Found in http.go - About 3 hrs to fix

    Function main has 62 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func main() {
    var err error
    var proxy, filepath, bwLimit string

    conn := flag.Int("n", runtime.NumCPU(), "connection")
    Severity: Minor
    Found in main.go - About 1 hr to fix

      Function Execute has 55 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func Execute(url string, state *State, conn int, skiptls bool, proxy string, bwLimit string) {
    //otherwise is hget <URL> command

    signalChan := make(chan os.Signal, 1)
    signal.Notify(signalChan,
      Severity: Minor
      Found in main.go - About 1 hr to fix

        Function NewHTTPDownloader has 52 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func NewHTTPDownloader(url string, par int, skipTLS bool, proxyServer string, bwLimit string) *HTTPDownloader {
    var resumable = true
    client := ProxyAwareHTTPClient(proxyServer)

    parsed, err := stdurl.Parse(url)
        Severity: Minor
        Found in http.go - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                              if err := s.Save(); err != nil {
                        Errorf("%v\n", err)
                    }
          Severity: Major
          Found in main.go - About 45 mins to fix

            Function main has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
            Open

            func main() {
    var err error
    var proxy, filepath, bwLimit string

    conn := flag.Int("n", runtime.NumCPU(), "connection")
            Severity: Minor
            Found in main.go - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function Execute has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
            Open

            func Execute(url string, state *State, conn int, skiptls bool, proxy string, bwLimit string) {
    //otherwise is hget <URL> command

    signalChan := make(chan os.Signal, 1)
    signal.Notify(signalChan,
            Severity: Minor
            Found in main.go - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Your code does not pass gofmt in 1 place. Go fmt your code!
            Open

            package main
            Severity: Minor
            Found in joiner.go by gofmt
            Severity
            Category
            Status
            Source
            Language