Sign upLogin

ace-teknologi/abra

View on GitHub
Star

Showing 19 of 19 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package cmd

import (
    "encoding/json"
    "encoding/xml"
Severity: Major
Found in cmd/find_abn.go and 1 other location - About 7 hrs to fix
cmd/find_acn.go on lines 1..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 491.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package cmd

import (
    "encoding/json"
    "encoding/xml"
Severity: Major
Found in cmd/find_acn.go and 1 other location - About 7 hrs to fix
cmd/find_abn.go on lines 1..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 491.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (c *Client) SearchByASICv201408(acn string, hist bool) (*BusinessEntity, error) {
    if ok, err := ValidateACN(acn); !ok {
        return nil, err
    }
Severity: Major
Found in abra-lib/client.go and 1 other location - About 3 hrs to fix
abra-lib/client.go on lines 299..332

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 301.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (c *Client) SearchByABNv201408(abn string, hist bool) (*BusinessEntity, error) {
    if ok, err := ValidateABN(abn); !ok {
        return nil, err
    }
Severity: Major
Found in abra-lib/client.go and 1 other location - About 3 hrs to fix
abra-lib/client.go on lines 345..378

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 301.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method Client.SearchByNameAdvancedSimpleProtocol2017 has 76 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Client) SearchByNameAdvancedSimpleProtocol2017(name string, params *NameSearchParams) (*ResponseSearchResultsList, error) {
    // Strip whitespace
    name = strings.Trim(name, " ")

    if len(name) == 0 {
Severity: Major
Found in abra-lib/client.go - About 2 hrs to fix

    Method Client.SearchByNameAdvancedSimpleProtocol2017 has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

    func (c *Client) SearchByNameAdvancedSimpleProtocol2017(name string, params *NameSearchParams) (*ResponseSearchResultsList, error) {
    // Strip whitespace
    name = strings.Trim(name, " ")

    if len(name) == 0 {
    Severity: Minor
    Found in abra-lib/client.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (r *SearchResultsRecord) Score() int32 {
    if r.MainName != nil {
        return r.MainName.Score
    }
    if r.MainTradingName != nil {
    Severity: Major
    Found in abra-lib/client.go and 2 other locations - About 1 hr to fix
    abra-lib/client.go on lines 127..144
    abra-lib/client.go on lines 167..184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (r *SearchResultsRecord) Name() string {
    if r.MainName != nil {
        return r.MainName.OrganisationName
    }
    if r.MainTradingName != nil {
    Severity: Major
    Found in abra-lib/client.go and 2 other locations - About 1 hr to fix
    abra-lib/client.go on lines 147..164
    abra-lib/client.go on lines 167..184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (r *SearchResultsRecord) IsCurrentIndicator() string {
    if r.MainName != nil {
        return r.MainName.IsCurrentIndicator
    }
    if r.MainTradingName != nil {
    Severity: Major
    Found in abra-lib/client.go and 2 other locations - About 1 hr to fix
    abra-lib/client.go on lines 127..144
    abra-lib/client.go on lines 147..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function findABN has 9 return statements (exceeds 4 allowed).
    Open

    func findABN() error {
    // Ensure we have a GUID
    err := setGUID()
    if err != nil {
        return err
    Severity: Major
    Found in cmd/find_abn.go - About 55 mins to fix

      Function searchByName has 9 return statements (exceeds 4 allowed).
      Open

      func searchByName() error {
    // Ensure we have a GUID
    err := setGUID()
    if err != nil {
        return err
      Severity: Major
      Found in cmd/search.go - About 55 mins to fix

        Function findACN has 9 return statements (exceeds 4 allowed).
        Open

        func findACN() error {
    // Ensure we have a GUID
    err := setGUID()
    if err != nil {
        return err
        Severity: Major
        Found in cmd/find_acn.go - About 55 mins to fix

          Method SearchResultsRecord.IsCurrentIndicator has 6 return statements (exceeds 4 allowed).
          Open

          func (r *SearchResultsRecord) IsCurrentIndicator() string {
    if r.MainName != nil {
        return r.MainName.IsCurrentIndicator
    }
    if r.MainTradingName != nil {
          Severity: Major
          Found in abra-lib/client.go - About 40 mins to fix

            Method BusinessEntity.Name has 6 return statements (exceeds 4 allowed).
            Open

            func (b *BusinessEntity) Name() string {
    for _, name := range b.MainNames {
        return name.OrganisationName
    }
            Severity: Major
            Found in abra-lib/abr.go - About 40 mins to fix

              Method SearchResultsRecord.Score has 6 return statements (exceeds 4 allowed).
              Open

              func (r *SearchResultsRecord) Score() int32 {
    if r.MainName != nil {
        return r.MainName.Score
    }
    if r.MainTradingName != nil {
              Severity: Major
              Found in abra-lib/client.go - About 40 mins to fix

                Method SearchResultsRecord.Name has 6 return statements (exceeds 4 allowed).
                Open

                func (r *SearchResultsRecord) Name() string {
    if r.MainName != nil {
        return r.MainName.OrganisationName
    }
    if r.MainTradingName != nil {
                Severity: Major
                Found in abra-lib/client.go - About 40 mins to fix

                  Method Client.SearchByNameAdvancedSimpleProtocol2017 has 5 return statements (exceeds 4 allowed).
                  Open

                  func (c *Client) SearchByNameAdvancedSimpleProtocol2017(name string, params *NameSearchParams) (*ResponseSearchResultsList, error) {
    // Strip whitespace
    name = strings.Trim(name, " ")

    if len(name) == 0 {
                  Severity: Major
                  Found in abra-lib/client.go - About 35 mins to fix

                    Method Client.SearchByABNv201408 has 5 return statements (exceeds 4 allowed).
                    Open

                    func (c *Client) SearchByABNv201408(abn string, hist bool) (*BusinessEntity, error) {
    if ok, err := ValidateABN(abn); !ok {
        return nil, err
    }
                    Severity: Major
                    Found in abra-lib/client.go - About 35 mins to fix

                      Method Client.SearchByASICv201408 has 5 return statements (exceeds 4 allowed).
                      Open

                      func (c *Client) SearchByASICv201408(acn string, hist bool) (*BusinessEntity, error) {
    if ok, err := ValidateACN(acn); !ok {
        return nil, err
    }
                      Severity: Major
                      Found in abra-lib/client.go - About 35 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language