Showing 12 of 19 total issues
Method Client.SearchByNameAdvancedSimpleProtocol2017 has 76 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func (c *Client) SearchByNameAdvancedSimpleProtocol2017(name string, params *NameSearchParams) (*ResponseSearchResultsList, error) {
// Strip whitespace
name = strings.Trim(name, " ")
if len(name) == 0 {Method Client.SearchByNameAdvancedSimpleProtocol2017 has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring. Open
Open
func (c *Client) SearchByNameAdvancedSimpleProtocol2017(name string, params *NameSearchParams) (*ResponseSearchResultsList, error) {
// Strip whitespace
name = strings.Trim(name, " ")
if len(name) == 0 {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function findABN has 9 return statements (exceeds 4 allowed). Open
Open
func findABN() error {
// Ensure we have a GUID
err := setGUID()
if err != nil {
return errFunction searchByName has 9 return statements (exceeds 4 allowed). Open
Open
func searchByName() error {
// Ensure we have a GUID
err := setGUID()
if err != nil {
return errFunction findACN has 9 return statements (exceeds 4 allowed). Open
Open
func findACN() error {
// Ensure we have a GUID
err := setGUID()
if err != nil {
return errMethod SearchResultsRecord.IsCurrentIndicator has 6 return statements (exceeds 4 allowed). Open
Open
func (r *SearchResultsRecord) IsCurrentIndicator() string {
if r.MainName != nil {
return r.MainName.IsCurrentIndicator
}
if r.MainTradingName != nil {Method BusinessEntity.Name has 6 return statements (exceeds 4 allowed). Open
Open
func (b *BusinessEntity) Name() string {
for _, name := range b.MainNames {
return name.OrganisationName
}
Method SearchResultsRecord.Score has 6 return statements (exceeds 4 allowed). Open
Open
func (r *SearchResultsRecord) Score() int32 {
if r.MainName != nil {
return r.MainName.Score
}
if r.MainTradingName != nil {Method SearchResultsRecord.Name has 6 return statements (exceeds 4 allowed). Open
Open
func (r *SearchResultsRecord) Name() string {
if r.MainName != nil {
return r.MainName.OrganisationName
}
if r.MainTradingName != nil {Method Client.SearchByNameAdvancedSimpleProtocol2017 has 5 return statements (exceeds 4 allowed). Open
Open
func (c *Client) SearchByNameAdvancedSimpleProtocol2017(name string, params *NameSearchParams) (*ResponseSearchResultsList, error) {
// Strip whitespace
name = strings.Trim(name, " ")
if len(name) == 0 {Method Client.SearchByABNv201408 has 5 return statements (exceeds 4 allowed). Open
Open
func (c *Client) SearchByABNv201408(abn string, hist bool) (*BusinessEntity, error) {
if ok, err := ValidateABN(abn); !ok {
return nil, err
}
Method Client.SearchByASICv201408 has 5 return statements (exceeds 4 allowed). Open
Open
func (c *Client) SearchByASICv201408(acn string, hist bool) (*BusinessEntity, error) {
if ok, err := ValidateACN(acn); !ok {
return nil, err
}