Sign upLogin

aceberg/WatchYourPorts

View on GitHub
Star

Showing 6 of 6 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

async function loadHistory() {
    
    let url = '/api/history';
    let histMap = await (await fetch(url)).json();
    if (histMap != null) {
Severity: Major
Found in internal/web/public/js/history.js and 1 other location - About 1 hr to fix
internal/web/public/js/index.js on lines 33..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

async function loadAddrs() {
    
    let url = '/api/all';
    let addrsMap = await (await fetch(url)).json();
    if (addrsMap != null) {
Severity: Major
Found in internal/web/public/js/index.js and 1 other location - About 1 hr to fix
internal/web/public/js/history.js on lines 32..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function createHTML has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createHTML(port, i, found) {
    let state = ``;
    let checked = ``;
    let sup = ``;
Severity: Minor
Found in internal/web/public/js/scan.js - About 1 hr to fix

    Function scanAddr has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function scanAddr() {
    let begin = document.getElementById("begin").value;
    let end = document.getElementById("end").value;
    let savedPorts = [];
    Severity: Minor
    Found in internal/web/public/js/scan.js - About 1 hr to fix

      Function scanAddr has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      async function scanAddr() {
    let begin = document.getElementById("begin").value;
    let end = document.getElementById("end").value;
    let savedPorts = [];
      Severity: Minor
      Found in internal/web/public/js/scan.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createHTML has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function createHTML(port, i, found) {
    let state = ``;
    let checked = ``;
    let sup = ``;
      Severity: Minor
      Found in internal/web/public/js/scan.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language