Sign upLogin

aceleradora-TW/nao-me-calo

View on GitHub
Star
app/controllers/ratings_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method create has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    if params[:accepted_terms] && params[:rating][:rating_date] && params[:rating][:cpf]

      if Obscenity.profane?(rating_params[:description])
        redirect_to controller: :ratings, action: :new, placeId: params[:placeId]
Severity: Minor
Found in app/controllers/ratings_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for create is too high. [15/6]
Open

  def create
    if params[:accepted_terms] && params[:rating][:rating_date] && params[:rating][:cpf]

      if Obscenity.profane?(rating_params[:description])
        redirect_to controller: :ratings, action: :new, placeId: params[:placeId]
Severity: Minor
Found in app/controllers/ratings_controller.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method create has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    if params[:accepted_terms] && params[:rating][:rating_date] && params[:rating][:cpf]

      if Obscenity.profane?(rating_params[:description])
        redirect_to controller: :ratings, action: :new, placeId: params[:placeId]
Severity: Minor
Found in app/controllers/ratings_controller.rb - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                  @rating.description.empty? ? notice = "Avaliação feita com sucesso!" : notice = "Avaliação feita com sucesso! Sua avaliação irá passar pela moderação."
    Severity: Major
    Found in app/controllers/ratings_controller.rb - About 45 mins to fix

      Consider simplifying this complex logical expression.
      Open

              if(!(@rating.woman.nil? && @rating.lgbtqia.nil? && @rating.race.nil? && @rating.disability.nil? && @rating.elder.nil? && @rating.obese.nil?))
          if(@establishment.nil?)
            @place = @client.spot(params[:placeId])
            @establishment = Establishment.create!(name: @place.name, address: @place.formatted_address, lat: @place.lat, lng: @place.lng, id_places: @place.place_id, city: @place.city)
          end
      Severity: Major
      Found in app/controllers/ratings_controller.rb - About 40 mins to fix

        Method moderated has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def moderated
    respond_to do |format|
      if(@rating.moderated == false)
        @rating.moderated = true
      else
        Severity: Minor
        Found in app/controllers/ratings_controller.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid more than 4 levels of block nesting.
        Open

                      @rating.description.empty? ? notice = "Avaliação feita com sucesso!" : notice = "Avaliação feita com sucesso! Sua avaliação irá passar pela moderação."
        Severity: Minor
        Found in app/controllers/ratings_controller.rb by rubocop

        This cop checks for excessive nesting of conditional and looping constructs.

        You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

        The maximum level of nesting allowed is configurable.

        There are no issues that match your filters.

        Category
        Status