Showing 538 of 538 total issues
Function reset
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function reset() {
var keepZoomLayer = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : false;
var keepAnnotations = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
this.cancelRendering();
Function EventBus
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
var EventBus = function () {
function EventBus() {
_classCallCheck(this, EventBus);
this._listeners = Object.create(null);
Function DownloadManager
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
var DownloadManager = function () {
function DownloadManager() {
_classCallCheck(this, DownloadManager);
}
Function EventBus
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
var EventBus = function () {
function EventBus() {
_classCallCheck(this, EventBus);
this._listeners = Object.create(null);
Function webViewerWheel
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
function webViewerWheel(evt) {
var pdfViewer = PDFViewerApplication.pdfViewer;
if (pdfViewer.isInPresentationMode) {
return;
}
Function reset
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function reset() {
var keepZoomLayer = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : false;
var keepAnnotations = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
this.cancelRendering();
Function PDFPresentationMode
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
function PDFPresentationMode(_ref) {
var _this = this;
var container = _ref.container,
_ref$viewer = _ref.viewer,
Function PDFPageView
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
function PDFPageView(options) {
_classCallCheck(this, PDFPageView);
var container = options.container;
var defaultViewport = options.defaultViewport;
Function _setScale
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function _setScale(value) {
var noScroll = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
var scale = parseFloat(value);
if (scale > 0) {
Function PDFPresentationMode
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
function PDFPresentationMode(_ref) {
var _this = this;
var container = _ref.container,
_ref$viewer = _ref.viewer,
Function init
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
init(pdfjsLib, container) {
/*
* Basic Layout:
* PDFBug
* Controls
Function PDFPageView
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
function PDFPageView(options) {
_classCallCheck(this, PDFPageView);
var container = options.container;
var defaultViewport = options.defaultViewport;
Function _setScale
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function _setScale(value) {
var noScroll = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
var scale = parseFloat(value);
if (scale > 0) {
Function approximateFraction
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
function approximateFraction(x) {
if (Math.floor(x) === x) {
return [x, 1];
}
var xinv = 1 / x;
Function approximateFraction
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
function approximateFraction(x) {
if (Math.floor(x) === x) {
return [x, 1];
}
var xinv = 1 / x;
Similar blocks of code found in 2 locations. Consider refactoring. Open
if self.create_parent_get:
fct = self.create_parent_get
if not callable(fct):
fct = getattr(records, fct)
return fct(self, backend)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 43.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if self.create_properties_get:
fct = self.create_properties_get
if not callable(fct):
fct = getattr(records, fct)
return fct(self, backend)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 43.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function paintOnSvg
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function paintOnSvg(wrapper) {
var _this2 = this;
var cancelled = false;
var ensureNotCancelled = function ensureNotCancelled() {
Function bindEvents
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
bindEvents: function bindEvents() {
var eventBus = this.eventBus,
_boundEvents = this._boundEvents;
_boundEvents.beforePrint = this.beforePrint.bind(this);
Function unbindEvents
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
unbindEvents: function unbindEvents() {
var eventBus = this.eventBus,
_boundEvents = this._boundEvents;
eventBus.off('resize', webViewerResize);