Showing 538 of 538 total issues
Function TempImageFactoryClosure
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
var TempImageFactory = function TempImageFactoryClosure() {
var tempCanvasCache = null;
return {
getCanvas: function getCanvas(width, height) {
var tempCanvas = tempCanvasCache;
Function setDocument
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function setDocument(pdfDocument) {
var _this = this;
if (this.pdfDocument) {
this._cancelRendering();
Function pdfHistory_getPreviousParams
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
_getPreviousParams: function pdfHistory_getPreviousParams(onlyCheckPage, beforeUnload) {
if (!(this.currentBookmark && this.currentPage)) {
return null;
} else if (this.updatePreviousBookmark) {
this.updatePreviousBookmark = false;
Function ViewHistory
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
function ViewHistory(fingerprint) {
var _this = this;
var cacheSize = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : DEFAULT_VIEW_HISTORY_CACHE_SIZE;
Function nextEntry
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
function nextEntry() {
while (true) {
if (!entries.length) {
parsedRawLinesCallback();
return;
Function setDocument
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function setDocument(pdfDocument) {
var _this = this;
if (this.pdfDocument) {
this._cancelRendering();
Function finishPaintTask
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
var finishPaintTask = function finishPaintTask(error) {
if (paintTask === _this.paintTask) {
_this.paintTask = null;
}
if (error === 'cancelled' || error instanceof _pdfjsLib.RenderingCancelledException) {
Function TempImageFactoryClosure
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
var TempImageFactory = function TempImageFactoryClosure() {
var tempCanvasCache = null;
return {
getCanvas: function getCanvas(width, height) {
var tempCanvas = tempCanvasCache;
Similar blocks of code found in 2 locations. Consider refactoring. Open
this.$el.find('.root-content-action-new-folder').on('click', function(e){
var dialog = new CmisCreateFolderDialog(self, self.dislayed_folder_cmisobject);
dialog.open();
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 56.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
this.$el.find('.root-content-action-new-doc').on('click', function(e){
var dialog = new CmisCreateDocumentDialog(self, self.dislayed_folder_cmisobject);
dialog.open();
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 56.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function getDefaultPreferences
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
function getDefaultPreferences() {
if (!defaultPreferences) {
defaultPreferences = Promise.resolve({
"showPreviousViewOnLoad": true,
"defaultZoomValue": "",
Function renderPage
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
function renderPage(activeServiceOnEntry, pdfDocument, pageNumber, size) {
var scratchCanvas = activeService.scratchCanvas;
var PRINT_RESOLUTION = 150;
var PRINT_UNITS = PRINT_RESOLUTION / 72.0;
scratchCanvas.width = Math.floor(size.width * PRINT_UNITS);
Function render
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function render(viewport) {
var _this = this;
var intent = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 'display';
Function calcFindMatch
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function calcFindMatch(pageIndex) {
var pageContent = this.normalize(this.pageContents[pageIndex]);
var query = this.normalize(this.state.query);
var caseSensitive = this.state.caseSensitive;
var phraseSearch = this.state.phraseSearch;
Function init
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
init: function(parent, cmisObjectWrapped, options) {
var self = this;
var btnOkTitle = _t('OK');
if (!_.isUndefined(options) && _.has(options, 'btnOkTitle')){
btnOkTitle = options.btnOkTitle;
Function add
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
add(pageNumber, stat) {
if (!stat) {
return;
}
var statsIndex = getStatIndex(pageNumber);
Function renderPage
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
function renderPage(activeServiceOnEntry, pdfDocument, pageNumber, size) {
var scratchCanvas = activeService.scratchCanvas;
var PRINT_RESOLUTION = 150;
var PRINT_UNITS = PRINT_RESOLUTION / 72.0;
scratchCanvas.width = Math.floor(size.width * PRINT_UNITS);
Function calcFindMatch
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function calcFindMatch(pageIndex) {
var pageContent = this.normalize(this.pageContents[pageIndex]);
var query = this.normalize(this.state.query);
var caseSensitive = this.state.caseSensitive;
var phraseSearch = this.state.phraseSearch;
Function render
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function render(viewport) {
var _this = this;
var intent = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 'display';
Consider simplifying this complex logical expression. Open
if (event.keyCode === 80 && (event.ctrlKey || event.metaKey) && !event.altKey && (!event.shiftKey || window.chrome || window.opera)) {
window.print();
if (hasAttachEvent) {
return;
}