Showing 538 of 538 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
session.createItem = function (folderId, properties, policies, addACEs, removeACEs, options) {
options = _fill(options);
options.objectId = folderId;
_setProps(properties, options);
if (policies) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 141.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function PDFAttachmentViewer
has 123 lines of code (exceeds 25 allowed). Consider refactoring. Open
var PDFAttachmentViewer = function () {
function PDFAttachmentViewer(_ref) {
var container = _ref.container,
eventBus = _ref.eventBus,
downloadManager = _ref.downloadManager;
Function PDFAttachmentViewer
has 123 lines of code (exceeds 25 allowed). Consider refactoring. Open
var PDFAttachmentViewer = function () {
function PDFAttachmentViewer(_ref) {
var container = _ref.container,
eventBus = _ref.eventBus,
downloadManager = _ref.downloadManager;
Function PDFBugClosure
has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring. Open
window.PDFBug = (function PDFBugClosure() {
var panelWidth = 300;
var buttons = [];
var activePanel = null;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function OverlayManager
has 109 lines of code (exceeds 25 allowed). Consider refactoring. Open
var OverlayManager = function () {
function OverlayManager() {
_classCallCheck(this, OverlayManager);
this._overlays = {};
Function getViewerConfiguration
has 109 lines of code (exceeds 25 allowed). Consider refactoring. Open
function getViewerConfiguration() {
return {
appContainer: document.body,
mainContainer: document.getElementById('viewerContainer'),
viewerContainer: document.getElementById('viewer'),
Function OverlayManager
has 109 lines of code (exceeds 25 allowed). Consider refactoring. Open
var OverlayManager = function () {
function OverlayManager() {
_classCallCheck(this, OverlayManager);
this._overlays = {};
Function getViewerConfiguration
has 109 lines of code (exceeds 25 allowed). Consider refactoring. Open
function getViewerConfiguration() {
return {
appContainer: document.body,
mainContainer: document.getElementById('viewerContainer'),
viewerContainer: document.getElementById('viewer'),
Function PDFRenderingQueue
has 105 lines of code (exceeds 25 allowed). Consider refactoring. Open
var PDFRenderingQueue = function () {
function PDFRenderingQueue() {
_classCallCheck(this, PDFRenderingQueue);
this.pdfViewer = null;
Function PDFRenderingQueue
has 105 lines of code (exceeds 25 allowed). Consider refactoring. Open
var PDFRenderingQueue = function () {
function PDFRenderingQueue() {
_classCallCheck(this, PDFRenderingQueue);
this.pdfViewer = null;
Identical blocks of code found in 2 locations. Consider refactoring. Open
function webViewerClick(evt) {
if (!PDFViewerApplication.secondaryToolbar.isOpen) {
return;
}
var appConfig = PDFViewerApplication.appConfig;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 119.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
function webViewerClick(evt) {
if (!PDFViewerApplication.secondaryToolbar.isOpen) {
return;
}
var appConfig = PDFViewerApplication.appConfig;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 119.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function ViewHistory
has 104 lines of code (exceeds 25 allowed). Consider refactoring. Open
var ViewHistory = function () {
function ViewHistory(fingerprint) {
var _this = this;
var cacheSize = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : DEFAULT_VIEW_HISTORY_CACHE_SIZE;
Function ViewHistory
has 104 lines of code (exceeds 25 allowed). Consider refactoring. Open
var ViewHistory = function () {
function ViewHistory(fingerprint) {
var _this = this;
var cacheSize = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : DEFAULT_VIEW_HISTORY_CACHE_SIZE;
Function draw
has 103 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function draw() {
var _this = this;
if (this.renderingState !== _pdf_rendering_queue.RenderingStates.INITIAL) {
console.error('Must be in new state before drawing');
Function draw
has 103 lines of code (exceeds 25 allowed). Consider refactoring. Open
value: function draw() {
var _this = this;
if (this.renderingState !== _pdf_rendering_queue.RenderingStates.INITIAL) {
console.error('Must be in new state before drawing');
Function _initializeViewerComponents
has 102 lines of code (exceeds 25 allowed). Consider refactoring. Open
_initializeViewerComponents: function _initializeViewerComponents() {
var _this2 = this;
var appConfig = this.appConfig;
return new Promise(function (resolve, reject) {
Function _initializeViewerComponents
has 102 lines of code (exceeds 25 allowed). Consider refactoring. Open
_initializeViewerComponents: function _initializeViewerComponents() {
var _this2 = this;
var appConfig = this.appConfig;
return new Promise(function (resolve, reject) {
Function PDFCursorTools
has 100 lines of code (exceeds 25 allowed). Consider refactoring. Open
var PDFCursorTools = function () {
function PDFCursorTools(_ref) {
var _this = this;
var container = _ref.container,
Function PDFCursorTools
has 100 lines of code (exceeds 25 allowed). Consider refactoring. Open
var PDFCursorTools = function () {
function PDFCursorTools(_ref) {
var _this = this;
var container = _ref.container,