activemerchant/active_merchant

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      MESSAGES = {
        'A' => 'Street address matches, but postal code does not match.',
        'B' => 'Street address matches, but postal code not verified.',
        'C' => 'Street address and postal code do not match.',
        'D' => 'Street address and postal code match.',

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

          if value.is_a?(Hash)
            h = {}
            value.each do |k, v|
              h["#{key}[#{k}]"] = v unless v.blank?
            end

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      AVS_CODE_TRANSLATOR = {
        '0' =>  'Approved, Address verification was not requested.',
        'A' =>  'Approved, Address matches only.',
        'B' =>  'Address Match. Street Address math for international transaction Postal Code not verified because of incompatible formats (Acquirer sent both street address and Postal Code)',
        'C' =>  'Serv Unavailable. Street address and Postal Code not verified for international transaction because of incompatible formats (Acquirer sent both street and Postal Code).',

• Read up
  Read up

Method build_credit_card_request has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def build_credit_card_request(action, money, credit_card, options)
        xml = Builder::XmlMarkup.new
        xml.tag! TRANSACTIONS[action] do
          xml.tag! 'PayData' do
            xml.tag! 'Invoice' do

Method build_reference_sale_or_authorization_request has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def build_reference_sale_or_authorization_request(action, money, reference, options)
        xml = Builder::XmlMarkup.new
        xml.tag! TRANSACTIONS[action] do
          xml.tag! 'PayData' do
            xml.tag! 'Invoice' do

Method credit has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def credit(money, creditcard, options = {})
        post = payment_request(money, options)
        post[:amount] = amount_hash(money, options[:currency])
        post[:card] = credit_card_hash(creditcard)
        post[:dateOfBirth] = options[:date_of_birth] if options[:date_of_birth]

Method store has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def store(payment, options = {})
        params = {}
        post = {}

        if payment.is_a?(ApplePayPaymentToken)

Method add_auth_wallet has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def add_auth_wallet(xml, payment_method, options)
        commerce_indicator = 'internet' if subsequent_nt_apple_pay_auth(payment_method.source, options)

        brand = card_brand(payment_method).to_sym

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      def parse_element(node)
        if node.has_elements?
          response = {}
          node.elements.each { |e|
            key = e.name.underscore

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      def parse_element(node)
        if node.has_elements?
          response = {}
          node.elements.each do |e|
            key = e.name.underscore

• Read up
  Read up

Method add_addresses has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def add_addresses(post, options)
        if address = options[:billing_address] || options[:address]
          post[:card_address1] = address[:address1]
          post[:card_zip]      = address[:zip]
          post[:card_city]     = address[:city]

Method soap_request has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def soap_request(arguments, action)
        # eWay demands all fields be sent, but contain an empty string if blank
        post = case action
               when 'QueryCustomer'
                 arguments

Method parse has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def parse(action, soap)
        xml = REXML::Document.new(soap)
        root = REXML::XPath.first(xml, '//SOAP-ENV:Body')
        response = root ? parse_element(root[0]) : { response: soap }

Method commit has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def commit(action, money, parameters)
        case action
        when 'sale'
          begin
            response = call_api(TRANSACTION_API, parameters)

Method update has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def update(vault_id, creditcard, options = {})
        braintree_credit_card = nil
        commit do
          braintree_credit_card = @braintree_gateway.customer.find(vault_id).credit_cards.detect(&:default?)
          return Response.new(false, 'Braintree::NotFoundError') if braintree_credit_card.nil?

Method build_create_subscription_request has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def build_create_subscription_request(payment_method, options)
        default_subscription_params = { frequency: 'on-demand', amount: 0, automatic_renew: false }
        options[:subscription] = default_subscription_params.update(
          options[:subscription] || {}
        )

Method add_pay_data has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def add_pay_data(xml, money, options)
        xml.tag! 'PayData' do
          xml.tag! 'Invoice' do
            xml.tag! 'CustIP', options[:ip] unless options[:ip].blank?
            xml.tag! 'InvNum', options[:order_id] unless options[:order_id].blank?

Method add_payout_sender_data has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def add_payout_sender_data(post, options)
        return unless options[:payout] == true

        post[:sender] = {
          # options for type are individual, corporate, or government

Method parse has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def parse(body)
        response = {}

        root = REXML::Document.new(body).root

Method avs_mapping has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def avs_mapping
        {
          'street: M, zip: M' => 'M',
          'street: M, zip: N' => 'A',
          'street: M, zip: U' => 'B',