activemerchant/active_merchant

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      def add_sub_payments(post, options)
        # sub_payments field is required for purchase transactions, even if empty
        post[:sub_payments] = []

        return unless sub_payments = options[:sub_payments]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      def purchase(amount, payment_method, options)
        commit('purchase', amount, options) do |xml|
          add_credentials(xml, options)
          add_invoice(xml, amount, options)
          add_track_id(xml, options[:order_id] || generate_unique_id)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      def authorize(amount, payment_method, options = {})
        post = {}
        add_invoice(post, amount, options)
        add_customer_vault_data(post, options)
        add_payment_method(post, payment_method, options)

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

        elsif response['error_type']
          response['error_type'] + ': ' + response['error_codes'].first
        else
          response_summary = response['response_summary'] || response.dig('actions', 0, 'response_summary')
          response_summary || response['response_code'] || response['status'] || response['message'] || 'Unable to read error message'

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        {
          browserAcceptHeader: browser_info[:accept_header],
          browserUserAgent: browser_info[:user_agent],
          browserJavaEnabled: browser_info[:java],
          browserJavascriptEnabled: browser_info[:java],

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      def purchase(money, payment, options = {})
        MultiResponse.run do |r|
          r.process { commit('tokenize', 'card_tokens', card_token_request(money, payment, options)) }
          options[:card_token] = r.authorization.split('|').first
          r.process { commit('purchase', 'payments', purchase_request(money, payment, options)) }

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      def add_duty(xml, duty)
        xml.tag!('duty') do
          xml.tag!('amount', duty[:amount]) if duty[:amount]
          xml.tag!('name', duty[:name]) if duty[:name]
          xml.tag!('description', duty[:description]) if duty[:description]

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      def add_order(xml, order)
        xml.tag!('order') do
          xml.tag!('invoiceNumber', order[:invoice_number]) if order[:invoice_number]
          xml.tag!('description', order[:description]) if order[:description]
          xml.tag!('purchaseOrderNumber', order[:purchase_order_number]) if order[:purchase_order_number]

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        post[:threeDSecure] = {
          threeDsVersion: three_d_secure[:version],
          EcommerceIndicator: three_d_secure[:eci],
          authenticationValue: three_d_secure[:cavv],
          directoryServerTransactionId:  three_d_secure[:ds_transaction_id],

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

          telecheck: {
            routing: options[:telecheck_routing],
            account: options[:telecheck_account],
            checknumber: options[:telecheck_checknumber],
            bankname: options[:telecheck_bankname],

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      def parse(xml)
        response = {}

        doc = Nokogiri::XML(xml)
        doc.root.xpath('*').each do |node|

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

              {
                eci: three_d_secure[:eci],
                xid: three_d_secure[:xid],
                threeDSTransactionId: three_d_secure[:ds_transaction_id],
                cavv: three_d_secure[:cavv],

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      def add_shipping(xml, shipping)
        xml.tag!('shipping') do
          xml.tag!('amount', shipping[:amount]) if shipping[:amount]
          xml.tag!('name', shipping[:name]) if shipping[:name]
          xml.tag!('description', shipping[:description]) if shipping[:description]

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      def parse(xml)
        response = {}

        doc = Nokogiri::XML(xml)
        doc.root.xpath('*').each do |node|

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        if options[:descriptor_name] || options[:descriptor_city]
          post[:billing_descriptor] = {}
          post[:billing_descriptor][:name] = options[:descriptor_name] if options[:descriptor_name]
          post[:billing_descriptor][:city] = options[:descriptor_city] if options[:descriptor_city]
        end

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        if options[:card_expiration_month] || options[:card_expiration_year]
          source[:card] = {}
          source[:card][:expirationMonth] = options[:card_expiration_month] if options[:card_expiration_month]
          source[:card][:expirationYear] = options[:card_expiration_year] if options[:card_expiration_year]
        end

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      def authorize(money, payment_method, options = {})
        post = {}
        add_amount(post, money, options)
        add_service_fee(post, options)
        add_invoice(post, options)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      def purchase(money, payment_method, options = {})
        post = {}
        add_amount(post, money, options)
        add_service_fee(post, options)
        add_invoice(post, options)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      def add_tax(xml, tax)
        xml.tag!('tax') do
          xml.tag!('amount', tax[:amount]) if tax[:amount]
          xml.tag!('name', tax[:name]) if tax[:name]
          xml.tag!('description', tax[:description]) if tax[:description]

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        if options[:application_fee] || options[:fee_payer]
          post[:fee] = {}
          post[:fee][:app_fee] = options[:application_fee] if options[:application_fee]
          post[:fee][:fee_payer] = options[:fee_payer] if options[:fee_payer]
        end

• Read up
  Read up