activemerchant/active_merchant

Avoid too many return statements within this method.

Open

        return response_code if response_code

Avoid too many return statements within this method.

Open

          return base + 'payments/refund'

Avoid too many return statements within this method.

Open

          return base + 'vault/token'

Avoid too many return statements within this method.

Open

          return base + 'noaction'

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      def add_user_defined_fields(xml, options)
        xml.tag! 'UDField1', options[:ud_field_1] if options[:ud_field_1]
        xml.tag! 'UDField2', options[:ud_field_2] if options[:ud_field_2]
        xml.tag! 'UDField3', options[:ud_field_3] if options[:ud_field_3]

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      def add_3ds_fields(post, options)
        post[:ThreeDSMessageId] = options[:three_ds_message_id] if options[:three_ds_message_id]
        post[:ThreeDS_PARes] = options[:three_ds_pares] if options[:three_ds_pares]
        post[:ThreeDS_CRes] = options[:three_ds_cres] if options[:three_ds_cres]

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      def add_invoice(post, options)
        post[:ORDER_ID]    = options[:order_id]
        post[:INVOICE_ID]  = options[:invoice]
        post[:invoice_num] = options[:order_id]
        post[:MEMO]        = options[:description]

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      def add_invoice_data(post, options)
        post[:orderid]            = options[:order_id]
        post[:ponumber]           = options[:invoice]
        post[:orderdescription]   = options[:description]
        post[:tax]                = options[:tax]

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      def add_customer_data(xml, options)
        xml.tag! 'Customer_Ref', options[:customer] if options[:customer]
        xml.tag! 'Client_IP', options[:ip] if options[:ip]
        xml.tag! 'Client_Email', options[:email] if options[:email]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      def add_check(post, check)
        post[:C_first_name]   = check.first_name
        post[:C_last_name]    = check.last_name
        post[:C_rte]          = check.routing_number
        post[:C_acct]         = check.account_number

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        Response.new(
          successful?(response),
          message_from(response),
          response,
          test: test?,

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      def add_customer_data(post, options)
        post[:CLIENTREFERRER]  = options[:referrer]
        post[:CLIENTUSERAGENT] = options[:user_agent]
        post[:CLIENTIP]        = options[:ip]
        post[:CLIENTEMAIL]     = options[:email]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      def add_creditcard(post, creditcard)
        post[:cardno]          = creditcard.number
        post[:cid]             = creditcard.verification_value
        post[:expdate]         = expdate(creditcard)
        post[:card_name_g]     = creditcard.name

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        Response.new(
          successful?(response),
          message_from(response),
          response,
          test: test?,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          if node.elements.empty?
            parsed[node.name.to_sym] = node.text
          else
            node.elements.each do |childnode|
              name = "#{node.name}_#{childnode.name}"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      CURRENCY_CODES = {
        'AUD' => '036',
        'CAD' => '124',
        'CZK' => '203',
        'DKK' => '208',

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      def add_cof(post, options)
        post[:issuer_id] = options[:issuer_id] if options[:issuer_id]
        post[:payment_indicator] = options[:payment_indicator] if options[:payment_indicator]
        post[:payment_information] = options[:payment_information] if options[:payment_information]

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      def add_customer_data(post, options)
        post[:owner_email] = options[:email] if options[:email]
        post[:remote_ip_address] = options[:ip] if options[:ip]
        post[:processor_id] = options[:processor_id] if options[:processor_id]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

              if node.elements.empty?
                h[node.name.to_sym] = node.text
              else
                node.elements.each do |childnode|
                  name = "#{node.name}_#{childnode.name}"

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      def add_user_defined_fields(xml, options)
        xml.tag! 'UDField1', options[:ud_field_1] if options[:ud_field_1]
        xml.tag! 'UDField2', options[:ud_field_2] if options[:ud_field_2]
        xml.tag! 'UDField3', options[:ud_field_3] if options[:ud_field_3]

• Read up
  Read up