lib/active_merchant/billing/gateways/realex.rb
Class RealexGateway
has 37 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class RealexGateway < Gateway
self.live_url = self.test_url = 'https://epage.payandshop.com/epage-remote.cgi'
CARD_MAPPING = {
'master' => 'MC',
File realex.rb
has 327 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
require 'nokogiri'
require 'digest/sha1'
module ActiveMerchant
module Billing
Method add_address_and_customer_info
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
Open
def add_address_and_customer_info(xml, options)
billing_address = options[:billing_address] || options[:address]
shipping_address = options[:shipping_address]
ipv4_address = ipv4?(options[:ip]) ? options[:ip] : nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def parse(xml)
response = {}
doc = Nokogiri::XML(xml)
doc.xpath('//response/*').each do |node|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"