Sign upLogin

activemerchant/active_merchant

View on GitHub
Star
lib/active_merchant/billing/gateways/worldpay_online_payments.rb

Summary

Maintainability
C
1 day
Test Coverage

Method commit has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

      def commit(method, url, parameters = nil, options = {}, type = false)
        raw_response = response = nil
        success = false
        begin
          json = parameters ? parameters.to_json : nil
Severity: Minor
Found in lib/active_merchant/billing/gateways/worldpay_online_payments.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_post_for_auth_or_purchase has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

      def create_post_for_auth_or_purchase(token, money, options)
        {
          'token' => token,
          'orderDescription' => options[:description] || 'Worldpay Order',
          'amount' => money,
Severity: Minor
Found in lib/active_merchant/billing/gateways/worldpay_online_payments.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method commit has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def commit(method, url, parameters = nil, options = {}, type = false)
        raw_response = response = nil
        success = false
        begin
          json = parameters ? parameters.to_json : nil
Severity: Minor
Found in lib/active_merchant/billing/gateways/worldpay_online_payments.rb - About 1 hr to fix

    Method create_token has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def create_token(reusable, name, exp_month, exp_year, number, cvc)
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/worldpay_online_payments.rb - About 45 mins to fix

      Method commit has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def commit(method, url, parameters = nil, options = {}, type = false)
      Severity: Minor
      Found in lib/active_merchant/billing/gateways/worldpay_online_payments.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status