Sign upLogin

activerecord-hackery/polyamorous

View on GitHub
Star
lib/polyamorous/activerecord_3_and_4.0_ruby_1.9/join_dependency.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method find_join_association_respecting_polymorphism has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def find_join_association_respecting_polymorphism(reflection, parent, klass)
      if association = find_join_association(reflection, parent)
        unless reflection.options[:polymorphic]
          association
        else
Severity: Minor
Found in lib/polyamorous/activerecord_3_and_4.0_ruby_1.9/join_dependency.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method graft_with_polymorphism has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def graft_with_polymorphism(*associations)
      associations.each do |association|
        unless join_associations.detect { |a| association == a }
          if association.reflection.options[:polymorphic]
            build(
Severity: Minor
Found in lib/polyamorous/activerecord_3_and_4.0_ruby_1.9/join_dependency.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_with_polymorphism has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def build_with_polymorphism(
      associations, parent = nil, join_type = InnerJoin
    )
      case associations
      when Join
Severity: Minor
Found in lib/polyamorous/activerecord_3_and_4.0_ruby_1.9/join_dependency.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status