Sign upLogin

activerecord-hackery/ransack

View on GitHub
Star
lib/polyamorous/activerecord/join_association.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method join_constraints_with_tables has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def join_constraints_with_tables(foreign_table, foreign_klass, join_type, alias_tracker, tables)
      joins = []
      chain = []

      reflection.chain.each.with_index do |reflection, i|
Severity: Minor
Found in lib/polyamorous/activerecord/join_association.rb - About 1 hr to fix

    Method join_constraints_with_tables has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def join_constraints_with_tables(foreign_table, foreign_klass, join_type, alias_tracker, tables)
      joins = []
      chain = []

      reflection.chain.each.with_index do |reflection, i|
    Severity: Minor
    Found in lib/polyamorous/activerecord/join_association.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method join_constraints_with_tables has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def join_constraints_with_tables(foreign_table, foreign_klass, join_type, alias_tracker, tables)
    Severity: Minor
    Found in lib/polyamorous/activerecord/join_association.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status