activerecord-hackery/ransack

View on GitHub
lib/ransack/helpers/form_helper.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class SortLink has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

      class SortLink
        def initialize(search, attribute, args, params)
          @search         = search
          @params         = parameters_hash(params)
          @field          = attribute.to_s
Severity: Minor
Found in lib/ransack/helpers/form_helper.rb - About 2 hrs to fix

    Method search_form_for has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def search_form_for(record, options = {}, &proc)
            if record.is_a? Ransack::Search
              search = record
              options[:url] ||= polymorphic_path(
                search.klass, format: options.delete(:format)
    Severity: Minor
    Found in lib/ransack/helpers/form_helper.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sort_link has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def sort_link(search_object, attribute, *args, &block)
            search, routing_proxy = extract_search_and_routing_proxy(search_object)
            unless Search === search
              raise TypeError, 'First argument must be a Ransack::Search!'
            end
    Severity: Minor
    Found in lib/ransack/helpers/form_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status