Sign upLogin

activescaffold/active_scaffold

View on GitHub
Star
lib/active_scaffold/actions/list.rb

Summary

Maintainability
A
3 hrs
Test Coverage
F
52%

File list.rb has 257 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module ActiveScaffold::Actions
  module List
    def self.included(base)
      base.before_action :list_authorized_filter, :only => :index
      base.helper_method :list_columns, :count_on_association_class?
Severity: Minor
Found in lib/active_scaffold/actions/list.rb - About 2 hrs to fix

    Method set_includes_for_sorting has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def set_includes_for_sorting(columns, sorting)
      sorting.each_column do |col|
        next if sorting.constraint_columns.include? col.name
        next unless col.includes.present? && !columns.include?(col)
        if active_scaffold_config.model.connection.needs_order_expressions_in_select?
    Severity: Minor
    Found in lib/active_scaffold/actions/list.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status