Sign upLogin

acutesoftware/rawdata

View on GitHub
Star

Showing 73 of 73 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        txt += str(self.DateConv(row[5]))[0:21] + '","'
Severity: Minor
Found in scripts/gather/browser_usage.py and 1 other location - About 55 mins to fix
scripts/gather/browser_usage.py on lines 229..229

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        res += ' col sources = [' + ','.join([c for c in self.col_source]) + ']\n'
Severity: Major
Found in rawdata/content.py and 2 other locations - About 45 mins to fix
rawdata/content.py on lines 220..220
rawdata/content.py on lines 221..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                    if r[2] == row_loc:
                        amt += get_num_from_curr(r[4])
            tbl_agg.append([row_worker, row_loc, amt])
Severity: Major
Found in scripts/multigrain_data_generator.py - About 45 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            res += ' col types   = [' + ','.join([c for c in self.col_types]) + ']\n'
    Severity: Major
    Found in rawdata/content.py and 2 other locations - About 45 mins to fix
    rawdata/content.py on lines 220..220
    rawdata/content.py on lines 222..222

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid deeply nested control flow statements.
    Open

                            if col.strip('"').strip('\n') == col_name:
                            ndx = col_num
                #if 'tools.csv' in filename:
                #    print(cols)
                if line.strip('\n').strip('') != '':   # ignore blank lines
    Severity: Major
    Found in rawdata/content.py - About 45 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              self.history_file = self.op_folder + os.sep + 'chrome_history_' + dte + '.csv'
      Severity: Major
      Found in scripts/gather/browser_usage.py and 2 other locations - About 45 mins to fix
      scripts/gather/browser_usage.py on lines 49..49
      scripts/gather/browser_usage.py on lines 51..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              self.bookmarks_file = self.op_folder + os.sep + 'chrome_bookmarks_' + dte + '.csv'
      Severity: Major
      Found in scripts/gather/browser_usage.py and 2 other locations - About 45 mins to fix
      scripts/gather/browser_usage.py on lines 50..50
      scripts/gather/browser_usage.py on lines 51..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid deeply nested control flow statements.
      Open

                          if r[3] == row_worker:
                        num_jobs += 1
                        amt += get_num_from_curr(r[4])
            tbl_agg.append([row_year, row_worker, num_jobs, amt])
      Severity: Major
      Found in scripts/multigrain_data_generator.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if lst['name'] != 'INT':
                            if lst['name'] == self.colTypes[c]:
                                txt = get_rand_text_from_list(lst['lst'])
                thisRow.append(txt)
        Severity: Major
        Found in rawdata/generate.py - About 45 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  res += ' col labels  = [' + ','.join([c for c in self.col_labels]) + ']\n'
          Severity: Major
          Found in rawdata/content.py and 2 other locations - About 45 mins to fix
          rawdata/content.py on lines 221..221
          rawdata/content.py on lines 222..222

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid deeply nested control flow statements.
          Open

                              if random.randint(1,20) > 16:
                        txt += '.\n'
                    else:
                        txt +=  ' ' + random.choice(all_words)
                lst.append(txt)
          Severity: Major
          Found in rawdata/generate.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if cols[filter_col_id].strip('"').strip('\n') in filter_val_list:
                            #print('MATCH')
                            #print('cols[filter_col_id] = ', cols[filter_col_id])
                            #print('filter_val_list     = ', filter_val_list)
                            #print('cols[ndx] = ', cols[ndx].strip('\n').strip('"'))
            Severity: Major
            Found in rawdata/content.py - About 45 mins to fix

              Function get_passwords has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def get_passwords(self):
        """
        exports the logins and passwords from Chrome
        """
        if not os.path.exists(self.op_folder):
              Severity: Minor
              Found in scripts/gather/browser_usage.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      self.password_op = self.op_folder + os.sep + 'PASSWORDS_' + dte + '.csv'
              Severity: Major
              Found in scripts/gather/browser_usage.py and 2 other locations - About 45 mins to fix
              scripts/gather/browser_usage.py on lines 49..49
              scripts/gather/browser_usage.py on lines 50..50

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid deeply nested control flow statements.
              Open

                                      if col.strip('"').strip('\n') == col_name:
                            ndx = col_num
                else:
              Severity: Major
              Found in rawdata/content.py - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                def get_pc_name():
    """
    return the PC name (host / machine name)
    """
    try:
                Severity: Minor
                Found in scripts/gather/sys_PC_usage.py and 1 other location - About 40 mins to fix
                scripts/gather/sys_PC_usage.py on lines 10..19

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                def get_user():
    """
    return the name of the user logged on to the PC
    """
    try:
                Severity: Minor
                Found in scripts/gather/sys_PC_usage.py and 1 other location - About 40 mins to fix
                scripts/gather/sys_PC_usage.py on lines 21..30

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function save_table has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def save_table(tbl, hdr, fname, delim=',', qu='"'):
                Severity: Minor
                Found in scripts/multigrain_data_generator.py - About 35 mins to fix

                  Function rebuild_index has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def rebuild_index():
    """
    scans rawdata\data\ folders to create lookups
    of all tables, column names
    """
                  Severity: Minor
                  Found in scripts/install.py - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  if r[3] == row_worker:
                    if r[2] == row_loc:
                        amt += get_num_from_curr(r[4])
                  Severity: Minor
                  Found in scripts/multigrain_data_generator.py and 1 other location - About 35 mins to fix
                  scripts/multigrain_data_generator.py on lines 96..98

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 33.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language