Sign upLogin

adelevie/parse_resource

View on GitHub
Star
lib/parse_resource/query.rb

Summary

Maintainability
C
1 day
Test Coverage

Method turn_relation_hash_into_object has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def turn_relation_hash_into_object(hash)
    return nil if hash == nil or hash["className"] == "_User"
    relation_object = hash["className"].to_s.constantize.new if hash["className"] != "_User"
    hash.each do |key, value|
      class_name_in_a_hash = false
Severity: Minor
Found in lib/parse_resource/query.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Query has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class Query

  def initialize(klass)
    @klass = klass
  end
Severity: Minor
Found in lib/parse_resource/query.rb - About 2 hrs to fix

    Method execute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def execute
    if @klass.has_many_relations
      relations = @klass.has_many_relations.map { |relation| relation.to_s }
      include_object(relations)
    end
    Severity: Minor
    Found in lib/parse_resource/query.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method turn_relation_hash_into_object has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def turn_relation_hash_into_object(hash)
    return nil if hash == nil or hash["className"] == "_User"
    relation_object = hash["className"].to_s.constantize.new if hash["className"] != "_User"
    hash.each do |key, value|
      class_name_in_a_hash = false
    Severity: Minor
    Found in lib/parse_resource/query.rb - About 1 hr to fix

      Method get_relation_objects has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_relation_objects(objects)
    if @klass.has_many_relations
      objects.each do |item|
        @klass.has_many_relations.each do |relation|
          item.attributes[relation.to_s] = [] if !item.attributes.has_key?(relation.to_s)
      Severity: Minor
      Found in lib/parse_resource/query.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            attrib   = method_name.gsub(/^find_by_/,"")
      finder_name = "find_all_by_#{attrib}"

      define_singleton_method(finder_name) do |target_value|
        where({attrib.to_sym => target_value}).first
      Severity: Minor
      Found in lib/parse_resource/query.rb and 3 other locations - About 15 mins to fix
      lib/parse_resource/base.rb on lines 133..140
      lib/parse_resource/base.rb on lines 143..150
      lib/parse_resource/query.rb on lines 198..205

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            attrib   = method_name.gsub(/^find_all_by_/,"")
      finder_name = "find_all_by_#{attrib}"

      define_singleton_method(finder_name) do |target_value|
        where({attrib.to_sym => target_value}).all
      Severity: Minor
      Found in lib/parse_resource/query.rb and 3 other locations - About 15 mins to fix
      lib/parse_resource/base.rb on lines 133..140
      lib/parse_resource/base.rb on lines 143..150
      lib/parse_resource/query.rb on lines 188..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status