Sign upLogin

adhearsion/punchblock

View on GitHub
Star
lib/punchblock/translator/asterisk/call.rb

Summary

Maintainability
F
3 days
Test Coverage

Method execute_command has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

        def execute_command(command)
          if @block_commands
            command.response = ProtocolError.new.setup :item_not_found, "Could not find a call with ID #{id}", id
            return
          end
Severity: Minor
Found in lib/punchblock/translator/asterisk/call.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File call.rb has 356 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'punchblock/translator/asterisk/ami_error_converter'

module Punchblock
  module Translator
    class Asterisk
Severity: Minor
Found in lib/punchblock/translator/asterisk/call.rb - About 4 hrs to fix

    Class Call has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

          class Call
        include HasGuardedHandlers
        include DeadActorSafety

        InvalidCommandError = Class.new Punchblock::Error
    Severity: Minor
    Found in lib/punchblock/translator/asterisk/call.rb - About 3 hrs to fix

      Method execute_command has 94 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def execute_command(command)
          if @block_commands
            command.response = ProtocolError.new.setup :item_not_found, "Could not find a call with ID #{id}", id
            return
          end
      Severity: Major
      Found in lib/punchblock/translator/asterisk/call.rb - About 3 hrs to fix

        Method process_ami_event has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
        Open

                def process_ami_event(ami_event)
          if Asterisk.event_passes_filter?(ami_event)
            send_pb_event Event::Asterisk::AMI::Event.new(name: ami_event.name, headers: ami_event.headers)
          end
        Severity: Minor
        Found in lib/punchblock/translator/asterisk/call.rb - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method process_ami_event has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def process_ami_event(ami_event)
          if Asterisk.event_passes_filter?(ami_event)
            send_pb_event Event::Asterisk::AMI::Event.new(name: ami_event.name, headers: ami_event.headers)
          end
        Severity: Major
        Found in lib/punchblock/translator/asterisk/call.rb - About 2 hrs to fix

          Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def initialize(channel, translator, ami_client, connection, agi_env = nil, id = nil)
          Severity: Minor
          Found in lib/punchblock/translator/asterisk/call.rb - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                       when 'BridgeLeave'
            if other_call = ami_event['OtherCall']
              event = Event::Unjoined.new call_uri: other_call.id, timestamp: ami_event.best_time
              send_pb_event event
            Severity: Minor
            Found in lib/punchblock/translator/asterisk/call.rb and 1 other location - About 45 mins to fix
            lib/punchblock/translator/asterisk/call.rb on lines 139..146

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 39.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      when 'BridgeEnter'
            if other_call = ami_event['OtherCall']
              event = Event::Joined.new call_uri: other_call.id, timestamp: ami_event.best_time
              send_pb_event event
            Severity: Minor
            Found in lib/punchblock/translator/asterisk/call.rb and 1 other location - About 45 mins to fix
            lib/punchblock/translator/asterisk/call.rb on lines 148..155

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 39.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                      if command.component_id
            if component = component_with_id(command.component_id)
              component.execute_command command
            else
              command.response = ProtocolError.new.setup :item_not_found, "Could not find a component with ID #{command.component_id} for call #{id}", id, command.component_id
            Severity: Minor
            Found in lib/punchblock/translator/asterisk/call.rb and 1 other location - About 20 mins to fix
            lib/punchblock/translator/freeswitch/call.rb on lines 174..178

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status