adobe/brackets

View on GitHub

Showing 3,294 of 3,294 total issues

Function _openInterstitialPage has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function _openInterstitialPage() {
        var browserStarted  = false,
            retryCount      = 0;

        // Open the live browser if the connection fails, retry 3 times
Severity: Major
Found in src/LiveDevelopment/LiveDevelopment.js - About 3 hrs to fix

    Function showUpdateBar has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function showUpdateBar(msgObj) {
            var jsonToMustache = generateJsonForMustache(msgObj),
                $updateBarElement = $(Mustache.render(UpdateBarHtml, jsonToMustache));
    
            cleanUpdateBar(); //Remove an already existing update bar, if any
    Severity: Major
    Found in src/extensions/default/AutoUpdate/UpdateInfoBar.js - About 3 hrs to fix

      Function presentConflicts has 85 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function presentConflicts(title) {
      
              var allConflicts = editConflicts.concat(deleteConflicts);
      
              function presentConflict(docInfo, i) {
      Severity: Major
      Found in src/project/FileSyncManager.js - About 3 hrs to fix

        Function trigger has 85 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            trigger: function( event, data, elem, onlyHandlers ) {
        
                var i, cur, tmp, bubbleType, ontype, handle, special,
                    eventPath = [ elem || document ],
                    type = hasOwn.call( event, "type" ) ? event.type : event,
        Severity: Major
        Found in src/thirdparty/jquery-2.1.3.js - About 3 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      function saveSetter(name, token) {
                          if (props[name] && is_own(props, name)) {
                              if (props[name].basic || props[name].setter)
                                  warning("Duplicate member '{a}'.", nexttoken, i);
                          } else {
          src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/external/jshint.js on lines 3271..3281

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              Map.prototype.mergeIn = function(keyPath) {var iters = SLICE$0.call(arguments, 1);
                return this.updateIn(
                  keyPath,
                  emptyMap(),
                  function(m ) {return typeof m.merge === 'function' ?
          Severity: Major
          Found in src/thirdparty/immutable.js and 1 other location - About 3 hrs to fix
          src/thirdparty/immutable.js on lines 1329..1337

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function Builder(text, startOffset, startOffsetPos) {
                  this.stack = [];
                  this.text = text;
                  this.t = new Tokenizer(text);
                  this.currentTag = null;
          Severity: Major
          Found in src/language/HTMLSimpleDOM.js and 1 other location - About 3 hrs to fix
          src/LiveDevelopment/MultiBrowserImpl/language/HTMLSimpleDOM.js on lines 236..243

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              Map.prototype.mergeDeepIn = function(keyPath) {var iters = SLICE$0.call(arguments, 1);
                return this.updateIn(
                  keyPath,
                  emptyMap(),
                  function(m ) {return typeof m.mergeDeep === 'function' ?
          Severity: Major
          Found in src/thirdparty/immutable.js and 1 other location - About 3 hrs to fix
          src/thirdparty/immutable.js on lines 1311..1319

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      it("should show argument from from .prototype.Method", function () {
                          var start = { line: 80, ch: 0 },
                              testPos = { line: 80, ch: 24 };
          
                          testDoc.replaceRange("myCustomer.setAmountDue(", start);
          Severity: Major
          Found in src/extensions/default/JavaScriptCodeHints/unittests.js and 1 other location - About 3 hrs to fix
          src/extensions/default/JavaScriptCodeHints/unittests.js on lines 1193..1201

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      it("should show guessed argument type from current passing parameter", function () {
                          var start = { line: 80, ch: 0 },
                              testPos = { line: 80, ch: 24 };
                          testDoc.replaceRange("myCustomer.setAmountDue(10)", start);
                          testEditor.setCursorPos(testPos);
          Severity: Major
          Found in src/extensions/default/JavaScriptCodeHints/unittests.js and 1 other location - About 3 hrs to fix
          src/extensions/default/JavaScriptCodeHints/unittests.js on lines 925..934

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function Builder(text, startOffset, startOffsetPos) {
                  this.stack = [];
                  this.text = text;
                  this.t = new Tokenizer(text);
                  this.currentTag = null;
          src/language/HTMLSimpleDOM.js on lines 271..278

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      function saveGetter(name) {
                          if (props[name] && is_own(props, name)) {
                              if (props[name].basic || props[name].getter)
                                  warning("Duplicate member '{a}'.", nexttoken, i);
                          } else {
          src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/external/jshint.js on lines 3259..3269

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File FileSystemEntry.js has 308 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /*
           * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.
           *
           * Permission is hereby granted, free of charge, to any person obtaining a
           * copy of this software and associated documentation files (the "Software"),
          Severity: Minor
          Found in src/filesystem/FileSystemEntry.js - About 3 hrs to fix

            Function doAnimation has 84 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    function doAnimation() {
                        // XXX 'this' does not always have a nodeName when running the
                        // test suite
            
                        if ( optall.queue === false ) {

              Function handleExtractToVariable has 84 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function handleExtractToVariable() {
                      var editor = EditorManager.getActiveEditor();
              
                      if (editor.getSelections().length > 1) {
                          editor.displayErrorMessageAtCursor(Strings.ERROR_EXTRACTTO_VARIABLE_MULTICURSORS);
              Severity: Major
              Found in src/extensions/default/JavaScriptRefactoring/ExtractToVariable.js - About 3 hrs to fix

                Function Animation has 84 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function Animation( elem, properties, options ) {
                    var result,
                        stopped,
                        index = 0,
                        length = animationPrefilters.length,
                Severity: Major
                Found in src/thirdparty/jquery-2.1.3.js - About 3 hrs to fix

                  Function _keydown has 83 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      _keydown: function( event ) {
                          var match, prev, character, skip,
                              preventDefault = true;
                  
                          function escape( value ) {

                    Function _create has 83 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        _create: function() {
                            this.activeMenu = this.element;
                            this.element
                                .uniqueId()
                                .addClass( "ui-menu ui-widget ui-widget-content ui-corner-all" )

                      Function labelled has 83 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          blockstmt('for', function () {
                              var s, t = nexttoken;
                              funct['(breakage)'] += 1;
                              funct['(loopage)'] += 1;
                              advance('(');

                        File ViewUtils.js has 305 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        /*
                         * Copyright (c) 2012 - present Adobe Systems Incorporated. All rights reserved.
                         *
                         * Permission is hereby granted, free of charge, to any person obtaining a
                         * copy of this software and associated documentation files (the "Software"),
                        Severity: Minor
                        Found in src/utils/ViewUtils.js - About 3 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language