adobe/brackets

View on GitHub

Showing 3,294 of 3,294 total issues

Function _formatParameterHint has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function _formatParameterHint(params, appendSeparators, appendParameter, typesOnly) {
        var result = "",
            pendingOptional = false;

        appendParameter("(", "", -1);
Severity: Minor
Found in src/features/ParameterHintsManager.js - About 1 hr to fix

    Function _buildListView has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        InlineMenu.prototype._buildListView = function (items) {
            var self            = this,
                view            = { items: [] },
                _addItem;
    
    
    Severity: Minor
    Found in src/widgets/InlineMenu.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          noConflict: function( deep ) {
              if ( window.$ === jQuery ) {
                  window.$ = _$;
              }
      
      
      src/thirdparty/jquery-2.1.3.js on lines 9181..9191

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      jQuery.noConflict = function( deep ) {
          if ( window.$ === jQuery ) {
              window.$ = _$;
          }
      
      
      Severity: Major
      Found in src/thirdparty/jquery-2.1.3.js and 1 other location - About 1 hr to fix
      src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/jquery-1.7.2.js on lines 389..399

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              var communication = serverOptions.communication || CommunicationTypes.StandardIO.type,
                  args = _getArguments(serverOptions),
                  options = _getOptions(serverOptions),
                  processArgs = {
                      args: args,
      Severity: Major
      Found in src/languageTools/LanguageClient/ServerUtils.js and 1 other location - About 1 hr to fix
      src/languageTools/LanguageClient/ServerUtils.js on lines 311..318

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              var communication = serverOptions.communication || CommunicationTypes.StandardIO.type,
                  args = _getArguments(serverOptions),
                  options = _getOptions(serverOptions),
                  processArgs = {
                      args: args,
      Severity: Major
      Found in src/languageTools/LanguageClient/ServerUtils.js and 1 other location - About 1 hr to fix
      src/languageTools/LanguageClient/ServerUtils.js on lines 357..364

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              top: function() {
                  $.ui.position.flip.top.apply( this, arguments );
                  $.ui.position.fit.top.apply( this, arguments );
              }
      src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/ui/jquery.ui.position.js on lines 430..433

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (option.undef && typeof predefined[v] !== 'boolean') {
                          // Attempting to subscript a null reference will throw an
                          // error, even within the typeof and delete operators
                          if (!(anonname === 'typeof' || anonname === 'delete') ||
                              (nexttoken && (nexttoken.value === '.' || nexttoken.value === '['))) {
      src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/external/jshint.js on lines 2709..2718

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              if (option.undef) {
                                  // Attempting to subscript a null reference will throw an
                                  // error, even within the typeof and delete operators
                                  if (!(anonname === 'typeof' || anonname === 'delete') ||
                                      (nexttoken &&
      src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/external/jshint.js on lines 2670..2678

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  return nextProps.forceRender ||
                      this.props.entry !== nextProps.entry ||
                      this.props.sortDirectoriesFirst !== nextProps.sortDirectoriesFirst ||
                      this.props.extensions !== nextProps.extensions ||
                      (nextState !== undefined && this.state.draggedOver !== nextState.draggedOver);
      Severity: Major
      Found in src/project/FileTreeView.js and 1 other location - About 1 hr to fix
      src/project/FileTreeView.js on lines 1144..1148

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  return nextProps.forceRender ||
                      this.props.treeData !== nextProps.treeData ||
                      this.props.sortDirectoriesFirst !== nextProps.sortDirectoriesFirst ||
                      this.props.extensions !== nextProps.extensions ||
                      this.props.selectionViewInfo !== nextProps.selectionViewInfo;
      Severity: Major
      Found in src/project/FileTreeView.js and 1 other location - About 1 hr to fix
      src/project/FileTreeView.js on lines 791..795

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              left: function() {
                  $.ui.position.flip.left.apply( this, arguments );
                  $.ui.position.fit.left.apply( this, arguments );
              },
      src/extensions/default/JavaScriptQuickEdit/unittest-files/jquery-ui/ui/jquery.ui.position.js on lines 434..437

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function settingsToRegExp has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function settingsToRegExp(settings, baseRegExp, defaultRegExp) {
              var regExpString = "";
      
              if (settings instanceof Array && settings.length > 0) {
      
      
      Severity: Minor
      Found in src/JSUtils/Preferences.js - About 1 hr to fix

        Function addSubMenu has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            Menu.prototype.addSubMenu = function (name, id, position, relativeID) {
        
                if (!name || !id) {
                    console.error("addSubMenu(): missing required parameters: name and id");
                    return null;
        Severity: Minor
        Found in src/command/Menus.js - About 1 hr to fix

          Function init has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function init(domainManager) {
              _domainManager = domainManager;
              if (!domainManager.hasDomain("webSocketTransport")) {
                  domainManager.registerDomain("webSocketTransport", {major: 0, minor: 1});
              }
          Severity: Minor
          Found in src/LiveDevelopment/transports/node/WebSocketTransportDomain.js - About 1 hr to fix

            Function getHints has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                JSHints.prototype.getHints = function (key) {
                    var cursor = session.getCursor(),
                        token = session.getToken(cursor);
            
                    if (token && HintUtils.hintableKey(key, !noHintsOnDot) && HintUtils.hintable(token)) {
            Severity: Minor
            Found in src/extensions/default/JavaScriptCodeHints/main.js - About 1 hr to fix

              Function update has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  DOMUpdater.prototype.update = function () {
                      var markCache = {},
                          newSubtree = this.build(true, markCache),
                          result = {
                              // default result if we didn't identify a changed portion

                Function getAnalyticsData has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function getAnalyticsData(eventParams) {
                        var userUuid = PreferencesManager.getViewState("UUID"),
                            olderUuid = PreferencesManager.getViewState("OlderUUID");
                
                        //Create default Values
                Severity: Minor
                Found in src/extensions/default/HealthData/HealthDataManager.js - About 1 hr to fix

                  Function _mouseStart has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      _mouseStart: function(event) {
                  
                          var o = this.options;
                  
                          //Create and append the visible helper

                    Function expression has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        function expression(rbp, initial) {
                            var left, isArray = false;
                    
                            if (nexttoken.id === '(end)')
                                error("Unexpected early end of program.", token);
                      Severity
                      Category
                      Status
                      Source
                      Language