Sign upLogin

advaithm/cloudflare-DDNS

View on GitHub
Star

Showing 2 of 4 total issues

Function update_ips has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def update_ips(self) -> bool:
        current_ip = requests.get("https://wtfismyip.com/json").json()[
            "YourFuckingIPAddress"
        ]
        domains_updated = False
Severity: Minor
Found in cloudflare_ddns/cloudflare.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The input method in Python 2 will read from standard input, evaluate and run the resulting string as python source code. This is similar, though in many ways worse, then using eval. On Python 2, use raw_input instead, input is safe in Python 3.
Open

    settings["domains"][domain_to_remove] = input(
        f"enter new value for domain {settings['domains'][domain_to_remove]}: "
Severity: Major
Found in cloudflare_ddns/cli.py by bandit
Severity
Category
Status
Source
Language