Sign upLogin

aeolus-incubator/tim

View on GitHub
Star
lib/image_factory/oauth/active_resource_oauth_client.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method request_with_oauth has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def request_with_oauth(method, path, *arguments)
      @oauth_config = Tim::ImageFactory::Base.config || {}
      # Take care to fall back to the standard request method if we don't have full OAuth credentials
      unless use_oauth_for_url?("#{site.scheme}://#{site.host}:#{site.port}#{path}")
        return request_without_oauth(method, path, *arguments)
Severity: Minor
Found in lib/image_factory/oauth/active_resource_oauth_client.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request_with_oauth has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def request_with_oauth(method, path, *arguments)
      @oauth_config = Tim::ImageFactory::Base.config || {}
      # Take care to fall back to the standard request method if we don't have full OAuth credentials
      unless use_oauth_for_url?("#{site.scheme}://#{site.host}:#{site.port}#{path}")
        return request_without_oauth(method, path, *arguments)
Severity: Minor
Found in lib/image_factory/oauth/active_resource_oauth_client.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status