Sign upLogin

aeolusproject/conductor

View on GitHub
Star
src/app/controllers/deployments_controller.rb

Summary

Maintainability
F
4 days
Test Coverage

File deployments_controller.rb has 433 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class DeploymentsController < ApplicationController
  before_filter :require_user
  before_filter :load_deployments, :only => [:index, :show]
  before_filter :load_deployment, :only => [:edit, :update]
  before_filter :check_inaccessible_instances, :only => :multi_stop
Severity: Minor
Found in src/app/controllers/deployments_controller.rb - About 6 hrs to fix

    Method launch_time_params has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      def launch_time_params
    @title = _('New Deployment')

    @deployment = Deployment.new(params[:deployment])
    @pool = @deployment.pool
    Severity: Minor
    Found in src/app/controllers/deployments_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class DeploymentsController has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class DeploymentsController < ApplicationController
  before_filter :require_user
  before_filter :load_deployments, :only => [:index, :show]
  before_filter :load_deployment, :only => [:edit, :update]
  before_filter :check_inaccessible_instances, :only => :multi_stop
    Severity: Minor
    Found in src/app/controllers/deployments_controller.rb - About 2 hrs to fix

      Method multi_stop has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

        def multi_stop
    notices = []
    errors = []

    @deployments_to_stop.each do |deployment|
      Severity: Minor
      Found in src/app/controllers/deployments_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def create
    @deployment = Deployment.new(params[:deployment])
    @pool = @deployment.pool
    require_privilege(Alberich::Privilege::CREATE, Deployment, @pool)
      Severity: Minor
      Found in src/app/controllers/deployments_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method show has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def show
    @deployment = Deployment.find(params[:id])
    @title = _('%s Deployment') % @deployment.name
    require_privilege(Alberich::Privilege::VIEW, @deployment)
    init_new_deployment_attrs
      Severity: Minor
      Found in src/app/controllers/deployments_controller.rb - About 1 hr to fix

        Method create has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def create
    @deployment = Deployment.new(params[:deployment])
    @pool = @deployment.pool
    require_privilege(Alberich::Privilege::CREATE, Deployment, @pool)
        Severity: Minor
        Found in src/app/controllers/deployments_controller.rb - About 1 hr to fix

          Method multi_stop has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def multi_stop
    notices = []
    errors = []

    @deployments_to_stop.each do |deployment|
          Severity: Minor
          Found in src/app/controllers/deployments_controller.rb - About 1 hr to fix

            Method launch_time_params has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def launch_time_params
    @title = _('New Deployment')

    @deployment = Deployment.new(params[:deployment])
    @pool = @deployment.pool
            Severity: Minor
            Found in src/app/controllers/deployments_controller.rb - About 1 hr to fix

              Method destroy has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def destroy
    deployment = Deployment.find(params[:id])
    cant_stop = false
    errors = []
    begin
              Severity: Minor
              Found in src/app/controllers/deployments_controller.rb - About 1 hr to fix

                Method multi_destroy has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                  def multi_destroy
    destroyed = []
    errors = []

    ids = Array(params[:deployments_selected])
                Severity: Minor
                Found in src/app/controllers/deployments_controller.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method multi_destroy has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def multi_destroy
    destroyed = []
    errors = []

    ids = Array(params[:deployments_selected])
                Severity: Minor
                Found in src/app/controllers/deployments_controller.rb - About 1 hr to fix

                  Method show has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def show
    @deployment = Deployment.find(params[:id])
    @title = _('%s Deployment') % @deployment.name
    require_privilege(Alberich::Privilege::VIEW, @deployment)
    init_new_deployment_attrs
                  Severity: Minor
                  Found in src/app/controllers/deployments_controller.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method load_deployments has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def load_deployments
    @deployments_header = [
      { :name => 'checkbox', :class => 'checkbox', :sortable => false },
      { :name => '', :class => 'alert', :sortable => false },
      { :name => _('Deployment Name'), :sortable => false },
                  Severity: Minor
                  Found in src/app/controllers/deployments_controller.rb - About 1 hr to fix

                    Method destroy has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def destroy
    deployment = Deployment.find(params[:id])
    cant_stop = false
    errors = []
    begin
                    Severity: Minor
                    Found in src/app/controllers/deployments_controller.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def update
    attrs = {}
    params[:deployment].each_pair{|k,v| attrs[k] = v if Deployment::USER_MUTABLE_ATTRS.include?(k)}
    respond_to do |format|
      if check_privilege(Alberich::Privilege::MODIFY, @deployment) and @deployment.update_attributes(attrs)
                    Severity: Minor
                    Found in src/app/controllers/deployments_controller.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method overview has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def overview
    @title = _('New Deployment')
    @deployment = Deployment.new(params[:deployment])
    @pool = @deployment.pool
    init_new_deployment_attrs
                    Severity: Minor
                    Found in src/app/controllers/deployments_controller.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method launch_new has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def launch_new
    @title = _('New Deployment')

    if params[:deployment].present?
      @deployment = Deployment.new(params[:deployment])
                    Severity: Minor
                    Found in src/app/controllers/deployments_controller.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      def update
    attrs = {}
    params[:deployment].each_pair{|k,v| attrs[k] = v if Deployment::USER_MUTABLE_ATTRS.include?(k)}
    respond_to do |format|
      if check_privilege(Alberich::Privilege::MODIFY, @deployment) and @deployment.update_attributes(attrs)
                    Severity: Major
                    Found in src/app/controllers/deployments_controller.rb and 1 other location - About 2 hrs to fix
                    src/app/controllers/instances_controller.rb on lines 72..89

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 93.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        @deployments_header = [
      { :name => 'checkbox', :class => 'checkbox', :sortable => false },
      { :name => '', :class => 'alert', :sortable => false },
      { :name => _('Deployment Name'), :sortable => false },
      { :name => _('Deployed on'), :sortable => false },
                    Severity: Major
                    Found in src/app/controllers/deployments_controller.rb and 1 other location - About 1 hr to fix
                    src/app/controllers/pools_controller.rb on lines 387..398

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 66.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if params[:terminate].blank? and @inaccessible_instances.any?
      respond_to do |format|
        format.html { render :action => :confirm_terminate }
        format.json { render :json => {:inaccessbile_instances => @inaccessible_instances}, :status => :unprocessable_entity }
      end
                    Severity: Minor
                    Found in src/app/controllers/deployments_controller.rb and 1 other location - About 30 mins to fix
                    src/app/controllers/instances_controller.rb on lines 277..283

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 33.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                        unless warnings.empty?
      flash[:warning] ||= []
      flash[:warning] = [flash[:warning]] if flash[:warning].kind_of? String
      flash[:warning]+=warnings
    end
                    Severity: Minor
                    Found in src/app/controllers/deployments_controller.rb and 2 other locations - About 20 mins to fix
                    src/app/controllers/deployables_controller.rb on lines 209..213
                    src/app/controllers/deployables_controller.rb on lines 249..253

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 27.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status