Sign upLogin

aeolusproject/conductor

View on GitHub
Star
src/app/controllers/logs_controller.rb

Summary

Maintainability
F
5 days
Test Coverage

Method load_events has a Cognitive Complexity of 94 (exceeds 5 allowed). Consider refactoring.
Open

  def load_events
    @source_type = params[:source_type].nil? ? "" : params[:source_type]
    @pool_select = params[:pool_select].nil? ? "" : params[:pool_select]
    @provider_select =
      params[:provider_select].nil? ? "" : params[:provider_select]
Severity: Minor
Found in src/app/controllers/logs_controller.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method export_logs has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

  def export_logs
    load_events
    load_headers

    csvm = get_csv_class
Severity: Minor
Found in src/app/controllers/logs_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load_events has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def load_events
    @source_type = params[:source_type].nil? ? "" : params[:source_type]
    @pool_select = params[:pool_select].nil? ? "" : params[:pool_select]
    @provider_select =
      params[:provider_select].nil? ? "" : params[:provider_select]
Severity: Major
Found in src/app/controllers/logs_controller.rb - About 3 hrs to fix

    File logs_controller.rb has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class LogsController < ApplicationController
  before_filter :require_user

  def index
    clear_breadcrumbs
    Severity: Minor
    Found in src/app/controllers/logs_controller.rb - About 2 hrs to fix

      Method generate_graph has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

        def generate_graph
    @group = params[:group].nil? ? "" : params[:group]

    start_code = (@source_type == 'Deployment' ? 'first_running' : 'running')
    end_code = (@source_type == 'Deployment' ? 'all_stopped' : 'stopped')
      Severity: Minor
      Found in src/app/controllers/logs_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method generate_graph has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def generate_graph
    @group = params[:group].nil? ? "" : params[:group]

    start_code = (@source_type == 'Deployment' ? 'first_running' : 'running')
    end_code = (@source_type == 'Deployment' ? 'all_stopped' : 'stopped')
      Severity: Major
      Found in src/app/controllers/logs_controller.rb - About 2 hrs to fix

        Method get_source_label has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_source_label(source, label_type)
    label = "Unknown"
    if !source.nil?
      case label_type
      when _('Pool')
        Severity: Minor
        Found in src/app/controllers/logs_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method load_options has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def load_options
    if @view == "pretty"
      @source_type_options = [[_('Deployment'), "Deployment"],
                              [_('Instance'), "Instance"]]
      @group_options = [[_('All'), ""],
        Severity: Minor
        Found in src/app/controllers/logs_controller.rb - About 1 hr to fix

          Method index has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            def index
    clear_breadcrumbs
    save_breadcrumb(logs_path)

    params[:view] = "filter" if params[:view].nil?
          Severity: Minor
          Found in src/app/controllers/logs_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method export_logs has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def export_logs
    load_events
    load_headers

    csvm = get_csv_class
          Severity: Minor
          Found in src/app/controllers/logs_controller.rb - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  Provider.list_for_user(current_session, current_user, Alberich::Privilege::VIEW).
        find(:all, :include => :provider_accounts, :order => "providers.name",
             :select => ["id", "name"]).each do |provider|
        @provider_options << [provider.name, "provider:" + provider.id.to_s]
        @provider_options += provider.provider_accounts.
            Severity: Major
            Found in src/app/controllers/logs_controller.rb and 1 other location - About 1 hr to fix
            src/app/controllers/logs_controller.rb on lines 225..232

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  PoolFamily.list_for_user(current_session, current_user, Alberich::Privilege::VIEW).
        find(:all, :include => :pools, :order => "pool_families.name",
             :select => ["id", "name"]).each do |pool_family|
        @pool_options << [pool_family.name,
                          "pool_family:" + pool_family.id.to_s]
            Severity: Major
            Found in src/app/controllers/logs_controller.rb and 1 other location - About 1 hr to fix
            src/app/controllers/logs_controller.rb on lines 234..240

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                @from_date = params[:from_date].nil? ? Date.today - 7.days :
      Date.civil(params[:from_date][:year].to_i,
                 params[:from_date][:month].to_i,
                 params[:from_date][:day].to_i)
    @to_date = params[:to_date].nil? ? Date.today :
            Severity: Minor
            Found in src/app/controllers/logs_controller.rb and 1 other location - About 25 mins to fix
            src/app/controllers/providers_controller.rb on lines 25..29

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 31.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                @to_date = params[:to_date].nil? ? Date.today :
      Date.civil(params[:to_date][:year].to_i,
                 params[:to_date][:month].to_i,
                 params[:to_date][:day].to_i)
            Severity: Minor
            Found in src/app/controllers/logs_controller.rb and 1 other location - About 20 mins to fix
            src/app/controllers/providers_controller.rb on lines 29..34

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 28.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status