Sign upLogin

aeolusproject/conductor

View on GitHub
Star
src/app/controllers/pools_controller.rb

Summary

Maintainability
F
3 days
Test Coverage

File pools_controller.rb has 381 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class PoolsController < ApplicationController
  include QuotaAware
  before_filter :require_user
  before_filter :set_params_and_header, :only => [:index, :show]
  before_filter :load_pools, :only => [:show]
Severity: Minor
Found in src/app/controllers/pools_controller.rb - About 5 hrs to fix

    Method index has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

      def index
    clear_breadcrumbs
    save_breadcrumb(pools_path(:viewstate => viewstate_id))

    # This is primarily relevant to filter_view, but we check @details_tab in other places:
    Severity: Minor
    Found in src/app/controllers/pools_controller.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method index has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def index
    clear_breadcrumbs
    save_breadcrumb(pools_path(:viewstate => viewstate_id))

    # This is primarily relevant to filter_view, but we check @details_tab in other places:
    Severity: Major
    Found in src/app/controllers/pools_controller.rb - About 3 hrs to fix

      Method show has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

        def show
    @pool = Pool.find(params[:id])
    @title = @pool.name
    save_breadcrumb(pool_path(@pool, :viewstate => viewstate_id), @pool.name)
    require_privilege(Alberich::Privilege::VIEW, @pool)
      Severity: Minor
      Found in src/app/controllers/pools_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method destroy has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        def destroy
    destroyed = []
    failed = []
    permission_failed = []
    error_messages = []
      Severity: Minor
      Found in src/app/controllers/pools_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method show has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def show
    @pool = Pool.find(params[:id])
    @title = @pool.name
    save_breadcrumb(pool_path(@pool, :viewstate => viewstate_id), @pool.name)
    require_privilege(Alberich::Privilege::VIEW, @pool)
      Severity: Minor
      Found in src/app/controllers/pools_controller.rb - About 2 hrs to fix

        Method destroy has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def destroy
    destroyed = []
    failed = []
    permission_failed = []
    error_messages = []
        Severity: Minor
        Found in src/app/controllers/pools_controller.rb - About 1 hr to fix

          Method multi_destroy has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            def multi_destroy
    destroyed = []
    failed = []
    permission_failed = []
    error_messages = []
          Severity: Minor
          Found in src/app/controllers/pools_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method multi_destroy has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def multi_destroy
    destroyed = []
    failed = []
    permission_failed = []
    error_messages = []
          Severity: Minor
          Found in src/app/controllers/pools_controller.rb - About 1 hr to fix

            Method update has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def update
    transform_quota_param(:pool)
    @pool = Pool.find(params[:id])
    require_privilege(Alberich::Privilege::MODIFY, @pool)
    @catalogs = @pool.catalogs.list_for_user(current_session, current_user,
            Severity: Minor
            Found in src/app/controllers/pools_controller.rb - About 1 hr to fix

              Method create has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def create
    transform_quota_param(:pool)
    @title = _('New Pool')
    @pool = Pool.new(params[:pool])
    @pool.quota = Quota.new(params[:pool][:quota_attributes])
              Severity: Minor
              Found in src/app/controllers/pools_controller.rb - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    @deployments_header = [
      { :name => 'checkbox', :class => 'checkbox', :sortable => false },
      { :name => '', :class => 'alert', :sortable => false },
      { :name => _('Deployment Name'), :sortable => false },
      { :name => _('Deployed on'), :sortable => false },
                Severity: Major
                Found in src/app/controllers/pools_controller.rb and 1 other location - About 1 hr to fix
                src/app/controllers/deployments_controller.rb on lines 426..437

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      if pool.id == MetadataObject.lookup("self_service_default_pool").id
        error_messages << _('The default Pool cannot be deleted.')
      elsif !check_privilege(Alberich::Privilege::MODIFY, pool)
        permission_failed << pool.name
      elsif !pool.destroyable?
                Severity: Minor
                Found in src/app/controllers/pools_controller.rb and 1 other location - About 40 mins to fix
                src/app/controllers/pools_controller.rb on lines 290..299

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 38.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      if pool.id == MetadataObject.lookup("self_service_default_pool").id
        error_messages << _('The default Pool cannot be deleted.')
      elsif !check_privilege(Alberich::Privilege::MODIFY, pool)
        permission_failed << pool.name
      elsif !pool.destroyable?
                Severity: Minor
                Found in src/app/controllers/pools_controller.rb and 1 other location - About 40 mins to fix
                src/app/controllers/pools_controller.rb on lines 338..347

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 38.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      when 'pools'
        @pools = paginate_collection(
          Pool.includes(:deployments, :instances).
            apply_filters(:preset_filter_id => params[:pools_preset_filter],
                          :search_filter => params[:pools_search]).
                Severity: Minor
                Found in src/app/controllers/pools_controller.rb and 1 other location - About 30 mins to fix
                src/app/controllers/pools_controller.rb on lines 72..80

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 33.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      when 'deployments'
        @deployments = paginate_collection(
          Deployment.includes(:pool, :instances).
            apply_filters(:preset_filter_id =>
                            params[:deployments_preset_filter],
                Severity: Minor
                Found in src/app/controllers/pools_controller.rb and 1 other location - About 30 mins to fix
                src/app/controllers/pools_controller.rb on lines 55..62

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 33.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status